Bug#824912: tracker.d.o: add an API for action items
Hi,
On Wed, 14 Dec 2016, efkin wrote:
> thx for detailed answers. i'm attaching a new set of patches trying to
> include what we discussed.
Ok. A few easy comments:
> Subject: [PATCH 1/3] Include rest_framework dependency
[...]
> --- a/docs/setup/setup.rst
> +++ b/docs/setup/setup.rst
> @@ -15,6 +15,7 @@ Distro Tracker currently depends on the following Debian packages:
> - python-django-jsonfield (>= 1.0.0)
> - python-django-debug-toolbar (in development mode only)
> - python-django-captcha (optional)
> +- python-djangorestframework
Can you say what minimal version? We have 3.4 in testing/unstable but
2.4.3 in jessie.
I'm fine with requiring 3.4 although it has not yet been backported
for jessie. That will have to happen if we want to push this new module into
production.
> From e4336cb0549d1aae395de328dafb8f2f209400a5 Mon Sep 17 00:00:00 2001
> From: efkin <efkin@riseup.net>
> Date: Wed, 14 Dec 2016 18:45:09 +0100
> Subject: [PATCH 3/3] Create basic API list/detail endpoint for ActionItem
> model instances
>
> Reported_by: pabs@debian.org
Reported-by: Paul Wise <pabs@debian.org>
> ---
> distro_tracker/api/tests.py | 95 +++++++++++++++++++++++++++++++++++++++++-
> distro_tracker/api/views.py | 42 ++++++++++++++++++-
> distro_tracker/project/urls.py | 8 ++++
Please don't modify project/urls.py directly. Use api/tracker_urls.py
instead (see derivative/tracker_urls.py as an example).
I have not reviewed the rest yet.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/
Reply to: