Bug#786644: reproducible builds should vary whether nocheck is added to DEB_BUILD_OPTIONS

[Helmut Grohne <helmut@subdivi.de>]

Package: qa.debian.org
Severity: wishlist
User: qa.debian.org@packages.debian.org
Usertags: jenkins

I'd expect that setting DEB_BUILD_OPTIONS=nocheck on a package build
should not change the resulting binary packages. It might make the build
succeed despite being broken, but if it succeeds without nocheck, it
should be no different when enabled.

I therefore suggest that the reproducible testing builds packages first
without adding nocheck (like it does already) and adds nocheck to the
second build only as a further variation.

As a small benefit, this should also speed up the testing a little bit.

I am not aware of packages that embed their test results into the binary
packages, but we will likely find some corner cases.

Please consider this further variation

Helmut