[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#782109: marked as done (debsources: please highlight debian/rules files)

Your message dated Wed, 8 Apr 2015 22:45:29 +0200
with message-id <20150408204529.GA9592@upsilon.cc>
and subject line Re: Bug#782109: debsources: please highlight d/rules files
has caused the Debian Bug report #782109,
regarding debsources: please highlight debian/rules files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
782109: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782109
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qa.debian.org
Severity: wishlist
User: qa.debian.org@packages.debian.org
Usertags: debsources

Currently debian/rules are not highlighted.
They are (usually?) makefiles, and as such they deserves some colors too :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540         .''`.
more about me:  http://mapreri.org                                 : :'  :
Launchpad user: https://launchpad.net/~mapreri                     `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia     `-

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On Wed, Apr 08, 2015 at 08:51:09PM +0200, Clément Schreiner wrote:
> Attached are two patches adding highlighting support for
> Makefiles. Files named 'makefile', 'Makefile' or 'GNUmakefile', as
> well as files whose firstline is a make shebang, will be highlighted
> as Makefiles.

Thanks. There was indeed a separate bug in shebang detection, which I
didn't spot at first, which your first commit fixes: nice catch.

I've only slightly reworded your commit messages (mostly to make the
first line fit under 65 chars and similar stylistic things). I've
otherwise applied your patches as is.

> I refrained from adding "Closes: #782109" in the second commit's
> message because 'debian/rules' files without a shebang won't be
> detected as Makefiles:

I think this fix is good enough to close this bug. So I'm doing so and
I've amended the commit message in your second patch to include a Closes
line.  If there are other corner cases to be considered, I'll be happy
to receive separate bug reports about them.

That said, it's not clear to me if we can have debian/rules files which
are both executable makefiles (as required by policy) which do not start
with a /usr/bin/make shebang line. But even if we do, they weren't
highlighted before anyhow.

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader  . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: