[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#761149: debsources: allow redirects to package versions based on suite/codename



On Thu, Mar 12, 2015 at 06:45:37PM -0400, Jason Pleau wrote:
> As discussed on IRC, I rebase my patches for this bug.

Thanks Jason, I've made minor changes to your patches, and pushed them
to the feature/suite-aliasing branch here:

  http://anonscm.debian.org/cgit/qa/debsources.git/log/?h=feature/suite-aliasing

I've also updated the testdata submodule, and pushed it to the
feature/suite-aliasing branch here:

  http://git.upsilon.cc/?p=hacks/debsources-testdata.git;a=shortlog;h=refs/heads/feature/suite-aliasing

I haven't yet merged the branch because while "make test" works well,
"make test-all" (which runs all the testsuite, including updater tests),
fails in 3 tests due to constraint violation errors, e.g.:

excludeFiles (debsources.tests.test_updater.Updater) ... ERROR
garbageCollects (debsources.tests.test_updater.Updater) ... ERROR
producesReferenceSourcesTxt (debsources.tests.test_updater.Updater) ... ERROR
[...]
IntegrityError: (IntegrityError) update or delete on table "suites_info" violates foreign key constraint "suites_aliases_suite_fkey" on table "suites_aliases"
DETAIL:  Key (name)=(jessie) is still referenced from table "suites_aliases".
 'DELETE FROM suites_info WHERE suites_info.name = %(name_1)s' {'name_1': 'jessie'}

Which looks like an actual regression.

Can you look into this?

As fixes, I'd appreciate an *additional* patch wrt the above branches,
which I'll then squash onto your previous commits in that branch.

TIA,
Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader  . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »


Reply to: