Bug#773253: jenkins: please add script to detect dpkg trigger cycles

[Johannes Schauer <j.schauer@email.de>]

Hi,

Quoting Holger Levsen (2015-01-01 12:39:16)
> On Mittwoch, 31. Dezember 2014, Johannes Schauer wrote:
> > I made a number of modifications to jenkins but I fail to run
> > bin/chroot-run.sh locally by itself. So I gave up.
> 
> I guess I should try myself and fix/document this...

that would be great, because then I could test everything locally and only
submit you one commit that makes everything work instead of going back and
forth :)

> > Instead, I created a Jessie chroot, copied Jenkins inside it and ran
> > bin/find_dpkg_trigger_cycles.sh to test.
> 
> ok. (i dont understand what you mean with "copied jenkins inside it"..)

to run bin/find_dpkg_trigger_cycles.sh I needed other jenkins stuff like
bin/common-functions.sh so I just copied the whole jenkins directory (the git
clone) into my chroot before executing the script.

> > The attached patch installs apt-file and dose-extra as the two additional
> > dependencies I had to install for the find_dpkg_trigger_cycles script.
> 
> please re-do the patch without that hunk... it belongs in the part where the 
> jessie chroot is created... (the script should be able to run as user, not as 
> root and also should not need to use "sudo apt-get install"....)

Which is the "part where the jessie chroot is created"? Casually looking
through files in job-cfg which use chroot-run.sh I cannot see where to add
additional packages to the chroot.

> > Since this is running in Jessie, I also removed the python-arpy hack and
> > rely on dpkg instead.
> 
> OTOH, as this is the only change, I guess I can cherry-pick half the patch 
> from here....

Your choice :)

> > Since I could not test this locally, I didn't touch job-cfg/dpkg.yaml, so
> > this still has to be done.
> 
> ok, will do...

Thanks!

> > One remaining problem could be that there might be no /dev/stdin inside the
> > chroot.  If this is the case, then we still have to use python-arpy or
> > somehow mount /dev and /proc (or only /proc and read from /proc/self/fd/0
> > instead). This is until bug #616614 is fixed.
> 
> ack.
> 
> > Thanks!
> 
> likewise and apologies for the slow progress... I expected this script to be
> easier :)

No worries :)

Thanks!

cheers, josch