On Thu, 2014-11-27 at 09:32 +0100, Holger Levsen wrote:
> > Remaining work:
> > * get some review on the approach and action item text
Thanks for the feedback, answers interleaved and proposals at the end.
> "in reproducible build mode" -> what is that? Maybe better just to use "fails
> to build reprodcibly"? Or maybe even "fails to build reproducibly in the
> jenkins.d.n reproducible build test seup"?
In practice that means on jenkins.d.n. "Fails to build reproducibly"
isn't sufficiently clear, it could mean that it does build but not
reproducibly. The other suggestion is a bit verbose for my liking.
> Because: right now, it's a bit stressed to say a package (always)
> "builds reproducibly" - our test setup doesnt eg relies on identical host+user
> names, we don't if/which packages fail, if those are not identical. Maybe
> though these test constraints are sensible, but in any case I think we should
> describe them a bit....
Ack. The code explicitly avoids saying that a package is reproducible,
it only adds something to the tracker when it is definitely not
reproducible somehow.
Would be great to expand the amount of variation that reproducible
builds can cover.
> "no build info is produced" -> "no .buildinfo file is produced". That's less
> descriptive and more factual.
Ack.
Proposals:
I like the phrase "during build reproducibility testing" for the
appropriate amount of clarity and brevity but that seems a bit
repetitive when plugged into the text:
'blacklisted': '<a href="{url}">Blacklisted</a> from build reproducibility testing',
'FTBFS': '<a href="{url}">Fails to build</a> during build reproducibility testing',
'unreproducible': '<a href="{url}">Does not build reproducibly</a> during build reproducibility testing (and no .buildinfo file)',
'unreproducible-with-buildinfo': '<a href="{url}">Does not build reproducibly</a> during build reproducibility testing',
As an alternative we could use the same words but drop redundant ones:
'blacklisted': '<a href="{url}">Blacklisted</a> from build reproducibility testing',
'FTBFS': '<a href="{url}">Fails to build</a> during reproducibility testing',
'unreproducible': '<a href="{url}">Does not build reproducibly</a> during testing and no .buildinfo file is created',
'unreproducible-with-buildinfo': '<a href="{url}">Does not build reproducibly</a> during testing',
Each error has 'reproducib...', 'build' and 'testing' in it. Also, if we
ever switch the implementation away from jenkins then the text doesn't
need to change.
I like the second proposal and have updated my local git repo to it.
--
bye,
pabs
https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part