Bug#771604: tracker.debian.org: short description contains long description

[Christophe Siraut <d@tobald.eu.org>]

Hi Raphaël,

> > Here is a patchset implementing half of this feature, I have not
> > yet figured out how to feed the long description in the tracker.
> 
> Can you be more explicit at where you're stuck?

In core.retrieve_data.UpdateRepositoriesTask._update_packages_file, the
long description is not returned by the following loop (line 375, only
the first line is retuned, i.e. the short description): 

  for stanza in deb822.Packages.iter_paragraphs(packages_file):

Testing the same method locally succeeds in returning the long description:

  for pkg in deb822.Packages.iter_paragraphs(file('/var/lib/dpkg/status')):
      print pkg['Description']

> > -                    <h4>{{ package.short_description }}{% if not package.short_description %}&nbsp;{% endif %}</h4>
> > +                    <h4 title="{{ package.long_description }}">{{ package.short_description }}{% if not package.short_description %}&nbsp;{% endif %}</h4>
> 
> Don't we need something to encode quotes to avoid broken HTML if the long
> description contains double quotes? Or is this already taken care of by
> Django?

You are right, we should use the escape template filter (or possibly
an autoescape tag on the first part of that template).

Thanks,
Christophe