[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#756269: marked as done (Strange "None" word at the bottom of packages page)

Your message dated Fri, 1 Aug 2014 21:44:49 +0200
with message-id <20140801194449.GA14696@x230-buxy.home.ouaza.com>
and subject line Re: Bug#756269: Strange "None" word at the bottom of packages page
has caused the Debian Bug report #756269,
regarding Strange "None" word at the bottom of packages page
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
756269: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756269
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: tracker.debian.org
Severity: minor

As I write in the subject, just look below the News panel, there is write some
meaningless "None".

-- 
regards,
						Mattia Rizzolo

GPG Key: 4096R/B9444540	http://goo.gl/I8TMB
more about me:		http://mapreri.org
Launchpad User:		https://launchpad.net/~mapreri
Ubuntu Wiki page:	https://wiki.ubuntu.com/MattiaRizzolo

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On Tue, 29 Jul 2014, Christophe Siraut wrote:
> The following patch resolves the issue, it is a proof of concept as there is
> probably a more elegant solution (but I am not aware of six habits yet).

Thanks for the patch!

It resolves the issue with Django 1.6 but it actually breaks the code with
Django 1.7 where I get this:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 87, in get_response
    response = middleware_method(request)
  File "/usr/lib/python2.7/dist-packages/django/middleware/common.py", line 72, in process_request
    if (not urlresolvers.is_valid_path(request.path_info, urlconf) and
  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 610, in is_valid_path
    resolve(path, urlconf)
  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 485, in resolve
    return get_resolver(urlconf).resolve(path)
  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 338, in resolve
    for pattern in self.url_patterns:
  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 367, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 361, in urlconf_module
    self._urlconf_module = import_module(self.urlconf_name)
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/rhertzog/deb/core/distro-tracker/distro_tracker/project/urls.py", line 17, in <module>
    from distro_tracker.core.views import PackageSearchView, PackageAutocompleteView
  File "/home/rhertzog/deb/core/distro-tracker/distro_tracker/core/views.py", line 40, in <module>
    from distro_tracker.core.panels import get_panels_for_package
  File "/home/rhertzog/deb/core/distro-tracker/distro_tracker/core/panels.py", line 705, in <module>
    SixListPanelMeta.unregister_plugin()
AttributeError: type object 'temporary_class' has no attribute 'unregister_plugin'

Note that with Django 1.7 and without your patch, I don't see the None...

I thus protected the call with an hasattr() check... it's not very pretty but I have nothing
better to suggest. Also there was no reason to drop the ListPanel.unregister_plugin(). We don't
need that class in the list of registered panels.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Discover the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/

--- End Message ---
Reply to: