[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754438: tracker.debian.org: Misuses <a> tags for priority/section titles



Package: tracker.debian.org
Severity: minor
Tags: patch

Attached patch changes the <a> to <span>, as in the PTS.  This avoids
presenting the descriptions as links when they aren't.
>From 83d6d3cc1e7bcaed46cce9dbc903ab563cd0e02d Mon Sep 17 00:00:00 2001
From: James McCoy <jamessan@debian.org>
Date: Thu, 10 Jul 2014 21:18:08 -0400
Subject: [PATCH] Use <span> tags to set priority/section titles

The <a> tag makes the priority/section descriptions falsely show as
links.  Given the tags are only being used for the title, a <span> tag
is sufficient.

Signed-off-by: James McCoy <jamessan@debian.org>
---
 distro_tracker/core/templates/core/panels/general.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/distro_tracker/core/templates/core/panels/general.html b/distro_tracker/core/templates/core/panels/general.html
index d54bb7d..6366922 100644
--- a/distro_tracker/core/templates/core/panels/general.html
+++ b/distro_tracker/core/templates/core/panels/general.html
@@ -11,7 +11,7 @@
             <a href="{{ url }}">{{ context.name }}</a>
             {% endwith %}
             {% if context.priority %}
-            <span>(<a href="#" title="priority">{{ context.priority }}</a>, <a href="#" title="section">{{ context.section }}</a>)</span>
+            (<span title="priority">{{ context.priority }}</span>, <span title="section">{{ context.section }}</span>)
             {% endif %}
         </div>
         <div class="clear"></div>
-- 
2.0.1


Reply to: