[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#751873: fakeupstream.cgi rejects hg repository URLs containing numbers



Package: qa.debian.org
Severity: normal

While trying to check for the latest version in the OpenJDK 8 upstream
repository, I found that fakeupstream.cgi would not accept hg repository
URLs containing numbers before the project name part (after the last
slash in the URL).

Upstream repository URL: http://hg.openjdk.java.net/jdk8u/jdk8u/

HTTP request:
http://qa.debian.org/cgi-bin/fakeupstream.cgi?upstream=vcs/hg/http://hg.openjdk.java.net/jdk8u/jdk8u

Result: "no data found for given parameter value(s)"

Expected result: "jdk8u20-b18"

I believe the bug can be fixed by changing the definition of
$hg_repository_re from the current

my $hg_repository_re = '[a-z\.\-:/]+';

to

my $hg_repository_re = '[a-z0-9\.\-:/]+';

It may be useful to allow capital letters as well, to provide for
directory names containing them.

-- System Information:
Debian Release: 7.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


Reply to: