[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#737398: marked as done (PTS is confused by trailing commas in Uploaders)

Your message dated Sun, 02 Feb 2014 22:58:20 +0000
with message-id <E1WA5zY-0002Uv-E8@moszumanska.debian.org>
and subject line qa.debian.org bug fixed in revision 3109
has caused the Debian Bug report #737398,
regarding PTS is confused by trailing commas in Uploaders
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
737398: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737398
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qa.debian.org
Severity: minor
Tags: patch

Hi,

It seems that the PTS is confused by fields containing trailing
commas (as inserted by wrap-and-ort -t).

For example on the PTS entry of babelfish, it displays

"maint Debian Python Modules Team (a), Etienne Millon (u), Oxan van
Leeuwen (u), (u)"

http://packages.qa.debian.org/b/babelfish.html

The attached patch seems to fix the issue by filtering empty strings,
but I'm not too familiar with the PTS source code so testing is
advised.

Thanks!

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.12-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

-- 
Etienne Millon

Index: www/bin/sources_to_xml.py
===================================================================
--- www/bin/sources_to_xml.py	(revision 3108)
+++ www/bin/sources_to_xml.py	(working copy)
@@ -29,7 +29,8 @@
 # Just as address_from_string, it tries to be forgiving about unquoted
 # commas in addresses. [PvR]
 def addresses_from_string(content):
-    return map(address_from_string, re.split('(?<=>)\s*,\s*', content))
+    matches = re.split('(?<=>)\s*,\s*', content)
+    return [address_from_string(m) for m in matches if m]
 
 def add_maintainer_info(child, name, mail, doc):
     text = doc.createTextNode(unicode(name, 'UTF-8', 'replace')) # Take care of non-ascii

--- End Message ---
--- Begin Message --- 
Version: 3109

This bug was closed by Paul Wise (pabs) in SVN revision 3109.
Note that it might take some time until the qa.debian.org code has
been updated and cronjobs have picked up changed data.

Commit message:

Ignore trailing commas in Uploaders

Patch-by: Etienne Millon <me@emillon.org>
Closes: #737398

--- End Message ---
Reply to: