Bug#715216: qa.debian.org: collab-qa/upload-history: Software trusts "Date" headers which are sometimes set wrong
On 11/07/13 at 18:53 -0400, Asheesh Laroia wrote:
> On Wed, 10 Jul 2013, Lucas Nussbaum wrote:
>
> >Hi Asheesh,
> >
> >Sorry for the delayed reply. Thanks a lot for your work on this.
> >
> >I've added you to collab-qa, so you should be able to push your
> >code yourself.
>
> Yay! Thanks!
>
> >Now, one comment on your changes: it would be better if everything
> >you do is versioned in git (for example,
> >/srv/udd.debian.org/email-archives/README isn't, same for scripts
> >in /srv/udd.debian.org/upload-history/). You could put them under
> >/srv/udd.debian.org/udd/scripts/upload-history/, for example.
>
> I totally agree. Thanks for this note.
>
> Along those lines:
>
> Is it reasonable for the email-archives/ directory to live in
> git://git.debian.org/collab-qa/udd.git even though it won't have any
> data (just the README indicating why it has no data in VCS) except
> on the deployment? I figure that is fine, but thought I'd ask.
Yes, I agree it's fine
> The upload-history scripts are actually a checkout of an svn repo.
> What's the best way to put that into udd git, if at all? In
> particular:
>
> "svn+ssh://lucas@svn.debian.org/svn/collab-qa/upload-history"
>
> I could just move them into
> /srv/udd.debian.org/udd/scripts/upload-history/ but that wouldn't
> really put them in git; it would just mean an svn checkout lives in
> a git directory, which is a bit odd.
>
> Should we (I) add that code to git entirely, and ditch the svn repo?
> I can do that and leave a note in the svn repo explaining where the
> code has gone, if that is best.
Yes, that would be great. UDD originally lived in the collab-qa svn
repo, and the upload-history parser scripts did not follow the move to
git at the time it was done. Now that the scripts live on the same
machine as UDD itself, it makes even more sense to have them in the same
git repo, and just ditch the svn copy.
Lucas
Reply to: