[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#684217: marked as done (qa.d.o/developer.php: Optionally show package description in its own column)



Your message dated Sun, 26 May 2013 14:27:53 +0800
with message-id <CAKTje6FruFfBK5tV08U0F3qKBAwsWC+TvEmU1+OG0yvqZv9gyg@mail.gmail.com>
and subject line Re: Bug#684217: qa.d.o/developer.php: Optionally show package description in its own column
has caused the Debian Bug report #684217,
regarding qa.d.o/developer.php: Optionally show package description in its own column
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
684217: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684217
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: qa.debian.org
Severity: wishlist
Tags: patch

The attached patch makes it possible for one to show package
descriptions in a separate column in the packages overview.
It defaults to off for backwards compatibility.

Please review and/or apply.

I posted this http://lists.debian.org/debian-qa/2012/06/msg00123.html in
June 2012, but got zero response back. Filing this here so it does not
get lost.


-- System Information:
Debian Release: squeeze/sid
  APT prefers lucid-updates
  APT policy: (600, 'lucid-updates'), (600, 'lucid-security'), (600, 'lucid'), (400, 'lucid-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-15-generic (SMP w/4 CPU cores)
Locale: LANG=pl_PL.utf8, LC_CTYPE=pl_PL.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

-- 
Marcin Owsiany <porridge@debian.org>             http://marcin.owsiany.pl/
GnuPG: 2048R/02F946FC  35E9 1344 9F77 5F43 13DD  6423 DBF4 80C6 02F9 46FC
Index: common-html.php
===================================================================
--- common-html.php	(wersja 2769)
+++ common-html.php	(kopia robocza)
@@ -429,6 +429,9 @@
         $data .= html_input_radio($value,1,$arg_cookie[$value] == 1,"Date (1)\n") . html_br();
         $data .= html_input_radio($value,2,$arg_cookie[$value] == 2,"N./D. (2)\n") . html_br();
         $data .= html_input_radio($value,3,$arg_cookie[$value] == 3,"Section (3)\n") . html_br();
+    } elseif ($value == 'description') {
+        $data = html_input_radio($value,1,true,"In separate column\n") . html_br();
+        $data .= html_input_radio($value,0,false,"As source mouseover only") . html_br();
     }
     $data = html_color($data,"green");
     return $data;
Index: developer.wml
===================================================================
--- developer.wml	(wersja 2769)
+++ developer.wml	(kopia robocza)
@@ -79,7 +79,8 @@
 }
 
 /* Set missing parts of the cookies */
-$arg_cookie_def = array ( bugs => 3,
+$arg_cookie_def = array ( description => 0,
+                          bugs => 3,
                           version => 1,
                           ubuntu => 1,
                           excuses => 1,
@@ -219,7 +220,8 @@
     $display_data .= "You can override the settings by providing an extra arg to the URL (e.g. &amp;buildd=1 if you want to display the buildd column). These args will not change the custom settings you defined before (the cookie is not modified)." . html_br();
     $display_data .= "The 'Name' ordering sorts by package name, 'Date' sorts by upload date (descending), 'N./D.' sorts by name for main/contrib/non-free packages and by date for other sections, 'Section' sorts by sections first and by name secondly." . html_br();
     $display_data = html_small($display_data);
-    $display_table_th = html_th("Bugs","&amp;bugs=");
+    $display_table_th = html_th("Description","&amp;description=");
+    $display_table_th .= html_th("Bugs","&amp;bugs=");
     $display_table_th .= html_th("Version","&amp;version=");
     $display_table_th .= html_th("Ubuntu","&amp;ubuntu=");
     $display_table_th .= html_th("Excuses","&amp;excuses=");
@@ -233,7 +235,8 @@
     $display_table_th .= html_th("Ordering","&amp;ordering=");
     $display_table_th .= html_th("Uploads","&amp;uploads=");
 
-    $display_table_tds = html_td(checkbox('bugs'));
+    $display_table_tds = html_td(checkbox('description'));
+    $display_table_tds .= html_td(checkbox('bugs'));
     $display_table_tds .= html_td(checkbox('version'));
     $display_table_tds .= html_td(checkbox('ubuntu'));
     $display_table_tds .= html_td(checkbox('excuses'));
@@ -264,7 +267,7 @@
     print html_br() . html_collexp($counter_span, $title, "general", true, $display_data);
 
     $counter_span += 1;
-    $help_data = "The description of the package is available as mouseover title from the package name. An asterisk (*) indicates the presence of co-maintainers (Uploaders: control field)" . html_br();
+    $help_data = "An asterisk (*) indicates the presence of co-maintainers (Uploaders: control field)" . html_br();
     $help_data .= html_color("Blue", "blue") .
 	" packages are co-maintained by this developer" . html_br();
     $help_data .= "The 'Bugs' columns display the real number of bugs. If there are merged bugs, the total is in parentheses" . html_br();
@@ -765,6 +768,10 @@
         html_a("Pool", $pool);
     $line = html_td($line_data);
 
+    if(isdisplayed('description'))
+    {
+        $line .= html_td($description);
+    }
 
     /* if bugs >= 1  always print the summary */
     if(isdisplayed('bugs'))
@@ -1082,6 +1089,7 @@
 
     /* contruct the table header */
     $ths = html_th("Source" . html_blank(). "Name", "", 2);
+    if(isdisplayed('description')) $ths .= html_th("Description", "", 2);
     if(isdisplayed('bugs') == 1)
     {
         $ths .= html_th("Bugs", "", 1, 5);

--- End Message ---
--- Begin Message ---
On Wed, Aug 8, 2012 at 5:46 AM, Marcin Owsiany wrote:

> The attached patch makes it possible for one to show package
> descriptions in a separate column in the packages overview.
> It defaults to off for backwards compatibility.

Patch adjusted slightly and committed, thanks and sorry for the delay.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise

--- End Message ---

Reply to: