Bug#695772: bugs.cgi: allow filtering based on unblock/approve hints

[Niels Thykier <niels@thykier.net>]

On 2012-12-12 16:54, Ivo De Decker wrote:
> Package: qa.debian.org
> Severity: normal
> User: qa.debian.org@packages.debian.org
> Usertags: udd
> Tags: patch
> 
> Hi,
> 

Hi,

> Please allow the possibility to filter bugs based on unblock or approve hints
> by the release team. The attached patch frovides these filters.
> 

Good idea. :)

> Cheers,
> 
> Ivo
> 
> 
> 
> udd_filter_unblock_approve.diff
> 
> 
> commit 320c82d19c01c02b4d7ce9d5a195d9be4490cf46
> Author: Ivo De Decker <ivo.dedecker@ugent.be>
> Date:   Wed Dec 12 16:42:21 2012 +0100
> 
>     allow filtering based on unblock and approve hints
> 
> diff --git a/web/bugs.cgi b/web/bugs.cgi
> index 211f78d..3cd526b 100755
> --- a/web/bugs.cgi
> +++ b/web/bugs.cgi
> @@ -47,6 +47,8 @@ FILTERS = [
>   ['rtwheezy-will-remove', 'RT tag for wheezy: will-remove', "id in (select id from bugs_usertags where email='release.debian.org@packages.debian.org' and tag='wheezy-will-remove')"],
>   ['rtwheezy-can-defer', 'RT tag for wheezy: can-defer', "id in (select id from bugs_usertags where email='release.debian.org@packages.debian.org' and tag='wheezy-can-defer')"],
>   ['rtwheezy-is-blocker', 'RT tag for wheezy: is-blocker', "id in (select id from bugs_usertags where email='release.debian.org@packages.debian.org' and tag='wheezy-is-blocker')"],
> + ['unblock-hint', 'RT unblock hint', "source in (select source from hints where type = 'unblock' )"],
> + ['approve-hint', 'RT approve hint', "source in (select source from hints where type = 'approve' )"],

I'd probably merge them into one entry as "approve" is (for most
practical purposes) "unblock for tpu" uploads[1].

>  ]
>  
>  TYPES = [
> 

~Niels

[1] I am sure that some RT members can give you the full distinction
between the two, tbh, I doubt anyone using the UDD bugs.cgi tool is
going to care.