[PATCH][qa.d.o/developer.php] Optionally show package description in its own column
Hi,
The attached patch makes it possible for one to show package
descriptions in a separate column in the packages overview.
It defaults to off for backwards compatibility.
Please review and/or apply.
--
Marcin Owsiany <porridge@debian.org> http://marcin.owsiany.pl/
GnuPG: 2048R/02F946FC 35E9 1344 9F77 5F43 13DD 6423 DBF4 80C6 02F9 46FC
Index: common-html.php
===================================================================
--- common-html.php (wersja 2769)
+++ common-html.php (kopia robocza)
@@ -429,6 +429,9 @@
$data .= html_input_radio($value,1,$arg_cookie[$value] == 1,"Date (1)\n") . html_br();
$data .= html_input_radio($value,2,$arg_cookie[$value] == 2,"N./D. (2)\n") . html_br();
$data .= html_input_radio($value,3,$arg_cookie[$value] == 3,"Section (3)\n") . html_br();
+ } elseif ($value == 'description') {
+ $data = html_input_radio($value,1,true,"In separate column\n") . html_br();
+ $data .= html_input_radio($value,0,false,"As source mouseover only") . html_br();
}
$data = html_color($data,"green");
return $data;
Index: developer.wml
===================================================================
--- developer.wml (wersja 2769)
+++ developer.wml (kopia robocza)
@@ -79,7 +79,8 @@
}
/* Set missing parts of the cookies */
-$arg_cookie_def = array ( bugs => 3,
+$arg_cookie_def = array ( description => 0,
+ bugs => 3,
version => 1,
ubuntu => 1,
excuses => 1,
@@ -219,7 +220,8 @@
$display_data .= "You can override the settings by providing an extra arg to the URL (e.g. &buildd=1 if you want to display the buildd column). These args will not change the custom settings you defined before (the cookie is not modified)." . html_br();
$display_data .= "The 'Name' ordering sorts by package name, 'Date' sorts by upload date (descending), 'N./D.' sorts by name for main/contrib/non-free packages and by date for other sections, 'Section' sorts by sections first and by name secondly." . html_br();
$display_data = html_small($display_data);
- $display_table_th = html_th("Bugs","&bugs=");
+ $display_table_th = html_th("Description","&description=");
+ $display_table_th .= html_th("Bugs","&bugs=");
$display_table_th .= html_th("Version","&version=");
$display_table_th .= html_th("Ubuntu","&ubuntu=");
$display_table_th .= html_th("Excuses","&excuses=");
@@ -233,7 +235,8 @@
$display_table_th .= html_th("Ordering","&ordering=");
$display_table_th .= html_th("Uploads","&uploads=");
- $display_table_tds = html_td(checkbox('bugs'));
+ $display_table_tds = html_td(checkbox('description'));
+ $display_table_tds .= html_td(checkbox('bugs'));
$display_table_tds .= html_td(checkbox('version'));
$display_table_tds .= html_td(checkbox('ubuntu'));
$display_table_tds .= html_td(checkbox('excuses'));
@@ -264,7 +267,7 @@
print html_br() . html_collexp($counter_span, $title, "general", true, $display_data);
$counter_span += 1;
- $help_data = "The description of the package is available as mouseover title from the package name. An asterisk (*) indicates the presence of co-maintainers (Uploaders: control field)" . html_br();
+ $help_data = "An asterisk (*) indicates the presence of co-maintainers (Uploaders: control field)" . html_br();
$help_data .= html_color("Blue", "blue") .
" packages are co-maintained by this developer" . html_br();
$help_data .= "The 'Bugs' columns display the real number of bugs. If there are merged bugs, the total is in parentheses" . html_br();
@@ -765,6 +768,10 @@
html_a("Pool", $pool);
$line = html_td($line_data);
+ if(isdisplayed('description'))
+ {
+ $line .= html_td($description);
+ }
/* if bugs >= 1 always print the summary */
if(isdisplayed('bugs'))
@@ -1082,6 +1089,7 @@
/* contruct the table header */
$ths = html_th("Source" . html_blank(). "Name", "", 2);
+ if(isdisplayed('description')) $ths .= html_th("Description", "", 2);
if(isdisplayed('bugs') == 1)
{
$ths .= html_th("Bugs", "", 1, 5);
Reply to: