Bug#668320: DDPO: when popcon is not (yet) available, watch versions are shifted to left

[Stephen Kitt <steve@sk2.org>]

Hi Bart,

On Thu, May 17, 2012 at 10:19:40AM +0000, Bart Martens wrote:
> On Thu, May 17, 2012 at 12:09:22PM +0200, Stephen Kitt wrote:
> > I don't know where the DDPO source lives, otherwise I'd gladly provide
> > a patch!
> 
> qa.debian.org = 206.12.19.122 = quantz.debian.org
> quantz:/srv/qa.debian.org/README :
>   svn+ssh://svn.debian.org/svn/qa/trunk
>   http://svn.debian.org/wsvn/qa/trunk/

Thanks!

As promised I'm attaching a patch. The bug comes from the use of
empty() on the 'sorttable_customkey' argument to html_td(); empty()
considers the value 0 to be empty, so a package with a popcon of 0
ends up with an unprocessed $sorttable_customkey with a value of 0
which just gets appended to "<td".

Regards,

Stephen

Index: wml/common-html.php
===================================================================
--- wml/common-html.php	(revision 2748)
+++ wml/common-html.php	(working copy)
@@ -183,7 +183,10 @@
     if (!empty($width)) $width = " width=\"".$width."\"";
     if (!empty($rowspan)) $rowspan = " rowspan=\"".$rowspan."\"";
     if (!empty($colspan)) $colspan = " colspan=\"".$colspan."\"";
-    if (!empty($sorttable_customkey)) $sorttable_customkey = " sorttable_customkey=\"".$sorttable_customkey."\"";
+    if (!empty($sorttable_customkey) || is_numeric($sorttable_customkey))
+    {
+        $sorttable_customkey = " sorttable_customkey=\"".$sorttable_customkey."\"";
+    }
     return "<td".$width.$rowspan.$colspan.$sorttable_customkey.">".$data."</td>\n";
 }

Attachment: signature.asc
Description: Digital signature