[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#638706: marked as done (qa.debian.org: Does not like \1 backreferences in watch file (breaks download links))

Your message dated Tue, 30 Aug 2011 15:52:20 +0200
with message-id <20110830135220.GK10237@login.drsnuggles.stderr.nl>
and subject line Re: Bug#638706: qa.debian.org: Does not like \1 backreferences in watch file (breaks download links)
has caused the Debian Bug report #638706,
regarding qa.debian.org: Does not like \1 backreferences in watch file (breaks download links)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
638706: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=638706
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qa.debian.org
Severity: normal

Hi folks,

I noticed that the "download" links on the developer's packages
overview, which allow downloading new upstream version if uscan detects
new versions, are not working right now. At least on this page:

	http://qa.debian.org/developer.php?login=matthijs%40stdin.nl&comaint=yes

The links point to, for example,

	http://qa.debian.org/1/openttd-1-source.tar.gz

which returns an Apache 404 from qa.debian.org.

I'm not sure if the url is wrong, or if this url should redirect but it
doesn't. Not sure where the "1" in the url comes from either, since the
link is supposed to download the source for openttd 1.1.2.

I also noticed that the download links are working for other packages,
so it must be something related to the rewriting happening in my watch
file. For the OpenTTD package mentioned above, the watch file contains:

	options=downloadurlmangle=s/(.*)\/index.html$/\1\/openttd-\1-source.tar.gz/ \
	http://master.binaries.openttd.org/releases/ \
	(\d+(?:\.\d+)*)/index.html

Looking at this file, it seems the "1"'s in the download url come from
the \1 backreferences in the downloadurlmangle option.

Thinking about this a bit further, I suspect that this is caused by
using \1 as a backreference instead of $1 (which is perfectly valid in
Perl and is understood by uscan, but apparently not by the qa.debian.org
scripts).

I'm not sure if this is a bug in my watchfile, or that qa.debian.org
should support this, though. This might be a trival change in the
qa.debian.org scripts, but I'll probably change my backreferences to use
$ instead of \ anyway (seems Perl recommends using $1 instead of \1 as
well).

Also, perhaps my analysis is wrong somewhere, haven't actually confirmed
that the backreferences are the cause (though it seems likely).

Gr.

Matthijs

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.39-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- End Message ---
--- Begin Message --- 
Hi Giovanni,

> Your interpretation appear to be correct. Anyway, I don't think uscan
> actually recognizes the \1 notation: if I use the watch file you posted
> in the bug report, uscan says:
> 
> > $ uscan --report --dehs
> > <dehs>
> > <package>openttd</package>
> > <debian-uversion>1.1.2</debian-uversion>
> > <debian-mangled-uversion>1.1.2</debian-mangled-uversion>
> > <upstream-version>1.1.2</upstream-version>
> > <upstream-url>1/openttd-1-source.tar.gz</upstream-url>
> > <status>up to date</status>
> > </dehs>
> 
> which is exactly your problem. Also, the scripts behind the QA pages
> actually call uscan to do the parsing.
Right, I see what happens there. I had of course tested my watch file,
but just running uscan --report-status reports that the current version
is up to date. However, it does not actually try to download the
(wrongly mangled) url, it only sees if there is an url that could be
succesfully mangled.

So, your right: My watch files are really wrong, I just hadn't noticed
this before.

> BTW, the debian/watch that is in unstable now uses the $1 notation, so
> fixes this problem. Anyway, there is another subtle bug:
> 
> > $ uscan --report --dehs
> > <dehs>
> > <package>openttd</package>
> > <debian-uversion>1.1.2</debian-uversion>
> > <debian-mangled-uversion>1.1.2</debian-mangled-uversion>
> > <upstream-version>1.1.2</upstream-version>
> > <upstream-url>http://master.binaries.openttd.org/releases/1.1.2/openttd-http://master.binaries.openttd.org/releases/1.1.2-source.tar.gz</upstream-url>
> > <status>up to date</status>
> > </dehs>
> 
> As you may see, the download URL is incorrect, because the mangling
> wrongly matches on the whole URL, not only the version number. The
> problem can be fixed with somewhat like this (you can use | instead of /
> for separating substitution fields, so you have less escaping work to do):
> 
> options=downloadurlmangle=s|([^/]*)/index.html$|$1/openttd-$1-source.tar.gz|
> \
> http://master.binaries.openttd.org/releases/ \
> (\d+(?:\.\d+)*)/index.html
Ah, right. Didn't notice that for the same reasons.

> > I'm not sure if this is a bug in my watchfile, or that qa.debian.org
> > should support this, though. This might be a trival change in the
> > qa.debian.org scripts, but I'll probably change my backreferences to use
> > $ instead of \ anyway (seems Perl recommends using $1 instead of \1 as
> > well).
> 
> I don't think this is a bug in QA scripts, because it actually depends
> on uscan. You should probably file a whishlist bug against uscan asking
> for the \1 notation to be supported or, at least, to have some
> documentation somewhere about this decision.
Since perl says \1 is deprecated, I think documenting the lack of
support would be sufficient. I'll open a new bug with a patch in a
minute.

> Please, let me know your comments if you have any. Otherwise, I'll close
> the report.
I've gone ahead and closed it already. Thanks for your thoughts and
explainations.

Gr.

Matthijs

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: