Bug#373218: qa.debian.org: Patch
Raphael Geissert <atomo64@gmail.com> writes:
> Package: qa.debian.org
> Tags: patch
> Followup-For: Bug #373218
> I just wrote a patch for this problem. The best solution I found it to
> drop the current naming convention of the lintian reports and use the
> maintainer login (the same way most of the other pages do).
I'm not wholly adverse to this approach, but there's a lot of stuff that
links to lintian maintainer pages and I'm not particularly thrilled with
the idea of changing those URLs. However, I'm more concerned about the
safety of this change:
> --- orig/html_reports 2007-06-28 12:33:42.000000000 -0500
> +++ new/html_reports 2007-06-28 12:14:58.000000000 -0500
> @@ -480,11 +480,7 @@
> my $file = $maint;
> if ($file) {
> - $file =~ s/^(.+)\<.*$/$1/;
> - $file =~ tr/A-Za-z0-9_.,/_/c;
> - $file =~ s/^_+//g;
> - $file =~ s/_+$//g;
> -
> + $file =~ s/^[^<]+\<([^>]+)$/$1/;
> $file = "m$file.html";
> } else {
> $file = "munsorted.html";
You can't drop that tr///. It's what takes care of all the special
characters that otherwise need escaping.
Why not just fix the qa code to match what lintian does? It's pretty
clearly currently different, which is probably the root of the problem.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: