Re: Bug#347624: DEHS: Error with a valid watch file
On Thu, Jan 19, 2006 at 03:23:34AM +0100, Bluefuture wrote:
> The problem of this bugs is in ext_watch() (a dehs function) that seem
> doesn't catch watch file in some cases. This function try extract the
> watch file from the diff.gz of the package name submitted.
> The function is quite simple and seems that doesn't work for package
> that already have a watch file in the original upstream tar.gz.
Is that the only case that it fails, for the submitted bug, and this
months threads on -qa and -mentors?
> I'm quite busy in this days if anybody could send a little patch i could
> apply to svn and the catch it on the running dehs alioth version.
> Here is the little function:
>
> for ($i = 1; $i <= $watch_lenght[1]; $i++)
s/lenght/length/, but I am assuming that it is consistently
misspelled :)
> {
> $line=gzgets ($zp,4096);
> $watch .=substr($line,1);
> }
> break;
> }
> }
> if ($watch!=null) return $watch;
> else return NULL;
Why not just "return $watch"?
Anyway, why not just tar; gzcat|patch, or use 'star' or whatever to
extract just extract suff matching "m/\/debian\/watch$" and then
zcat /tmp/*.diff.gz |sed -ne '/^--- .*\/debian\/watch$/,/^--- / { :l; N; /\n--- /{s/\n--- .*//p; Q;}; b l; };'
--
Clear skies,
Justin
Reply to: