[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#370175: qa.debian.org: Search function/redirection may cause unexpected results



On Sat, Jun 03, 2006 at 10:24:41PM +0200, Moritz Naumann wrote:
> Package: qa.debian.org
> Severity: minor
> 
> The search / redirection 
> http://packages.qa.debian.org/common/index.html
> points to may provide unexpected results in some cases.
> 
> For example, put a single dot into the search box and submit the search.
> http://packages.qa.debian.org/common/index.html?src=.
> 
> It looks like the rewrite rule is just a little bit too simple.

indeed, the affected rewriterule is:

RewriteCond %{QUERY_STRING} ^src=(.)(.*)$
RewriteRule ^/common/index.html$ /%1/%1%2.html? [L,R,NE]

the untested fix might be:

RewriteCond %{QUERY_STRING} ^src=(.)(.+)$
RewriteRule ^/common/index.html$ /%1/%1%2.html? [L,R,NE]

(i.e. require at least two chars)

BTW, which is the minimum length for a source package name? three/four chars?

filippo
--
Filippo Giunchedi - http://esaurito.net
PGP key: 0x6B79D401
random quote follows:

I never forget a face, but in your case I'll be glad to make an exception.
-- Groucho Marx

Attachment: signature.asc
Description: Digital signature


Reply to: