Bug#340418: marked as done (wml/developer.wml: generates wrong markup via html_table function)
Your message dated Thu, 24 Nov 2005 17:28:30 +0100
with message-id <20051124162830.GF3933@df7cb.de>
and subject line Bug#340418: wml/developer.wml: generates wrong markup via html_table function
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Nov 2005 11:45:31 +0000
>From florian@uni-hd.de Wed Nov 23 03:45:31 2005
Return-path: <florian@uni-hd.de>
Received: from relay2.uni-heidelberg.de ([129.206.210.211])
by spohr.debian.org with esmtp (Exim 4.50)
id 1Eet46-0007am-UX
for submit@bugs.debian.org; Wed, 23 Nov 2005 03:45:31 -0800
Received: from ix.urz.uni-heidelberg.de (popix.urz.uni-heidelberg.de [129.206.119.235])
by relay2.uni-heidelberg.de (8.12.10/8.12.10) with ESMTP id jANBjovj003398
for <submit@bugs.debian.org>; Wed, 23 Nov 2005 12:45:50 +0100 (MET)
Received: from extmail.urz.uni-heidelberg.de (extmail.urz.uni-heidelberg.de [129.206.100.140])
by ix.urz.uni-heidelberg.de (8.8.8/8.8.8) with ESMTP id MAA41467986
for <submit@bugs.debian.org>; Wed, 23 Nov 2005 12:45:28 +0100
Received: from live (p54A70EB7.dip0.t-ipconnect.de [84.167.14.183])
(authenticated bits=0)
by extmail.urz.uni-heidelberg.de (8.13.4/8.13.1) with ESMTP id jANBk2WS003946
(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO)
for <submit@bugs.debian.org>; Wed, 23 Nov 2005 12:46:04 +0100
Received: from fernst by live with local (Exim 4.54)
id 1Eet42-0003Zz-7s
for submit@bugs.debian.org; Wed, 23 Nov 2005 12:45:26 +0100
Date: Wed, 23 Nov 2005 12:45:26 +0100
From: Florian Ernst <florian@uni-hd.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: wml/developer.wml: generates wrong markup via html_table function
Message-ID: <[🔎] 20051123114526.GA13730@ernst.uni-hd.de>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="qlTNgmc+xy1dBmNv"
Content-Disposition: inline
X-Reportbug-Version: 3.17
User-Agent: Mutt/1.5.9i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
--qlTNgmc+xy1dBmNv
Content-Type: multipart/mixed; boundary="0F1p//8PRICkK4MW"
Content-Disposition: inline
--0F1p//8PRICkK4MW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: qa.debian.org
Severity: minor
Tags: patch
Hello there,
the code currently given generates markup such as
| <table width="%" ...
While this is only a bad parameter the very same bug screws up the
page where all developers are displayed as
| <table80 border="1" ...
thus effectively killing the table.
Once this is found and backtracked the attached patch seems obvious.
HTH,
Flo
--0F1p//8PRICkK4MW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="developer.wml.diff"
--- developer.wml.orig 2005-11-23 12:36:10.000000000 +0100
+++ developer.wml 2005-11-23 12:37:22.000000000 +0100
@@ -360,7 +360,7 @@
*/
function html_table($header, $data, $width, $class)
{
- if($width == "") $width = " width=\"${width}%\"";
+ if($width != "") $width = " width=\"${width}%\"";
if($class) $class = " class=\"$class\"";
$table = "<table$width$class border=\"1\" cellpadding=\"3\" cellspacing=\"1\" summary=\"\">";
$table .= $header ;
--0F1p//8PRICkK4MW--
--qlTNgmc+xy1dBmNv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDhFZVs3U+TVFLPnwRAi36AJ4h9kZks2ZK865F4/1R1Tzb8uPehACfYEbH
1h+UN/gvulVTB0jPCoBiyC8=
=Fufx
-----END PGP SIGNATURE-----
--qlTNgmc+xy1dBmNv--
---------------------------------------
Received: (at 340418-done) by bugs.debian.org; 24 Nov 2005 16:28:36 +0000
>From cb@df7cb.de Thu Nov 24 08:28:36 2005
Return-path: <cb@df7cb.de>
Received: from meitner.df7cb.de ([217.160.132.97] ident=postfix)
by spohr.debian.org with esmtp (Exim 4.50)
id 1EfJxc-0006yW-KK
for 340418-done@bugs.debian.org; Thu, 24 Nov 2005 08:28:36 -0800
Received: from volta.df7cb.de (dslb-084-058-201-048.pools.arcor-ip.net [84.58.201.48])
by meitner.df7cb.de (Postfix) with ESMTP id 3244820C02F
for <340418-done@bugs.debian.org>; Thu, 24 Nov 2005 17:28:33 +0100 (CET)
Received: by volta.df7cb.de (Postfix, from userid 1000)
id 150D743223; Thu, 24 Nov 2005 17:28:30 +0100 (CET)
Date: Thu, 24 Nov 2005 17:28:30 +0100
From: Christoph Berg <myon@debian.org>
To: 340418-done@bugs.debian.org
Subject: Re: Bug#340418: wml/developer.wml: generates wrong markup via html_table function
Message-ID: <20051124162830.GF3933@df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
340418-done@bugs.debian.org
References: <[🔎] 20051123114526.GA13730@ernst.uni-hd.de>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="r7U+bLA8boMOj+mD"
Content-Disposition: inline
In-Reply-To: <[🔎] 20051123114526.GA13730@ernst.uni-hd.de>
X-Debbugs-No-Ack: please
X-Face: (nN@x(D\O)J!Qu\q4fh8W^7WGqxpwTk&Xy0*ya<z@L`gg26[[T%n/TA:l\Pde>wYj,M;75" N13_k}S.rS#lmX[G]QOuw[H"4#z$tSn$SkV<IurN'6;gkRFZw@/XLtl7":0v&kN3*-iM~q*;.*CfH@ qM>5ucV193Tz3IWj<]8at(6"K.ht//s"Ds,xMV9A\_bN/)w@^PmEM>-dF34Kw?,<G0ya
User-Agent: Mutt/1.5.11
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-7.6 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
HTML_40_50,X_DEBBUGS_NO_ACK autolearn=no
version=2.60-bugs.debian.org_2005_01_02
--r7U+bLA8boMOj+mD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Re: Florian Ernst in <[🔎] 20051123114526.GA13730@ernst.uni-hd.de>
> the code currently given generates markup such as
> | <table width=3D"%" ...
Hi,
thanks for noticing, fixed.
Christoph
--=20
cb@df7cb.de | http://www.df7cb.de/
--r7U+bLA8boMOj+mD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDheotxa93SlhRC1oRAtUNAJ9dhmrGY4lYum/E9cetGAkKsD1t3ACgmGUB
fV7jAVq1RYVmTnSGEkIpgQE=
=ce6T
-----END PGP SIGNATURE-----
--r7U+bLA8boMOj+mD--
Reply to: