Bug#164410: marked as done (qa.debian.org: developer.php opens excuses links in a new window/popup)
Your message dated Tue, 25 Mar 2003 12:19:06 +0100
with message-id <20030325111906.GG29829@tass.genibel.org>
and subject line Bug#164410: qa.debian.org: developer.php opens excuses links in a new window/popup
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at maintonly) by bugs.debian.org; 12 Oct 2002 02:53:04 +0000
>From jaq@spacepants.org Fri Oct 11 21:53:04 2002
Return-path: <jaq@spacepants.org>
Received: from new-smtp2.ihug.com.au [203.109.250.28] (mail)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 180COl-0007hB-00; Fri, 11 Oct 2002 21:53:04 -0500
Received: from p117-apx1.syd.ihug.com.au (willow.spacepants.org) [203.173.140.117]
by new-smtp2.ihug.com.au with esmtp (Exim 3.22 #1 (Debian))
id 180COj-0001er-00; Sat, 12 Oct 2002 12:53:02 +1000
Received: by willow.spacepants.org (Postfix, from userid 1000)
id 411972406E1C; Sat, 12 Oct 2002 12:48:00 +1000 (EST)
Date: Sat, 12 Oct 2002 12:48:00 +1000
From: Jamie Wilkinson <jaq@debian.org>
To: Debian Bug Tracking System <maintonly@bugs.debian.org>
Subject: qa.debian.org: developer.php opens excuses links in a new window/popup
Message-ID: <20021012024800.GA30724@spacepants.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-Reportbug-Version: 2.2
X-Message-Flag: Magic 8-Ball says Outlook Not Good.
X-Mailer: beefmail v0.0
Reply-By: Thu, 12 Sep 2002 12:43:11 +1000
X-No-CC: Please respect the setting of my Mail-Followup-To header
Delivered-To: maintonly@bugs.debian.org
Package: qa.debian.org
Version: unavailable; reported 2002-10-12
Severity: wishlist
Tags: patch
When looking at the excuses for a package from developer.php, the "out of
date" links cause the browser to open the link in a new window, thanks to
the target="_blank" attribute in the <a href>. I traced it to the actual
update_excuses.html, where it is useful to open a new window with the buildd
log in it because the page is so huge, but with developer.php, the excuses
page are per package and so navigating the pages within one window is
desirable.
I've attached a patch that simply cuts the target attribute out of the "out
of date" lines when extract.pl builds the excuses cache.
My perl's a little rusty, so there's probably some glaring bug in the patch,
but hopefully it's clear enough.
willow% cvs diff
Index: ddpo/DDPO.pm
===================================================================
RCS file: /cvs/qa/data/ddpo/DDPO.pm,v
retrieving revision 1.4
diff -u -r1.4 DDPO.pm
--- ddpo/DDPO.pm 6 Sep 2002 11:33:32 -0000 1.4
+++ ddpo/DDPO.pm 12 Oct 2002 02:51:25 -0000
@@ -160,6 +160,10 @@
$package =~ s/\\//g;
# print "$package $WWW $first_char $link\n";
print PACK_EXC "<li>Depends: $package <a href=\"${WWW}/developer.php?excuse=${link}\">$link<\/a>\n";
+ }elsif((m/^<li>out of date on/) && ($valid == 1)){
+ # make out-of-date links appear in the same window
+ s/ target="_blank"//g;
+ print PACK_EXC;
}elsif(($open == 1) && ($valid == 1)){
print PACK_EXC;
}
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux willow 2.4.18 #1 Wed Sep 11 14:08:50 EST 2002 i686
Locale: LANG=en_AU, LC_CTYPE=en_AU
--
jaq@debian.org http://people.debian.org/~jaq
---------------------------------------
Received: (at 164410-done) by bugs.debian.org; 25 Mar 2003 11:19:46 +0000
>From igor@genibel.org Tue Mar 25 05:19:37 2003
Return-path: <igor@genibel.org>
Received: from atoulouse-201-2-1-120.abo.wanadoo.fr (tass.genibel.org) [193.251.11.120]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18xmSu-0004Ha-00; Tue, 25 Mar 2003 05:19:36 -0600
Received: from igor by tass.genibel.org with local (Exim 3.35 #1 (Debian))
id 18xmSQ-0005Cw-00; Tue, 25 Mar 2003 12:19:06 +0100
Date: Tue, 25 Mar 2003 12:19:06 +0100
From: Igor Genibel <igor@genibel.org>
To: Jamie Wilkinson <jaq@debian.org>, 164410-done@bugs.debian.org
Subject: Re: Bug#164410: qa.debian.org: developer.php opens excuses links in a new window/popup
Message-ID: <20030325111906.GG29829@tass.genibel.org>
References: <20021012024800.GA30724@spacepants.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB"
Content-Disposition: inline
In-Reply-To: <20021012024800.GA30724@spacepants.org>
User-Agent: Mutt/1.3.28i
Delivered-To: 164410-done@bugs.debian.org
X-Spam-Status: No, hits=-4.5 required=4.0
tests=EMAIL_ATTRIBUTION,IN_REP_TO,PGP_SIGNATURE_2,REFERENCES,
SPAM_PHRASE_00_01,USER_AGENT,USER_AGENT_MUTT
version=2.44
X-Spam-Level:
--tThc/1wpZn/ma/RB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Oct 12, 2002 at 12:48:00PM +1000, Jamie Wilkinson wrote:
Hi Jamie,=20
I released a new version of developer.php that fixes this annoying
target=3D"_blank" links in excuse files.
Cheers
--=20
Igor Genibel=20
http://www.answare.fr/ igor.genibel@eds.com
http://www.tuxfamily.org/ igor@tuxfamily.net
http://people.debian.org/~igenibel igenibel@debian.org
GPG: 1024D/9D735B4F: 4F61 8D8F 05AC 8D2C 5F92 9B99 C44B 0266 9D73 5B4F
--tThc/1wpZn/ma/RB
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+gDsqxEsCZp1zW08RAlQXAJoCYt1TBkusN16bBUZph02fTpMdkwCdGv/m
A0YbAp2bjz5nRLYJqZnU/bc=
=BpNu
-----END PGP SIGNATURE-----
--tThc/1wpZn/ma/RB--
Reply to: