[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#182154: wrong assumption on char signedness



On Sun, Feb 23, 2003 at 12:54:57PM +0100, Gerhard Tonn wrote:
> Package: evas
> Version:  0.6.0-3
> Severity: important

I've prepared a QA fix for this bug.  However, as I'm not a Debian
developer yet, I need someone to upload it for me.

A patch against the last upload is attached and the full source package is
available from http://www.blckknght.org/~steve/debian/evas/

-- 
Steven Barker                                      steve@blckknght.org
  These screamingly hilarious gogs ensure owners of
  X Ray Gogs to be the life of any party.
  -- X-Ray Gogs Instructions
Get my GnuPG public key at: http://www.blckknght.org/publickey.asc
Fingerprint: 272A 3EC8 52CE F22B F745  775E 5292 F743 EBD5 936B
diff -ur evas-0.6.0/debian/changelog evas-0.6.0-QA/debian/changelog
--- evas-0.6.0/debian/changelog	2003-03-07 16:16:50.000000000 -0500
+++ evas-0.6.0-QA/debian/changelog	2003-03-07 17:32:31.000000000 -0500
@@ -1,3 +1,17 @@
+evas (0.6.0-4) unstable; urgency=low
+
+  * QA upload.
+  * debian/control: Update QA email address.
+  * src/evas_renderer_routines.c: Fix char signedness assumptions.
+    (Closes: #182154)
+  * src/evas_object.c: Fix function order bug that may have broken
+    arches where sizeof(int) != sizeof(void *).
+  * src/eval_gl_routines.c: Fix use of infinate texture coordonates,
+    using patch from Michel Daenzer <michel@daenzer.net>.
+    (Closes: #165473)
+
+ -- Steven Barker <steve@blckknght.org>  Fri,  7 Mar 2003 15:48:42 -0500
+
 evas (0.6.0-3) unstable; urgency=low
 
   * orphaned 
diff -ur evas-0.6.0/debian/control evas-0.6.0-QA/debian/control
--- evas-0.6.0/debian/control	2003-03-07 16:16:50.000000000 -0500
+++ evas-0.6.0-QA/debian/control	2003-03-07 15:58:07.000000000 -0500
@@ -1,7 +1,7 @@
 Source: evas
 Section: libs
 Priority: optional
-Maintainer: Debian QA Group <debian-qa@lists.debian.org>
+Maintainer: Debian QA Group <packages@qa.debian.org>
 Build-Depends: xlibs-dev, xlibmesa-dev, libttf-dev, libimlib2-dev, debhelper (>=3.0)
 Standards-Version: 3.5.4.0
 
diff -ur evas-0.6.0/src/evas_gl_routines.c evas-0.6.0-QA/src/evas_gl_routines.c
--- evas-0.6.0/src/evas_gl_routines.c	2001-08-27 22:06:40.000000000 -0400
+++ evas-0.6.0-QA/src/evas_gl_routines.c	2003-03-07 17:00:19.000000000 -0500
@@ -2,6 +2,7 @@
 #include <sys/stat.h>
 #include <unistd.h>
 #include <sys/types.h>
+#include <math.h>
 #include <assert.h>
 
 /* uncomment this is partial buffer swaps slow - problem with glcopypixels? */
@@ -1476,6 +1477,10 @@
 			      }
 			 }
 		       __evas_gl_window_use_texture(glw, tm->textures[t++], smooth);
+		       if (isinf(tx1)) tx1 = 1.0;
+		       if (isinf(ty1)) ty1 = 1.0;
+		       if (isinf(tx2)) tx2 = 1.0;
+		       if (isinf(ty2)) ty2 = 1.0;
 		       glBegin(GL_QUADS);
 		       glTexCoord2d(tx1, ty1); glVertex2d(x1, y1);
 		       glTexCoord2d(tx2, ty1); glVertex2d(x2, y1);
diff -ur evas-0.6.0/src/evas_object.c evas-0.6.0-QA/src/evas_object.c
--- evas-0.6.0/src/evas_object.c	2001-09-21 05:17:54.000000000 -0400
+++ evas-0.6.0-QA/src/evas_object.c	2003-03-07 15:35:16.000000000 -0500
@@ -90,6 +90,30 @@
 }
 
 void
+_evas_cleanup_clip(Evas e, Evas_Object o)
+{
+   if (o->clip.list)
+     {
+	Evas_List l;
+	
+	for (l = o->clip.list; l; l = l->next)
+	  {
+	     Evas_Object o2;
+	     
+	     o2 = l->data;
+	     o2->clip.object = NULL;
+	     o2->clip.changed = 1;
+	     o2->changed = 1;
+	     e->changed = 1;
+	  }
+	evas_list_free(o->clip.list);
+	o->clip.list = NULL;
+     }
+   if (o->clip.object)
+     o->clip.object->clip.list = evas_list_remove(o->clip.object->clip.list, o);
+}
+
+void
 _evas_layer_free(Evas e, Evas_Layer layer)
 {
    if (layer->objects)
@@ -115,30 +139,6 @@
    free(layer);
 }
 
-void
-_evas_cleanup_clip(Evas e, Evas_Object o)
-{
-   if (o->clip.list)
-     {
-	Evas_List l;
-	
-	for (l = o->clip.list; l; l = l->next)
-	  {
-	     Evas_Object o2;
-	     
-	     o2 = l->data;
-	     o2->clip.object = NULL;
-	     o2->clip.changed = 1;
-	     o2->changed = 1;
-	     e->changed = 1;
-	  }
-	evas_list_free(o->clip.list);
-	o->clip.list = NULL;
-     }
-   if (o->clip.object)
-     o->clip.object->clip.list = evas_list_remove(o->clip.object->clip.list, o);
-}
-
 int
 _evas_point_in_object(Evas e, Evas_Object o, int x, int y)
 {
diff -ur evas-0.6.0/src/evas_render_routines.c evas-0.6.0-QA/src/evas_render_routines.c
--- evas-0.6.0/src/evas_render_routines.c	2001-08-19 23:25:56.000000000 -0400
+++ evas-0.6.0-QA/src/evas_render_routines.c	2003-03-07 17:15:14.000000000 -0500
@@ -32,7 +32,7 @@
    imlib_set_cache_size(size);
 }
 
-static char              x_does_shm = -1;
+static signed char       x_does_shm = -1;
 static int               list_num = 0;
 static XImage          **list_xim = NULL;
 static XShmSegmentInfo **list_si = NULL;

Attachment: pgpDNd0hCHMVw.pgp
Description: PGP signature


Reply to: