[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: modutils bug 108934



On Sat, Aug 18, 2001 at 11:48:43PM +0200, Wichert Akkerman wrote:
> Previously Anthony Towns wrote:
> > What's being done to fix this bug? When will it be fixed? Etc?
> Waiting for upstream.

That sounds an awful lot like "nothing" and "no idea", respectively.

This bug appears to have been introduced when flag_unresolved_error was
added in 2.4.7, and the trivial fix of making flag_unresolved_error a
static and defining it out if the #ifdef should work perfectly (since
flag_unresolved_error is not referred to outside of depmod.c). The patch
would be:

--- modutils-2.4.7/depmod/depmod.c      Wed Aug 15 22:33:27 2001
+++ modutils-2.4.7-fixed/depmod/depmod.c        Sun Aug 19 15:30:44 2001
@@ -225,9 +225,9 @@
 
 static int quiet;      /* Don't print errors */
 static int showerror;  /* Shows undefined symbols */
+static int flag_unresolved_error = 0; /* Exit w/ error un unresolved symbol */
 #if !defined(COMMON_3264) || defined(ONLY_64)
 int flag_verbose = 0;
-int flag_unresolved_error = 0;
 #endif
 
 extern int depmod_main(int argc, char **argv);

Cheers,
aj

-- 
Anthony Towns <aj@humbug.org.au> <http://azure.humbug.org.au/~aj/>
I don't speak for anyone save myself. GPG signed mail preferred.

``_Any_ increase in interface difficulty, in exchange for a benefit you
  do not understand, cannot perceive, or don't care about, is too much.''
                      -- John S. Novak, III (The Humblest Man on the Net)

Attachment: pgpMnifgRWhHD.pgp
Description: PGP signature


Reply to: