Bug#53716: marked as done (Fails on machines where chars are unsigned.)
Your message dated Tue, 27 Mar 2001 08:24:45 +0200
with message-id <20010327082445.A12662@jagor.srce.hr>
and subject line Closed in xpuzzles 5.5.2-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 30 Dec 1999 02:31:06 +0000
Received: (qmail 2227 invoked from network); 30 Dec 1999 02:31:06 -0000
Received: from core.federated.com (root@199.217.175.51)
by master.debian.org with SMTP; 30 Dec 1999 02:31:06 -0000
Received: (from jim@localhost)
by core.federated.com (8.9.3/8.9.3/Debian 8.9.3-6) id UAA28813
for submit@bugs.debian.org; Wed, 29 Dec 1999 20:31:05 -0600
From: Jim Studt <jim@federated.com>
Message-Id: <199912300231.UAA28813@core.federated.com>
Subject: Fails on machines where chars are unsigned.
To: submit@bugs.debian.org
Date: Wed, 29 Dec 1999 20:31:05 -0600 (CST)
X-Mailer: ELM [version 2.4ME+ PL66 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Package: xpuzzles
Version: 5.4.4-4
There are about 67 occurences of the line...
while ((c = getc(fp)) != EOF && c != SYMBOL);
... where c is a char.
On architectures where char is unsigned (definately ARM and maybe PPC)
this comparison fails because the int from getc has been reduced to
an unsigned char which will never equal EOF.
--
Jim Studt, President
The Federated Software Group, Inc.
---------------------------------------
Received: (at 53716-done) by bugs.debian.org; 27 Mar 2001 06:24:48 +0000
>From mvela@jagor.srce.hr Tue Mar 27 00:24:48 2001
Return-path: <mvela@jagor.srce.hr>
Received: from jagor.srce.hr [161.53.2.130] (mvela)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 14hmuN-0002lR-00; Tue, 27 Mar 2001 00:24:48 -0600
Received: (from mvela@localhost)
by jagor.srce.hr (8.9.0/8.9.0) id IAA14508
for 53716-done@bugs.debian.org; Tue, 27 Mar 2001 08:24:45 +0200 (MET DST)
Date: Tue, 27 Mar 2001 08:24:45 +0200
From: Matej Vela <vela@debian.org>
To: 53716-done@bugs.debian.org
Subject: Closed in xpuzzles 5.5.2-4
Message-ID: <20010327082445.A12662@jagor.srce.hr>
References: <[🔎] E14hdOi-0002I1-00@auric.debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95i
In-Reply-To: <[🔎] E14hdOi-0002I1-00@auric.debian.org>; from Debian QA Group on Mon, Mar 26, 2001 at 03:15:28PM -0500
Delivered-To: 53716-done@bugs.debian.org
(This report is being closed manually due to Bug#71600.)
Here is the relevant changelog entry:
xpuzzles (5.5.2-4) unstable; urgency=low
[...]
* Use `int' to store the return value from `getc' since `char' is
unsigned on some machines and cannot equal `EOF'. Closes: #53716.
Thanks,
Matej
Reply to: