Bug#46197: marked as done (A few updates to mserver)
Your message dated Sun, 25 Mar 2001 10:15:21 +0200
with message-id <20010325101521.G4660@om>
and subject line Closed in mserver 0.23a-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 28 Sep 1999 20:59:26 +0000
Received: (qmail 7584 invoked from network); 28 Sep 1999 20:59:25 -0000
Received: from smtprch1.nortelnetworks.com (HELO smtprch1.nortel.com) (192.135.215.14)
by master.debian.org with SMTP; 28 Sep 1999 20:59:25 -0000
Received: from zcard015.ca.nortel.com (actually zcard015)
by smtprch1.nortel.com; Tue, 28 Sep 1999 15:50:16 -0500
Received: from zcard00e.ca.nortel.com ([47.130.0.90]) by zcard015.ca.nortel.com
with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2448.0)
id TVRA8Q4J; Tue, 28 Sep 1999 16:58:36 -0400
Received: from nortelnetworks.com (wcars0ch.ca.nortel.com [47.209.17.60])
by zcard00e.ca.nortel.com
with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2448.0)
id TVRBNMX1; Tue, 28 Sep 1999 16:58:34 -0400
Sender: "Behan Webster" <behanw@nortelnetworks.com>
Message-ID: <37F12BFB.2B480965@nortelnetworks.com>
Date: Tue, 28 Sep 1999 16:58:35 -0400
From: "Behan Webster" <behanw@nortelnetworks.com>
Reply-To: behanw@pobox.com
Organization: Nortel Networks
X-Mailer: Mozilla 4.6 [en] (X11; U; SunOS 5.6 sun4u)
X-Accept-Language: en
MIME-Version: 1.0
To: submit@bugs.debian.org
Subject: A few updates to mserver
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Package: mserver
Version: 0.21-3
A couple of miscellaneous changes.
1) set the socket to SO_REUSEADDR, so that it will reuse a port without
complaining. It makes restarting the daemon much less painful.
2) Add support for baud rates above 38400.
3) Fork before checking whether the port is already in use. This makes
sure that the child process's procid is listed in the lockfile instead of
the parent mserver process. This helps out if you want to selectively kill
off the mserver child process connected to a particular port
Here's the diff:
--- mserver-0.21.orig/mserver.c Tue Sep 28 16:44:25 1999
+++ mserver-0.21/mserver.c Tue Sep 28 16:35:25 1999
@@ -218,12 +218,14 @@
void bind_ports (void)
{
NETPORT *w;
+ long optval = 1;
for (w = netports; w; w = w->next)
{
if ((w->servfd = socket(AF_INET, SOCK_STREAM, 0)) < 0)
errorf ("can't create server socket\n");
+ setsockopt( w->servfd, SOL_SOCKET, &optval, sizeof(optval)
);
bzero ((char *) &w->addr, sizeof(w->addr));
w->addr.sin_family = AF_INET;
w->addr.sin_addr.s_addr = htonl(INADDR_ANY);
@@ -258,6 +260,8 @@
static struct { int ibaud, speed; } btable[] =
{
+ { 115200, B115200 },
+ { 57600, B57600 },
{ 38400, B38400 },
{ 19200, B19200 },
{ 9600, B9600 },
@@ -351,6 +355,9 @@
int n, devfd, ok, busy, fdmax = 0, quit = 0, *pidp;
char buff[BUFF_SIZE], *s, **ss;
+ if ((*pidp = fork()) != 0) /* parent || error */
+ return;
+
for (mod = port->netmods; mod; mod = mod->next)
if (mod->chldpid == -1)
if (create_lock(mod->devname))
@@ -366,9 +373,6 @@
busy = 0;
pidp = &mod->chldpid;
}
-
- if ((*pidp = fork()) != 0) /* parent || error */
- return;
/* child */
Thanks,
Behan
--
Behan Webster (613) 763-2381 home: mailto:behanw@pobox.com
mailto:behanw@nortelnetworks.com http://www.pobox.com/~behanw/
http://spectrumibl/~behanw/ My opinions, not Nortel's.
---------------------------------------
Received: (at 46197-done) by bugs.debian.org; 25 Mar 2001 08:43:28 +0000
>From mvela@public.srce.hr Sun Mar 25 02:43:28 2001
Return-path: <mvela@public.srce.hr>
Received: from jagor.srce.hr [161.53.2.130] (root)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 14h67U-0002Hd-00; Sun, 25 Mar 2001 02:43:28 -0600
Received: from om (asy68.jmu.carnet.hr [193.198.128.68])
by jagor.srce.hr (8.9.0/8.9.0) with ESMTP id KAA12354
for <46197-done@bugs.debian.org>; Sun, 25 Mar 2001 10:43:26 +0200 (MET DST)
Received: from mvela by om with local (Exim 3.22 #1 (Debian))
id 14h5gJ-0001EG-00
for <46197-done@bugs.debian.org>; Sun, 25 Mar 2001 10:15:23 +0200
Date: Sun, 25 Mar 2001 10:15:21 +0200
From: Matej Vela <vela@debian.org>
To: 46197-done@bugs.debian.org
Subject: Closed in mserver 0.23a-1
Message-ID: <20010325101521.G4660@om>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.15i
X-Accept-Language: en, hr
Sender: Matej Vela <mvela@om>
Delivered-To: 46197-done@bugs.debian.org
(This report is being closed manually due to Bug#71600.)
Here is the relevant changelog entry:
mserver (0.23a-1) unstable; urgency=low
[...]
* mserver.c: Enable SO_REUSEADDR to facilitate restarting. (Thanks to
Behan Webster for the preliminary patch; rest of his changes have
been implemented upstream.) Closes: #46197.
[...]
-- Matej Vela <vela@debian.org> Fri, 23 Mar 2001 10:10:18 +0100
Thanks,
Matej
Reply to: