[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#76752: marked as done (get-news may generate spurious error messages)



Your message dated Thu, 08 Feb 2001 15:04:57 -0500
with message-id <E14QxJJ-0004OS-00@auric.debian.org>
and subject line Bug#76752: fixed in suck 4.2.5-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Darren Benham
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Nov 2000 04:06:52 +0000
>From womble@zzumbouk.demon.co.uk Fri Nov 10 22:06:51 2000
Return-path: <womble@zzumbouk.demon.co.uk>
Received: from anchor-post-32.mail.demon.net [::ffff:194.217.242.90] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 13uRwJ-0000ZY-00; Fri, 10 Nov 2000 22:06:51 -0600
Received: from zzumbouk.demon.co.uk ([193.237.85.208])
	by anchor-post-32.mail.demon.net with esmtp (Exim 2.12 #1)
	id 13uRwE-000GB1-0W
	for submit@bugs.debian.org; Sat, 11 Nov 2000 04:06:46 +0000
Received: from womble by zzumbouk.demon.co.uk with local (Exim 3.12 #1 (Debian))
	id 13uRwC-0003Nz-00; Sat, 11 Nov 2000 04:06:44 +0000
Date: Sat, 11 Nov 2000 04:06:44 +0000
To: submit@bugs.debian.org
Subject: get-news may generate spurious error messages
Message-ID: <20001111040644.A4123@zzumbouk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
From: Ben Hutchings <womble@zzumbouk.demon.co.uk>
Delivered-To: submit@bugs.debian.org

Package: suck
Version: 4.2.2-4

get-news contains two series of commands to call suck and to save the
new status files that it generates.  If the server being used is not
the default one, or there is no default server, it will call mv with a
wildcard `${STATEDIR}/suck.*.${SITENAME}', whereas if the server is
the default it checks for two specific files that this wildcard would
match and moves them if they exist.  If suck has not downloaded any
news, neither of these files will be created, the wildcard will fail
to match anything, and mv will report an error similar to this:

    mv: /var/state/suck/suck.*.news.demon.co.uk: No such file or directory

This did not happen before I upgraded the suck package yesterday.  I
don't know what version I was using previously, as neither apt nor
dpkg seem to keep a log of upgrades.

Here's the get-news.conf I've been using:

# Debian GNU/Linux suck package /usr/sbin/get-news config file

# Your default local NNTP server.
# (inn note: must be in /etc/news/hosts.nntp)
server: localhost

# The default NNTP server you will connect to. Suck will use
# the defaults files sucknewsrc, suckkillfile and suckothermsgs
# for this default remote server.
#remoteserver: news.demon.co.uk

# The default outgoing articles file for your default remote server.
# (inn note: see /etc/news/newsfeeds)
outgoingfile: remotehost

# The sed command used for outgoing articles.
sedcmd: /^NNTP-Posting-Host:\|^Xref:\|^Originator:/d

# The userid to send to the remote server.
#userid:

# The password to send to the remote server.
#password:

# The remote server port number if not standard.
#remoteport:
---END---

I consider that there is needless duplication of code in get-news and
that this is part of the cause of this bug and bug number 66608.
Here's a patch that merges the two branches together, hopefully fixing
both bugs:

*** /usr/sbin/get-news~	Mon Jan 24 23:25:24 2000
--- /usr/sbin/get-news	Sat Nov 11 03:30:05 2000
***************
*** 174,219 ****
  
  [ -d ${LASTDIR} ] || mkdir ${LASTDIR}
  
  if [ "${REMOTE_SERVER_DEFAULT}" = "${REMOTE_SERVER}" ]; then
- 	date >> ${GETNEWSLOG}
  	echo 'get-news: download articles with the default remote server' >> ${GETNEWSLOG}
! 	if [ -f "${INNXMIT}" ]; then
! 		${SUCK} ${REMOTE_SERVER} ${OPTS} ${AUTHOPTS} -bi ${BATCHFILE} -dt ${STATEDIR} -dm ${MSGDIR} -dd ${ETCDIR} -N ${REMOTE_PORT} -E ${ERRLOG} 
! 	else
! 		${SUCK} ${REMOTE_SERVER} ${OPTS} ${AUTHOPTS} -br ${BATCHFILE} -dt ${STATEDIR} -dm ${MSGDIR} -dd ${ETCDIR} -N ${REMOTE_PORT} -E ${ERRLOG}
! 	fi
! 	SUCK_STATUS=$?
! 	if [ ${SUCK_STATUS} -eq 0 ]; then
! 		echo "Downloaded Articles"
! 		mv ${ETCDIR}/sucknewsrc ${ETCDIR}/sucknewsrc.old
! 		mv ${STATEDIR}/suck.newrc ${ETCDIR}/sucknewsrc
! 		if [ -f ${STATEDIR}/suck.sorted ]; then	
! 			mv ${STATEDIR}/suck.sorted ${LASTDIR}
! 		fi
! 		if [ -f ${STATEDIR}/suck.killlog ]; then	
! 			mv ${STATEDIR}/suck.killlog ${LASTDIR}
! 		fi
! 		if [ -f ${ETCDIR}/suckothermsgs ]; then
! 			mv ${ETCDIR}/suckothermsgs ${LASTDIR}
! 		fi
! 	fi
  else
- 	date >> ${GETNEWSLOG}
  	echo 'get-news: download articles' >> ${GETNEWSLOG}
! 	if [ -f "${INNXMIT}" ]; then
! 		${SUCK} ${REMOTE_SERVER} ${AUTHOPTS} -bi ${BATCHFILE} -dt ${STATEDIR} -dm ${MSGDIR} -dd ${ETCDIR} -p .${REMOTE_SERVER} -N ${REMOTE_PORT} -E ${ERRLOG}
! 	else
! 		${SUCK} ${REMOTE_SERVER} ${AUTHOPTS} -br ${BATCHFILE} -dt ${STATEDIR} -dm ${MSGDIR} -dd ${ETCDIR} -p .${REMOTE_SERVER} -N ${REMOTE_PORT} -E ${ERRLOG}
  	fi
! 	SUCK_STATUS=$?
! 	if [ ${SUCK_STATUS} -eq 0 ]; then
! 		echo "Downloaded Articles"
! 		mv ${ETCDIR}/sucknewsrc.${REMOTE_SERVER} ${ETCDIR}/sucknewsrc.${REMOTE_SERVER}.old
! 		mv ${STATEDIR}/suck.newrc.${REMOTE_SERVER} ${ETCDIR}/sucknewsrc.${REMOTE_SERVER}
! 		mv ${STATEDIR}/suck.*.${REMOTE_SERVER} ${LASTDIR}
! 		if [ -f ${ETCDIR}/suckothermsgs.${REMOTE_SERVER} ]; then
! 			mv ${ETCDIR}/suckothermsgs.${REMOTE_SERVER} ${LASTDIR}
! 		fi
  	fi
  fi
  
--- 174,207 ----
  
  [ -d ${LASTDIR} ] || mkdir ${LASTDIR}
  
+ date >> ${GETNEWSLOG}
  if [ "${REMOTE_SERVER_DEFAULT}" = "${REMOTE_SERVER}" ]; then
  	echo 'get-news: download articles with the default remote server' >> ${GETNEWSLOG}
! 	SUFFIX=""
  else
  	echo 'get-news: download articles' >> ${GETNEWSLOG}
! 	SUFFIX=".${REMOTE_SERVER}"
! 	OPTS="${OPTS} -p ${SUFFIX}"
! fi
! 
! if [ -f "${INNXMIT}" ]; then
! 	${SUCK} ${REMOTE_SERVER} ${OPTS} ${AUTHOPTS} -bi ${BATCHFILE} -dt ${STATEDIR} -dm ${MSGDIR} -dd ${ETCDIR} -N ${REMOTE_PORT} -E ${ERRLOG} 
! else
! 	${SUCK} ${REMOTE_SERVER} ${OPTS} ${AUTHOPTS} -br ${BATCHFILE} -dt ${STATEDIR} -dm ${MSGDIR} -dd ${ETCDIR} -N ${REMOTE_PORT} -E ${ERRLOG}
! fi
! SUCK_STATUS=$?
! if [ ${SUCK_STATUS} -eq 0 ]; then
! 	echo "Downloaded Articles"
! 	mv ${ETCDIR}/sucknewsrc${SUFFIX} ${ETCDIR}/sucknewsrc${SUFFIX}.old
! 	mv ${STATEDIR}/suck.newrc${SUFFIX} ${ETCDIR}/sucknewsrc${SUFFIX}
! 	if [ -f ${STATEDIR}/suck.sorted${SUFFIX} ]; then
! 		mv ${STATEDIR}/suck.sorted${SUFFIX} ${LASTDIR}
! 	fi
! 	if [ -f ${STATEDIR}/suck.killlog${SUFFIX} ]; then
! 		mv ${STATEDIR}/suck.killlog${SUFFIX} ${LASTDIR}
  	fi
! 	if [ -f ${ETCDIR}/suckothermsgs${SUFFIX} ]; then
! 		mv ${ETCDIR}/suckothermsgs${SUFFIX} ${LASTDIR}
  	fi
  fi
  
---END---

---------------------------------------
Received: (at 76752-close) by bugs.debian.org; 8 Feb 2001 20:07:17 +0000
>From troup@auric.debian.org Thu Feb 08 14:07:17 2001
Return-path: <troup@auric.debian.org>
Received: from auric.debian.org [::ffff:206.246.226.45] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 14QxLZ-0002hn-00; Thu, 08 Feb 2001 14:07:17 -0600
Received: from troup by auric.debian.org with local (Exim 3.12 1 (Debian))
	id 14QxJJ-0004OS-00; Thu, 08 Feb 2001 15:04:57 -0500
From: Tollef Fog Heen <tfheen@debian.org>
To: 76752-close@bugs.debian.org
Subject: Bug#76752: fixed in suck 4.2.5-3
Message-Id: <E14QxJJ-0004OS-00@auric.debian.org>
Sender: James Troup <troup@auric.debian.org>
Date: Thu, 08 Feb 2001 15:04:57 -0500
Delivered-To: 76752-close@bugs.debian.org

We believe that the bug you reported is fixed in the latest version of
suck, which has been installed in the Debian FTP archive:

suck_4.2.5-3.diff.gz
  to pool/main/s/suck/suck_4.2.5-3.diff.gz
suck_4.2.5-3_i386.deb
  to pool/main/s/suck/suck_4.2.5-3_i386.deb
suck_4.2.5-3.dsc
  to pool/main/s/suck/suck_4.2.5-3.dsc
A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 76752@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tollef Fog Heen <tfheen@debian.org> (supplier of updated suck package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  4 Feb 2001 22:08:47 +0100
Source: suck
Binary: suck
Architecture: source i386
Version: 4.2.5-3
Distribution: unstable
Urgency: low
Maintainer: Tollef Fog Heen <tfheen@debian.org>
Changed-By: Tollef Fog Heen <tfheen@debian.org>
Description: 
 suck       - Small newsfeed from an NNTP server with standard NNTP commands.
Closes: 63917 66089 66608 76752 80492 83401 83485
Changes: 
 suck (4.2.5-3) unstable; urgency=low
 .
   * Adopted the package (closes: #80492)
   * Use custom options when fetching from all servers (closes: #66608)
   * Make sure the post-download state files exist, using patch in 76752.
     (closes: #76752)
   * Added lmove (closes: #66089)
   * get-news now puts the authentication stuff in the environment - small
     patch for suck.c and rpost.c needed, forwarded upstream. (closes:
     #63917)
   * Changed from yada to debhelper
   * Added some README files which weren't included before.
   * Added Swedish, Norwegian and German translations to the debconf
     template. (closes: #83401, #83485)
Files: 
 a2b1f289185a4c1c66192be990010215 604 news extra suck_4.2.5-3.dsc
 b65cd68cc60d40d2e4f02729099bd1f2 14090 news extra suck_4.2.5-3.diff.gz
 fd8cf091252873914e8f29ea6f8a5fb4 115232 news extra suck_4.2.5-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE6gn01QSseMYF6mWoRAt9QAKDxAUSsJIsECwjOCe09MJAiGGB3+QCg3kWy
uemApqN5eHtmzq9zmFfylHQ=
=C/cL
-----END PGP SIGNATURE-----



Reply to: