[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1119385: marked as done (d52: please build using the default build flags)

Your message dated Wed, 17 Dec 2025 10:19:13 +0000
with message-id <E1vVocj-006zQb-07@fasolo.debian.org>
and subject line Bug#1119385: fixed in d52 3.4.1+git20191024.ac20ebd-1
has caused the Debian Bug report #1119385,
regarding d52: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1119385: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119385
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: d52
Version: 3.4.1-2
User: debian-security@lists.debian.org
Usertags: hardening-buildflags

d52 is not currently using the default build flags set by dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that d52 builds using the default build flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
d52, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
 	dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message --- 
Source: d52
Source-Version: 3.4.1+git20191024.ac20ebd-1
Done: Andreas Tille <tille@debian.org>

We believe that the bug you reported is fixed in the latest version of
d52, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1119385@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Tille <tille@debian.org> (supplier of updated d52 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 17 Dec 2025 10:24:57 +0100
Source: d52
Architecture: source
Version: 3.4.1+git20191024.ac20ebd-1
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Tille <tille@debian.org>
Closes: 706520 706728 706730 1119385
Changes:
 d52 (3.4.1+git20191024.ac20ebd-1) unstable; urgency=medium
 .
   * QA upload.
 .
   * New upstream version
     Closes: #706730, #706728
   * Use the default build flags
     Closes: #1119385
   * Do not ignore blhc test in Salsa CI
   * Include upstream docs
     Closes: #706520
   * d/watch:
      - version=5
      - Point to latest commit on Github
   * Add d/upstream/metadata
Checksums-Sha1:
 9a1b9af18ec98968c8e136a07f915962e95651b4 1931 d52_3.4.1+git20191024.ac20ebd-1.dsc
 9cb7334b17e8d9a7cf94eab15abd84d938717e74 89276 d52_3.4.1+git20191024.ac20ebd.orig.tar.xz
 49643e04ce54fc102ae1e0e09eed3984284fa302 2820 d52_3.4.1+git20191024.ac20ebd-1.debian.tar.xz
 7cde30182b598a8d668854d66baee0d38cb7f39d 6064 d52_3.4.1+git20191024.ac20ebd-1_amd64.buildinfo
Checksums-Sha256:
 b725b546faa6076da48b93cfb2e9192097c2f5fc15a003420d4d1cf01c96889f 1931 d52_3.4.1+git20191024.ac20ebd-1.dsc
 4f524a904935d73809386051ff7cf20460cdd48c1f120061f38629dcedca18c4 89276 d52_3.4.1+git20191024.ac20ebd.orig.tar.xz
 0c1962184be9eb66b7d04125abce5b34987a71896289970cbad3b4a958667c2c 2820 d52_3.4.1+git20191024.ac20ebd-1.debian.tar.xz
 eaa1829b613788f24a3d5f712212e43695bf731533e1cd7b79484abfa085d101 6064 d52_3.4.1+git20191024.ac20ebd-1_amd64.buildinfo
Files:
 386dd355cc4684c679bfbbded022ef8d 1931 devel optional d52_3.4.1+git20191024.ac20ebd-1.dsc
 665062b25c89e7059a7f47baccd8843e 89276 devel optional d52_3.4.1+git20191024.ac20ebd.orig.tar.xz
 945cc7fa2397b686bd9870500a5dd59b 2820 devel optional d52_3.4.1+git20191024.ac20ebd-1.debian.tar.xz
 745bdc906861c9c26fdd73a62887c130 6064 devel optional d52_3.4.1+git20191024.ac20ebd-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmlCf6IRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtF/uA//bzI7oPv7ftMLZ1gOVVPZFBx/9+KzQr0p
rztzqFtAvc5IdMVjnvwxoWGOqBFZpys6XKsmPE5gnuqVIloPqS+RxqlZgkSPxKtg
7dgZzsxJcF7GFZ4LTRliLNebqcNggCQpy7Rt/GE3kU2qO5GndQX5TNpnXkIv5F0A
Z5P0H0FGPSD1A6FlMZeBzpV6v5eB6CmgexvPEYMY49v5GfXPO6Ok0uVXXuabLFgQ
hCigy9kUpZDxEf0GSdJ33LXXxUVY/u0S430WMw5VY1UjdvTw/XXhUA0BFGLj/Bex
/DgVv7/KwAW7p07Ls8YA2avUU05ckPlG7gYJMY21OV6gzqbky0UIS3UC800rYK1d
t7rK1UWWbKmdIPn4E2/rVjMu9/QLOGnrRed7TbgxCmuSAtbPC8WHITtjoBNd3xNf
N+9amZEeTiudhGhD0uAtoC1RHYprhEHAqG3n2vXof1mm/XRdKgL3fbaOlIc4JtZT
0ZaXMue8/Nc4GxhMGn8wgh5pDsmunMIkJlhtKo5oKmoODcpIaMa66kuuuk7mzuIF
X5SkV+/l+k+Rt2KzVHG00wUWqAMSkAemg/722g88JyWdWwIg8YIUwmDhy6k08mSy
/Rus6Rkw7PsJ1970bIWeSVvwSAlevCP/aV3WjK2bcjmYO8Y/LyGKhs1Zw/TkE9zt
79LdGxhEBlA=
=YEx3
-----END PGP SIGNATURE-----

Attachment: pgpp9ZS6fG9RF.pgp
Description: PGP signature


--- End Message ---
Reply to: