[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1119609: marked as done (w3cam: please build using the default build flags)

Your message dated Tue, 16 Dec 2025 13:08:21 +0000
with message-id <E1vVUmr-002mAZ-0w@fasolo.debian.org>
and subject line Bug#1119609: fixed in w3cam 0.7.2-8
has caused the Debian Bug report #1119609,
regarding w3cam: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1119609: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119609
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: w3cam
Version: 0.7.2-6.4+b1
User: debian-security@lists.debian.org
Usertags: hardening-buildflags

w3cam is not currently using the default build flags set by dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that w3cam builds using the default build flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
w3cam, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
 	dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message --- 
Source: w3cam
Source-Version: 0.7.2-8
Done: Santiago Vila <sanvila@debian.org>

We believe that the bug you reported is fixed in the latest version of
w3cam, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1119609@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Santiago Vila <sanvila@debian.org> (supplier of updated w3cam package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 16 Dec 2025 13:30:00 +0100
Source: w3cam
Architecture: source
Version: 0.7.2-8
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Santiago Vila <sanvila@debian.org>
Closes: 1119609
Changes:
 w3cam (0.7.2-8) unstable; urgency=medium
 .
   * QA upload.
   * Fix clean target.
   * Honor dpkg-buildflags. Closes: #1119609.
   * d/control: Drop "Priority: optional" (default).
Checksums-Sha1:
 9a431e6bfa3df30c9b1638b744a5a51b6edf7477 1506 w3cam_0.7.2-8.dsc
 46a423ace7064a3ef924ed5a16117902e3ccb0cd 7160 w3cam_0.7.2-8.debian.tar.xz
 92db313db20200c481c9304f950a71557dfe1895 5824 w3cam_0.7.2-8_source.buildinfo
Checksums-Sha256:
 9fad6bd23237f045f747a15cfbd77e7f8022e57ec7b153a1d6b1865c625bbbbd 1506 w3cam_0.7.2-8.dsc
 0880d0278ed169227a287a265667927d62708a252b7877b2b18fb59496f4ea8d 7160 w3cam_0.7.2-8.debian.tar.xz
 abd227dbead579cae04e5d892c632f0fd68314c4cf5a918d999d491d855829e5 5824 w3cam_0.7.2-8_source.buildinfo
Files:
 c5404ddd1dc08e4fc02630ce34f180eb 1506 web optional w3cam_0.7.2-8.dsc
 536d512cf5cbaf8abeaab8abe37e8127 7160 web optional w3cam_0.7.2-8.debian.tar.xz
 ef7fedd101c12d421e335fc7e8e4cee9 5824 web optional w3cam_0.7.2-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEE1Uw7+v+wQt44LaXXQc5/C58bizIFAmlBUlQACgkQQc5/C58b
izK54wf/X1mpiaFg2c60yMB6aoqGhc01xPWkCvmf8t9DsxDfxlSZbNGTg311Wo0F
CzEVTMJi0r6F6H2Wj906Z4J/YJFBHEU9MfEYfnMhlhUsK/q7HKBAmp6Xml+jFX4N
/D+PT01lRBKCbZT8yGTxBYAUl6n+fz8/jvwLON+of7wZYAINv/C4BgfTm/BpODW5
PcBRQUsP14ceeESs3tvIJeQsB6ivCsfEO/bTvbsgwFp+n7EnqXRaA7C28/AnYbk1
88/nkZgu9RPCuZiKjE/ptf96LUPaWh+Ps750dcpfiPv7JJG96ZnFKcxM9ZRKyimu
kjNfuNjqTw1YkRmQAS7iiMUpL0G3bQ==
=FK9B
-----END PGP SIGNATURE-----

Attachment: pgpNCfzYrR3qK.pgp
Description: PGP signature


--- End Message ---
Reply to: