[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1120742: awffull: Broken when systemd is installed



Package: awffull
Version: 3.10.2-10
Severity: grave
Tags: patch trixie sid forky

"Grave" because this bug makes the package in question unusable by
most or all users (because most Debian installations are nowadays
using systemd).

Caused by 381d8b9c7016 ("Import Debian changes 3.10.2-9"). In the
changelog, it is "debian/awffull.cron.daily: Skip job on systemd
systems if it is invoked by cron; the systemd timer should be
triggered instead."

The cron script is now requiring a parameter when it is started by
systemd. It has to be set to " systemd-timer". But for some reason,
this parameter was not added to debian/awffull.service (in the same
commit). As result, the cron job will directly quit when it is started
by the systemd timer:

```
AWFTIMER=$1

# Skip job in favour of systemd timer if invoked by cron.daily.
if [ -d /run/systemd/system ] && [ "$AWFTIMER" != "systemd-timer" ]; then
   exit 0
fi
```

The fix for this is:

diff --git i/debian/awffull.service w/debian/awffull.service
index b7d8be1..1a63de6 100644
--- i/debian/awffull.service
+++ w/debian/awffull.service
@@ -5,5 +5,5 @@ ConditionACPower=true

 [Service]
 Type=oneshot
-ExecStart=/etc/cron.daily/awffull
+ExecStart=/etc/cron.daily/awffull systemd-timer


Reply to: