Control: tags -1 upstream patch thanks On Mon, Sep 01, 2025 at 12:42:22AM +0200, roehling@debian.org wrote: > During a test rebuild for CMake 4, clementine failed to rebuild. > [...] > The most likely cause of build failures is the removed backwards compatibility for > CMake versions earlier than 3.5. You can find additional information in my > debian-devel announcement: > > https://lists.debian.org/debian-devel/2025/04/msg00310.html The patch at <https://github.com/clementine-player/Clementine/pull/7402> (modulo the 3rdparty parts which had been stripped from the Debian sources, and now attached) allows clementine to build again, both with cmake 4.1.1+really4.1.1-1 (as currently present in experimental) and with cmake 4.1.1+really3.31.6-2 (as currently present in unstable/testing). CC'ing the prospective adopter of the package, as per <https://bugs.debian.org/1092799>. HTH, Flo
diff -Nru clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/FTBFS_with_CMake_4.patch clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/FTBFS_with_CMake_4.patch
--- clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/FTBFS_with_CMake_4.patch 1970-01-01 01:00:00.000000000 +0100
+++ clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/FTBFS_with_CMake_4.patch 2025-09-28 14:11:12.000000000 +0200
@@ -0,0 +1,86 @@
+diff --git a/3rdparty/qtiocompressor/CMakeLists.txt b/3rdparty/qtiocompressor/CMakeLists.txt
+index 98d6445f85..2b434da7e7 100644
+--- a/3rdparty/qtiocompressor/CMakeLists.txt
++++ b/3rdparty/qtiocompressor/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 3.0.0)
++cmake_minimum_required(VERSION 3.10.0)
+
+ set(IOCOMPRESSOR-SOURCES
+ qtiocompressor.cpp
+diff --git a/3rdparty/qtsingleapplication/CMakeLists.txt b/3rdparty/qtsingleapplication/CMakeLists.txt
+index c405256f9a..c9ee4afe6c 100644
+--- a/3rdparty/qtsingleapplication/CMakeLists.txt
++++ b/3rdparty/qtsingleapplication/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 3.0.0)
++cmake_minimum_required(VERSION 3.10.0)
+
+ set(SINGLEAPP-SOURCES
+ qtlocalpeer.cpp
+diff --git a/3rdparty/qxt/CMakeLists.txt b/3rdparty/qxt/CMakeLists.txt
+index b3348c4b86..7d60902379 100644
+--- a/3rdparty/qxt/CMakeLists.txt
++++ b/3rdparty/qxt/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 3.0.0)
++cmake_minimum_required(VERSION 3.10.0)
+ set(CMAKE_CXX_STANDARD 11)
+
+ set(QXT-SOURCES
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 48b55f4c55..f9076d9b49 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -1,8 +1,6 @@
+-cmake_minimum_required(VERSION 3.13.0)
++cmake_minimum_required(VERSION 3.30.0)
+ project(clementine)
+
+-cmake_policy(SET CMP0053 OLD)
+-
+ include(CheckCXXCompilerFlag)
+ include(FindPkgConfig)
+ include(cmake/C++11Compat.cmake)
+diff --git a/cmake/ParseArguments.cmake b/cmake/ParseArguments.cmake
+index fd5f9987ec..19ca67ab1c 100644
+--- a/cmake/ParseArguments.cmake
++++ b/cmake/ParseArguments.cmake
+@@ -1,6 +1,6 @@
+ # From http://www.cmake.org/Wiki/CMakeMacroParseArguments
+
+-cmake_minimum_required(VERSION 3.0.0)
++cmake_minimum_required(VERSION 3.10.0)
+
+ MACRO(PARSE_ARGUMENTS prefix arg_names option_names)
+ SET(DEFAULT_ARGS)
+diff --git a/cmake/Translations.cmake b/cmake/Translations.cmake
+index a16bcc3901..fbee765107 100644
+--- a/cmake/Translations.cmake
++++ b/cmake/Translations.cmake
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 3.0.0)
++cmake_minimum_required(VERSION 3.10.0)
+
+ set (XGETTEXT_OPTIONS --qt --keyword=tr:1,2c --keyword=tr --flag=tr:1:pass-c-format --flag=tr:1:pass-qt-format
+ --keyword=trUtf8 --flag=tr:1:pass-c-format --flag=tr:1:pass-qt-format
+diff --git a/gst/moodbar/CMakeLists.txt b/gst/moodbar/CMakeLists.txt
+index 0bb87e8844..dfe9bc9830 100644
+--- a/gst/moodbar/CMakeLists.txt
++++ b/gst/moodbar/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 3.0.0)
++cmake_minimum_required(VERSION 3.10.0)
+
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Woverloaded-virtual -Wall")
+diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
+index 81031b072e..b7ada3ae79 100644
+--- a/tests/CMakeLists.txt
++++ b/tests/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 3.0.0)
++cmake_minimum_required(VERSION 3.10.0)
+
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fpermissive -Wno-c++11-narrowing")
+
diff -Nru clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/series clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/series
--- clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/series 2025-01-22 23:06:35.000000000 +0100
+++ clementine-1.4.1+git27-g658f34ec4+dfsg/debian/patches/series 2025-09-28 14:11:12.000000000 +0200
@@ -7,3 +7,4 @@
fix_gcc14_ftbfs.patch
0008-Disable-HAVE_VISUALISATIONS-unconditionally.patch
0009-Try-to-fix-template-mismatch-within-taglib-2-tagread.patch
+FTBFS_with_CMake_4.patch
Attachment:
signature.asc
Description: PGP signature