[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#494254: marked as done (cdbs: please clean before unpatch (revert bug #387103))

Your message dated Sat, 08 Mar 2025 14:43:46 +0000
with message-id <E1tqvP0-007ExW-8e@fasolo.debian.org>
and subject line Bug#414305: fixed in cdbs 0.4.168
has caused the Debian Bug report #414305,
regarding cdbs: please clean before unpatch (revert bug #387103)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
414305: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=414305
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: cdbs
Version: 0.4.52
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch intrepid

Hi,

In cdbs 0.4.48, simple-patchsys.mk was changed to unapply patches before
cleaning the build directory, in response to bug #387103.  Objections were
raised at the time that this wasn't the right thing to do; that the correct
sequence was to unpatch after clean, but to skip the unpatch when using
tarball.mk.

Then in bug #424080, the package was changed so that tarball.mk *did* skip
the unpatching; but the unpatching is still being done before clean rather
than after.

This is simply wrong, because it means simple-patchsys.mk doesn't work
correctly when you have to patch the build system in a way that affects the
outcome of, e.g., 'make distclean'.

I believe the attached patch, to revert this behavior, is correct and should
be applied.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

=== modified file '1/rules/simple-patchsys.mk.in'
--- 1/rules/simple-patchsys.mk.in	2008-03-28 16:04:32 +0000
+++ 1/rules/simple-patchsys.mk.in	2008-08-08 01:19:14 +0000
@@ -59,7 +59,7 @@
 
 post-patches:: apply-patches
 
-cleanbuilddir:: reverse-patches
+clean:: reverse-patches
 	for dir in $(DEB_PATCHDIRS) ; do \
 	    rm -f $$dir/*.log ; \
 	done

=== modified file 'debian/changelog'
--- debian/changelog	2008-08-01 18:44:48 +0000
+++ debian/changelog	2008-08-08 01:19:14 +0000
@@ -1,5 +1,10 @@
 cdbs (0.4.53) UNRELEASED; urgency=low
 
+  * 1/rules/simple-patchsys.mk.in: revert the change for Debian bug #387103
+    that causes patches to be unapplied before cleaning the build directory;
+    the original issue was addressed more thoroughly in 0.4.49 with a fix
+    for Debian bug #424080, and unpatch-before-clean breaks some relevant
+    use cases that involve patching of build systems.
   * Relax python-central build-dependency to >= 0.5.6 in python-distutils
     class (instruction in python policy is only really needed for
     transition of python-central itself, which has now completed).

--- End Message ---
--- Begin Message --- 
Source: cdbs
Source-Version: 0.4.168
Done: Alexandre Detiste <tchet@debian.org>

We believe that the bug you reported is fixed in the latest version of
cdbs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 414305@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexandre Detiste <tchet@debian.org> (supplier of updated cdbs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 08 Mar 2025 14:48:42 +0100
Source: cdbs
Architecture: source
Version: 0.4.168
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Alexandre Detiste <tchet@debian.org>
Closes: 414305 508162 525869 554855
Changes:
 cdbs (0.4.168) unstable; urgency=medium
 .
   * QA upload.
   * Remove dpatch.mk, simple-patchsys.mk and tarball.mk
     that were deprecated since 2010 and have no user left.
   * Also remove related utility cdbs-edit-patch.
     Closes: #414305, #554855, #508162, #525869
Checksums-Sha1:
 f0fa1a8f8e9d0aa713ac0e58b58465ba7c954987 1723 cdbs_0.4.168.dsc
 28c24e44ff6a094be53936087743c470eb5dda39 189020 cdbs_0.4.168.tar.xz
 6e48c81ec5a536bfdaff7168c1ba7166086e6556 4562 cdbs_0.4.168_source.buildinfo
Checksums-Sha256:
 0787f4b79ec0932cd4b293e4eddc75e2dd8343796c4c22753be309839771461a 1723 cdbs_0.4.168.dsc
 93c7d530b4130265efdd136a4c3d29294b8c660d14de0537d8a0b9a26e0b4a46 189020 cdbs_0.4.168.tar.xz
 998143e1aa260fc0d853e817416b070203210bbd280e5df1c31f2068fb4d91ba 4562 cdbs_0.4.168_source.buildinfo
Files:
 219dc7f13d90ef5f57320f184a44afc9 1723 devel optional cdbs_0.4.168.dsc
 005f57d6f06144f2e4a860f4c258aa9f 189020 devel optional cdbs_0.4.168.tar.xz
 227ab640a027393cf1e39e14482741c9 4562 devel optional cdbs_0.4.168_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmfMTgcRHHRjaGV0QGRl
Ymlhbi5vcmcACgkQMfMURUShdBrAig//XQbZHyyotlMRLtu/sFJCjkl1ZNib+qyo
mkYM9QEmfxkDO9GF2+amUgDtreACE7cPC+Pw+h11v5OVxu96tIS4phKerttKVn1D
BbHHZRQeYU2cFmCqyivRHnKGdLBYG9rrpIkTDnbbGCvPeDIm474tNmf58T9+bGHr
Azd/FND1cZAM8/2a5AFH07m1c4iQMopnDaNZljMfyW9btyr0O6h+lbtUC+bkcnW5
08xgKKu9htGJXCLW1geV9b0eLj8Tzey5/ueGyAZRQlbm+Qv/JeuklkVGH4EkN4WS
xtcRHztHVj/vD0UjRB/uWfPtAWc2KP9u3FM1HhnTWSjLx0TmzbZDkJPGWynRdBNe
ZCu8JoEx8q/ZajP6ScFvS2CRROgRP+Fb69dLWtgt1JOy/vd7LIqsBJEXBUGRGw3E
Flou2BXQi6TRBBan/ku5D9aGumYQCyDOuUkLOBMypBIaxAhQw756eSD05ouYQswj
Q1pcdb/hWhaDEs/VvmO4TB9dXAEX13DmDBvCuWDDhInC0rJVbGlAsIESveGJ88RN
u6tdlzI2ZSb1qOHDJk57xWzGwHbaPGxQruE7FKf2MFPJJoAzp3x+udONZkVyiaxo
niLo7JZcUTv/DtZNotOV+ZeiTnAjM9ekg2joD8D91Sfja1AuWWDUwXhmeHHTQBcq
HynSNymlz0E=
=gqap
-----END PGP SIGNATURE-----

Attachment: pgpATIFC64eLb.pgp
Description: PGP signature


--- End Message ---
Reply to: