[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1083059: marked as done (hfsplus: FTBFS with gcc-14)

Your message dated Wed, 19 Feb 2025 00:19:13 +0000
with message-id <E1tkXo1-007ICc-KI@fasolo.debian.org>
and subject line Bug#1083059: fixed in hfsplus 1.0.4-19
has caused the Debian Bug report #1083059,
regarding hfsplus: FTBFS with gcc-14
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1083059: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083059
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: hfsplus
Version: 1.0.4-17.1ubuntu1
Severity: normal
Tags: ftbfs
X-Debbugs-Cc: daniel.bungert@canonical.com
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu oracular

Dear Maintainer,

This bug report was also filed in Ubuntu and can be found at
https://launchpad.net/bugs/2083086

hfsplus is FTBFS with gcc-14 on presumably all BIG_ENDIAN arches.
https://launchpadlibrarian.net/749243763/buildlog_ubuntu-oracular-s390x.hfsplus_1.0.4-17.1build1_BUILDING.txt.gz

I have only observed this on s390x on Ubuntu and assume it would also apply to
Debian.

In file included from partitions.c:29:
partitions.c: In function ‘partition_fillstruct’:
swab.h:51:51: error: assignment to ‘char *’ from incompatible pointer type
‘UInt16 *’ {aka ‘short unsigned int *’} [-Wincompatible-pointer-types]
   51 | #define bswabU16_inc(ptr) *((UInt16*) (ptr)); ptr = (UInt16*)ptr + 1
      |                                                   ^
partitions.c:59:23: note: in expansion of macro ‘bswabU16_inc’
   59 |   p->pmSig          = bswabU16_inc( buf);
      |                       ^~~~~~~~~~~~

this continues for all the bswabUXX_inc in partition_fillstruct.

I addressed this for Ubuntu (mostly) as follows:

--- a/libhfsp/src/swab.h
+++ b/libhfsp/src/swab.h
@@ -48,25 +48,25 @@
 
 #define bswabU16(val) val
 
-#define bswabU16_inc(ptr) *((UInt16*) (ptr)); ptr = (UInt16*)ptr + 1
+#define bswabU16_inc(ptr) *((UInt16*) (ptr)); ptr = (void *)((UInt16*)ptr + 1)
 /* Only available as a GCC extension, but required on sparc due to
    alignment issues in some of the on-disk structs */
 #if defined(__GNUC__) && defined(__sparc__)
 #define bswabU32_inc(ptr) ({			\
 	unsigned char *c = (char*)ptr;		\
-	ptr = ((UInt32 *)ptr) + 1;		\
+	ptr = (void *)(((UInt32 *)ptr) + 1);	\
 	((c[0] << 24)+(c[1] << 16)+(c[2] << 8)+c[3]);})
 #define bswabU64_inc(ptr) ({			\
 	unsigned char *c = (char*)ptr;		\
 	UInt64 val = 0;				\
 	int i = 0;				\
-	ptr = ((UInt64 *)ptr) + 1;		\
+	ptr = (void *)(((UInt64 *)ptr) + 1);	\
 	while (i < 8)				\
 		val += (c[i] << (8*(7-i++)));	\
 	val;})
 #else
-#define bswabU32_inc(ptr) *((UInt32*) (ptr)); ptr = (UInt32*)ptr + 1
-#define bswabU64_inc(ptr) *((UInt64*) (ptr)); ptr = (UInt64*)ptr + 1
+#define bswabU32_inc(ptr) *((UInt32*) (ptr)); ptr = (void *)((UInt32*)ptr + 1)
+#define bswabU64_inc(ptr) *((UInt64*) (ptr)); ptr = (void *)((UInt64*)ptr + 1)
 #endif
 
 #define bstoreU16_inc(ptr, val) *((UInt16*) (ptr)) = val; ptr = (void*)((UInt16*)ptr + 1)

The Ubuntu version I uploaded is different because of a flaw on the
defined(__sparc__) path that Ubuntu won't use, I expect the above is corret.

-Dan

--- End Message ---
--- Begin Message --- 
Source: hfsplus
Source-Version: 1.0.4-19
Done: Hilko Bengen <bengen@debian.org>

We believe that the bug you reported is fixed in the latest version of
hfsplus, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1083059@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hilko Bengen <bengen@debian.org> (supplier of updated hfsplus package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 18 Feb 2025 23:18:32 +0100
Source: hfsplus
Architecture: source
Version: 1.0.4-19
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Hilko Bengen <bengen@debian.org>
Closes: 1083059
Changes:
 hfsplus (1.0.4-19) unstable; urgency=medium
 .
   * QA upload.
   * Fix FTBFS on s390x et al with gcc-14.
     Thanks to Dan Bungert (Closes: #1083059)
Checksums-Sha1:
 2bc6fcd23858db92658dce88fee0e08f53cbf80c 1956 hfsplus_1.0.4-19.dsc
 b1c0b256a7ab5b21ac20a844c7be69fa91596192 20884 hfsplus_1.0.4-19.debian.tar.xz
 deb867c8a0d3adfdb47bf2e670c75494e42c2da2 6796 hfsplus_1.0.4-19_source.buildinfo
Checksums-Sha256:
 2a7c1afd7d6295ac0c94e4d594b0c4ab3f11f7e84109339bb3bdcd2f08636039 1956 hfsplus_1.0.4-19.dsc
 a637cf6aadc4562b6a058c8bcc860b53d8da6d89a3a0094e7a04d4958c5e6270 20884 hfsplus_1.0.4-19.debian.tar.xz
 74aaf592d638463f7c4b83eaae8737a36ec139f547b0217e84c9baf54f22b1c8 6796 hfsplus_1.0.4-19_source.buildinfo
Files:
 88c629adfd443f7c2555ca1cde0add42 1956 otherosfs optional hfsplus_1.0.4-19.dsc
 8ac939842957763bb98bf06b57bf09d7 20884 otherosfs optional hfsplus_1.0.4-19.debian.tar.xz
 4e3f72713fe3c9d97ece45691526f0fa 6796 otherosfs optional hfsplus_1.0.4-19_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEErnMQVUQqHZbPTUx4dbcQY1whOn4FAme1B1IACgkQdbcQY1wh
On7Lvg/9FzKl4hS64BVNjTKlaDlH8xi1xYjn6YSuEAc9m5Zpq4mM1IaYfD1EBDyC
zavPxJl6g6v6Vmwm6ScRab6GprzIO1lFSWdM82dhIqoVsn1CtKmFzbT9U30zvUHW
itnWGji/hhWf/9yCVyNjwTVyLPiUKTa7JAgeA/eJeF4rFbW7+1nlwys7RB/qIIcI
eIsr6zDVo5zDm0MJGPPxpbf6B4UVtFSd4WDt1spgHW0c+Dkg6z/k22iDMrfoGcdx
IsjrNN/8HrlPPIuhqnZSPsplIuU4G1ywUsZnlXpDWVX/0HqaxCub8f0l8atOmda9
W4AOhPPmdx3YlmnFRoryYA0c4dYzU45ItfuUwxm4bEZ+fJOkxcIw/0V6GG+D5Aw9
gRM3V7oRf8S+Dt2hC4Vanzug/5FioaVXQNbNaSGQo77yLSF6dslg/0NpBBWANR+y
3BdTp1/Oj4zkqhBN6hi/iHtakFdzDMczPQavwOa7Jm1+MdJzBQkzmAnHnff5vRiq
BnrkCBwI6XiAtx+2kteslnf1tAIShsD6lL9gM5Lvprempwzxy2NNu3FT/g991liZ
lrEul1Fo5d0jbbWzDxwZPsEanEgVMkwr2EQNPOxOM2Sgd66B9avCH5ld/Cr1XnAu
5/7ncbLUMY2zJyuUECBJC/TqMvvXu0ppGtNwTloNNnFgiIL99vg=
=zxaH
-----END PGP SIGNATURE-----

Attachment: pgp4MscV1SJPs.pgp
Description: PGP signature


--- End Message ---
Reply to: