Bug#1096803: hercules: ftbfs with GCC-15
Package: src:hercules
Version: 3.13-8
Severity: important
Tags: sid forky
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-15
[This bug is NOT targeted to the upcoming trixie release]
Please keep this issue open in the bug tracker for the package it
was filed for. If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.
The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.
The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/hercules_3.13-8_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.
To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.
apt-get -t=experimental install g++
GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html
[...]
| ^~~~~~~~~~~~~~~~~~~
| |
| void * (*)(void *)
impl.c:617:5: note: in expansion of macro 'create_thread'
617 | create_thread(&rctid,DETACHED,
| ^~~~~~~~~~~~~
pttrace.h:61:54: note: expected 'void * (*)(void)' but argument is of type 'void * (*)(void *)'
61 | PTT_DLL_IMPORT int ptt_pthread_create(TID *, ATTR *, void *(*)(), void *, char *, char *);
| ^~~~~~~~~~~
hthreads.h:157:37: error: passing argument 3 of 'ptt_pthread_create' from incompatible pointer type [-Wincompatible-pointer-types]
157 | ptt_pthread_create(ptid,pat,(THREAD_FUNC*)&(fn),arg,(nm),PTT_LOC)
| ^~~~~~~~~~~~~~~~~~~
| |
| void * (*)(void *)
impl.c:624:9: note: in expansion of macro 'create_thread'
624 | create_thread(&logcbtid,DETACHED,
| ^~~~~~~~~~~~~
pttrace.h:61:54: note: expected 'void * (*)(void)' but argument is of type 'void * (*)(void *)'
61 | PTT_DLL_IMPORT int ptt_pthread_create(TID *, ATTR *, void *(*)(), void *, char *, char *);
| ^~~~~~~~~~~
make[4]: *** [Makefile:1960: impl.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I. -I./decNumber -I./softfloat -Wdate-time -D_FORTIFY_SOURCE=2 -DPKGDATADIR=\"/usr/share/hercules\" -DMODULESDIR=\"/usr/lib/hercules\" -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/hercules-3.13=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -W -Wall -Wno-unused-but-set-variable -Werror=declaration-after-statement -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/hercules-3.13=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c history.c -fPIC -DPIC -o .libs/history.o
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I. -I./decNumber -I./softfloat -Wdate-time -D_FORTIFY_SOURCE=2 -DPKGDATADIR=\"/usr/share/hercules\" -DMODULESDIR=\"/usr/lib/hercules\" -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/hercules-3.13=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -W -Wall -Wno-unused-but-set-variable -Werror=declaration-after-statement -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/hercules-3.13=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c fillfnam.c -fPIC -DPIC -o .libs/fillfnam.o
In file included from hercules.h:87,
from config.c:13:
config.c: In function 'configure_cpu':
hthreads.h:157:37: error: passing argument 3 of 'ptt_pthread_create' from incompatible pointer type [-Wincompatible-pointer-types]
157 | ptt_pthread_create(ptid,pat,(THREAD_FUNC*)&(fn),arg,(nm),PTT_LOC)
| ^~~~~~~~~~~~~~~~~~~
| |
| void * (*)(void *)
config.c:87:10: note: in expansion of macro 'create_thread'
87 | if ( create_thread (&sysblk.cputid[cpu], DETACHED, cpu_thread,
| ^~~~~~~~~~~~~
In file included from hthreads.h:118:
pttrace.h:61:54: note: expected 'void * (*)(void)' but argument is of type 'void * (*)(void *)'
61 | PTT_DLL_IMPORT int ptt_pthread_create(TID *, ATTR *, void *(*)(), void *, char *, char *);
| ^~~~~~~~~~~
bldcfg.c: In function 'parse_args':
bldcfg.c:127:9: warning: this 'while' clause does not guard... [-Wmisleading-indentation]
127 | while (*p && isspace(*p)) p++; if (!*p) break; // find start of arg
| ^~~~~
bldcfg.c:127:40: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'while'
127 | while (*p && isspace(*p)) p++; if (!*p) break; // find start of arg
| ^~
bldcfg.c:133:9: warning: this 'while' clause does not guard... [-Wmisleading-indentation]
133 | while (*p && !isspace(*p) && *p != '\"' && *p != '\'') p++; if (!*p) break; // find end of arg
| ^~~~~
bldcfg.c:133:69: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'while'
133 | while (*p && !isspace(*p) && *p != '\"' && *p != '\'') p++; if (!*p) break; // find end of arg
| ^~
make[4]: *** [Makefile:1960: config.lo] Error 1
fillfnam.c: In function 'tab_pressed':
fillfnam.c:108:5: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-truncation]
108 | strncpy(path, part2, strlen(part2)-strlen(filename));
| ^
fillfnam.c:108:26: note: length computed here
108 | strncpy(path, part2, strlen(part2)-strlen(filename));
| ^~~~~~~~~~~~~
make[4]: Leaving directory '/build/reproducible-path/hercules-3.13'
make[3]: *** [Makefile:1978: all-recursive] Error 1
make[3]: Leaving directory '/build/reproducible-path/hercules-3.13'
make[2]: *** [Makefile:1470: all] Error 2
make[2]: Leaving directory '/build/reproducible-path/hercules-3.13'
dh_auto_build: error: make -j8 modexecdir=/usr/lib/hercules returned exit code 2
make[1]: *** [debian/rules:34: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/hercules-3.13'
make: *** [debian/rules:4: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
Reply to: