[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#870166: marked as done (multistrap: Fails if more than one section with the same keyring)

Your message dated Fri, 24 Jan 2025 16:20:10 +0000
with message-id <[🔎] E1tbMPi-000wOS-UL@fasolo.debian.org>
and subject line Bug#1093962: Removed package(s) from unstable
has caused the Debian Bug report #870166,
regarding multistrap: Fails if more than one section with the same keyring
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
870166: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870166
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: multistrap
Version: 2.2.9
Severity: normal
Tags: patch

Steps to reproduce:

Create a config file where multiple sections have the same keyring entry
with the same keyring package name. The result will be that one of the
earlier loop iterations removes the package name that is used in later
iterations. The solution is to only iterate over unique package names:

diff --git a/multistrap b/usr/sbin/multistrap
index d7955cd..a3dfe62 100755
--- a/multistrap
+++ b/usr/sbin/multistrap
@@ -267,7 +267,9 @@ foreach my $aptsrc (@debootstrap) {
        }
 }
 my $k;
-foreach my $pkg (values %keyrings) {
+my @unique_keyrings = values %keyrings;
+uniq_sort(\@unique_keyrings);
+foreach my $pkg (@unique_keyrings) {
        next if (not defined $pkg);
        next if ("" eq "$pkg");
        $k .= "$pkg ";
@@ -275,7 +277,7 @@ foreach my $pkg (values %keyrings) {
 if ((defined $k) and (not defined $noauth)) {
        printf (_g("I: Downloading %s\n"), $k);
        system ("apt-get -y download $k");
-       foreach my $keyring_pkg (values %keyrings) {
+       foreach my $keyring_pkg (@unique_keyrings) {
                next if (not defined $keyring_pkg);
                my @files=();
                my $file = `find ./ -name "${keyring_pkg}_*_all.deb"|grep -m1 $keyring_pkg`;
@@ -377,7 +379,7 @@ foreach my $sect (sort keys %packages) {
        }
 }
 chomp($str);
-foreach my $keystr (values %keyrings) {
+foreach my $keystr (@unique_keyrings) {
        next if (not defined $keystr);
        $str .= " " . $keystr . " ";
 }

--- End Message ---
--- Begin Message --- 
Version: 2.2.11+rm

Dear submitter,

as the package multistrap has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1093962

The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Paul Tagliamonte (the ftpmaster behind the curtain)

--- End Message ---
Reply to: