Your message dated Sun, 14 Apr 2024 22:20:01 +0000 with message-id <E1rw8Cf-001Ara-9V@fasolo.debian.org> and subject line Bug#1066221: fixed in citadel-client 916-5 has caused the Debian Bug report #1066221, regarding citadel-client: FTBFS: src/routines2.c:370:29: error: implicit declaration of function ‘ka_wait’ [-Werror=implicit-function-declaration] to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 1066221: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066221 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: citadel-client: FTBFS: src/routines2.c:370:29: error: implicit declaration of function ‘ka_wait’ [-Werror=implicit-function-declaration]
- From: Lucas Nussbaum <lucas@debian.org>
- Date: Wed, 13 Mar 2024 12:48:30 +0100
- Message-id: <ZfGSjlMBhTm4PedV@grub.nussbaum.fr>
Source: citadel-client Version: 916-4 Severity: serious Justification: FTBFS Tags: trixie sid ftbfs User: lucas@debian.org Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef Hi, During a rebuild of all packages in sid, your package failed to build on amd64. This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration Relevant part (hopefully): > make[1]: Entering directory '/<<PKGBUILDDIR>>' > > CC src/citadel.c > Dependencies: gcc -M -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I ./src/include/ | sed -e 's!.o!.o /.o buildinfo!' > buildinfo > Complie: gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -Wno-strict-aliasing -D_REENTRANT -pthread -I ./include/ -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I ./src/include/ -DHAVE_CONFIG_H -DDIFF="/usr/bin/diff" -DPATCH="/usr/bin/patch" -c -o buildinfo > LDFLAGS: -Wl,-z,relro -Wl,-z,now > CC src/client_chat.c > CC src/client_passwords.c > CC src/commands.c > CC src/md5.c > > CC src/messages.c > CC src/rooms.c > CC src/routines.c > src/md5.c: In function ‘MD5Final’: > src/md5.c:153:26: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess] > 153 | memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */ > | ^ > src/commands.c: In function ‘getcmd’: > src/commands.c:1051:72: warning: the comparison will always evaluate as ‘true’ for the address of ‘c_keys’ will never be NULL [-Waddress] > 1051 | if ((cptr->c_keys[cmdpos + 1]) != 0) > | ^~ > src/commands.c:71:14: note: ‘c_keys’ declared here > 71 | char c_keys[5][64]; > | ^~~~~~ > src/messages.c: In function ‘read_message’: > src/messages.c:624:29: warning: the comparison will always evaluate as ‘true’ for the address of ‘email’ will never be NULL [-Waddress] > 624 | if ((message->email != NULL) && (!IsEmptyStr(message->email))) { > | ^~ > In file included from src/messages.c:46: > ./src/include/citadel_ipc.h:241:14: note: ‘email’ declared here > 241 | char email[SIZ]; /* Email address of sender */ > | ^~~~~ > src/messages.c:640:28: warning: the comparison will always evaluate as ‘true’ for the address of ‘msgid’ will never be NULL [-Waddress] > 640 | if (message->msgid != NULL) { > | ^~ > ./src/include/citadel_ipc.h:237:14: note: ‘msgid’ declared here > 237 | char msgid[SIZ]; /* Original message ID */ > | ^~~~~ > src/messages.c:644:33: warning: the comparison will always evaluate as ‘true’ for the address of ‘references’ will never be NULL [-Waddress] > 644 | if (message->references != NULL) if (!IsEmptyStr(message->references)) { > | ^~ > ./src/include/citadel_ipc.h:255:14: note: ‘references’ declared here > 255 | char references[SIZ]; /* Thread references */ > | ^~~~~~~~~~ > src/messages.c:648:30: warning: the comparison will always evaluate as ‘true’ for the address of ‘subject’ will never be NULL [-Waddress] > 648 | if (message->subject != NULL) { > | ^~ > ./src/include/citadel_ipc.h:240:14: note: ‘subject’ declared here > 240 | char subject[SIZ]; /* Message subject */ > | ^~~~~~~ > src/routines.c: In function ‘locate_host’: > src/routines.c:573:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result] > 573 | fgets(hbuf, SIZ, who); > | ^~~~~~~~~~~~~~~~~~~~~ > CC src/routines2.c > src/client_chat.c: In function ‘chatmode’: > src/client_chat.c:189:72: warning: ‘%s’ directive output may be truncated writing up to 4095 bytes into a region of size 4094 [-Wformat-truncation=] > 189 | snprintf(buf, sizeof buf, "%s: %s", c_user, c_text); > | ^~ ~~~~~~ > In file included from /usr/include/stdio.h:906, > from src/client_chat.c:18: > In function ‘snprintf’, > inlined from ‘chatmode’ at src/client_chat.c:189:6: > /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output 3 or more bytes (assuming 4098) into a destination of size 4096 > 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 55 | __glibc_objsize (__s), __fmt, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 56 | __va_arg_pack ()); > | ~~~~~~~~~~~~~~~~~ > In file included from /usr/include/string.h:535, > from src/client_chat.c:21: > In function ‘strcpy’, > inlined from ‘chatmode’ at src/client_chat.c:167:5: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:79:10: warning: ‘__builtin___strcpy_chk’ accessing 1 byte at offsets 0 and [0, 4096] may overlap 1 byte at offset 0 [-Wrestrict] > 79 | return __builtin___strcpy_chk (__dest, __src, __glibc_objsize (__dest)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > src/client_chat.c: In function ‘page_user’: > src/client_chat.c:228:52: warning: ‘%s’ directive output may be truncated writing up to 4095 bytes into a region of size 4090 [-Wformat-truncation=] > 228 | snprintf(buf, sizeof buf, "SEXP %s|%s", touser, msg); > | ^~ ~~~ > In function ‘snprintf’, > inlined from ‘page_user’ at src/client_chat.c:228:3: > /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output 7 or more bytes (assuming 4102) into a destination of size 4096 > 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 55 | __glibc_objsize (__s), __fmt, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 56 | __va_arg_pack ()); > | ~~~~~~~~~~~~~~~~~ > CC src/tuiconfig.c > src/routines2.c: In function ‘upload’: > src/routines2.c:370:29: error: implicit declaration of function ‘ka_wait’ [-Werror=implicit-function-declaration] > 370 | b = ka_wait(&a); > | ^~~~~~~ > In file included from /usr/include/string.h:535, > from src/commands.c:22: > In function ‘strcpy’, > inlined from ‘load_command_set’ at src/commands.c:810:4: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:79:10: warning: ‘__builtin___strcpy_chk’ accessing between 1 and 1024 bytes at offsets 0 and [0, 1024] may overlap up to 1024 bytes at offset [0, 1023] [-Wrestrict] > 79 | return __builtin___strcpy_chk (__dest, __src, __glibc_objsize (__dest)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In function ‘strcpy’, > inlined from ‘load_command_set’ at src/commands.c:816:4: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:79:10: warning: ‘__builtin___strcpy_chk’ accessing between 1 and 1024 bytes at offsets 0 and [0, 1024] may overlap up to 1024 bytes at offset [0, 1023] [-Wrestrict] > 79 | return __builtin___strcpy_chk (__dest, __src, __glibc_objsize (__dest)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In function ‘strcpy’, > inlined from ‘load_command_set’ at src/commands.c:832:6: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:79:10: warning: ‘__builtin___strcpy_chk’ accessing between 1 and 1024 bytes at offsets 0 and [0, 1024] may overlap up to 1024 bytes at offset [0, 1023] [-Wrestrict] > 79 | return __builtin___strcpy_chk (__dest, __src, __glibc_objsize (__dest)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > CC src/screen.c > CC src/ecrash.c > CC src/citadel_ipc.c > CC src/ipc_c_tcp.c > src/messages.c:626:64: warning: ‘ <’ directive output may be truncated writing 2 bytes into a region of size between 1 and 4096 [-Wformat-truncation=] > 626 | snprintf(reply_to, sizeof reply_to, "%s <%s>", message->author, message->email); > | ^~ > In file included from /usr/include/stdio.h:906, > from src/messages.c:20: > In function ‘snprintf’, > inlined from ‘read_message’ at src/messages.c:626:4: > /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output between 4 and 8194 bytes into a destination of size 4096 > 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 55 | __glibc_objsize (__s), __fmt, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 56 | __va_arg_pack ()); > | ~~~~~~~~~~~~~~~~~ > src/messages.c: In function ‘read_message’: > src/messages.c:636:57: warning: ‘ @ ’ directive output may be truncated writing 3 bytes into a region of size between 1 and 4096 [-Wformat-truncation=] > 636 | snprintf(reply_to, sizeof(reply_to), "%s @ %s", > | ^~~ > In function ‘snprintf’, > inlined from ‘read_message’ at src/messages.c:636:3: > /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output between 4 and 8194 bytes into a destination of size 4096 > 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 55 | __glibc_objsize (__s), __fmt, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 56 | __va_arg_pack ()); > | ~~~~~~~~~~~~~~~~~ > src/citadel_ipc.c: In function ‘CtdlIPCPostMessage’: > src/citadel_ipc.c:1040:13: warning: the comparison will always evaluate as ‘true’ for the address of ‘references’ will never be NULL [-Waddress] > 1040 | if (mr->references) { > | ^~ > In file included from src/citadel_ipc.c:43: > ./src/include/citadel_ipc.h:255:14: note: ‘references’ declared here > 255 | char references[SIZ]; /* Thread references */ > | ^~~~~~~~~~ > cc1: some warnings being treated as errors > make[1]: *** [Makefile:121: src/routines2.o] Error 1 The full build log is available from: http://qa-logs.debian.net/2024/03/13/citadel-client_916-4_unstable.log All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.
--- End Message ---
--- Begin Message ---
- To: 1066221-close@bugs.debian.org
- Subject: Bug#1066221: fixed in citadel-client 916-5
- From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
- Date: Sun, 14 Apr 2024 22:20:01 +0000
- Message-id: <E1rw8Cf-001Ara-9V@fasolo.debian.org>
- Reply-to: Andreas Beckmann <anbe@debian.org>
Source: citadel-client Source-Version: 916-5 Done: Andreas Beckmann <anbe@debian.org> We believe that the bug you reported is fixed in the latest version of citadel-client, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1066221@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Andreas Beckmann <anbe@debian.org> (supplier of updated citadel-client package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 15 Apr 2024 00:00:17 +0200 Source: citadel-client Architecture: source Version: 916-5 Distribution: unstable Urgency: medium Maintainer: Debian QA Group <packages@qa.debian.org> Changed-By: Andreas Beckmann <anbe@debian.org> Closes: 1066221 Changes: citadel-client (916-5) unstable; urgency=medium . * QA upload. * Fix building with -Werror=implicit-function-declaration. (Closes: #1066221) * The bullseye toolchain defaults to linking with --as-needed. * Declare Rules-Requires-Root: no. * Try to avoid blhc confusion detecting "nonverbose build". Checksums-Sha1: 1c1a95984fe12dfc2c2baaa79b58e9866e155ed3 1964 citadel-client_916-5.dsc e210738b47120f7384b8a0531e5584af3c479562 6232 citadel-client_916-5.debian.tar.xz 3008ce8ce6a06c7c51381d2348080a51bf365e01 5982 citadel-client_916-5_source.buildinfo Checksums-Sha256: 1aa994199328abf1f5ff0f5ed895041b341d6ac5038b2b9789a578a2ef859770 1964 citadel-client_916-5.dsc 4d7b81b40d68eee90f3cf8d62142bd32976f55f1827560ccd37c5adc433787bf 6232 citadel-client_916-5.debian.tar.xz dcf37484d17e40091b2baf36a4e19d60cf747d6224f80813c3b8e4f444a0ec0d 5982 citadel-client_916-5_source.buildinfo Files: 4df932b617c5adee63d5982e7be028da 1964 mail optional citadel-client_916-5.dsc 3dbb5e7df844f0a75e2265a3a15936aa 6232 mail optional citadel-client_916-5.debian.tar.xz c3aeebb0666c16c003c8e97006c1ae5a 5982 mail optional citadel-client_916-5_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmYcUxEQHGFuYmVAZGVi aWFuLm9yZwAKCRBfsz+TWentCJkTD/sGlTU1V+CCwCVd5Q6qBtZJRmmcwvjtSpfR MUixd2cppmzcZwr9gfnl0CgpVMBpa+oiQ0ulhDLv96quO3A1czrDEFgTuU4+bKOw aZbNnYg1lt7hXb8zDBZhuDzwNgsrY//xduGkiRQ5wxkK/TIMCOPK+/RK1pi1WeFr LlnN9YktgwXiylUgZ0xJ1VfQE/ZB3p0MWgUGQeqH5zmYW+29IWpm8Y4zEj/I7C6k /nZdEpTthFcrbYnUyEhj5ePilcPG8NPzbv2QIBY7kYxwtN9MBGUXapKKGM1yh6Xf jFy1M2dpQCyT3jNE5ctzEwuYoyVo7frXtz2jqkzBO7sP9/XmcS9116bM5oLyIbMw wx8UTKUR0Z+x6l5tvon1DF5dkTNkU88aRpxDP+eHSj1t/sPqVs+kkzpMu5Q0H9ar mPiSa81jKOHDtwENH72B1cNZXNaRHdFaMw9vI9nUNAJZF4Fjb7fCYQyYqJCLX3v6 DnupVVsjLvLimadMeOx7HaNLxeqI4N3ulb4rVzpRdQ0pYGAk8LNqTJ7Yj7AFp/h7 ROZtbVd5PVmhkNUamIyeAWkQRn6Dki2mqzebW3n4vZi4IxJ/eHQY9Zgy7+4Yagx7 LakcJ5+OQSKNM3mdflqw/9GeSwX879uNVvkDeY/G2wuIb2B4+cMeQJzSgyav2NLd ayokVD9WuA== =RsWI -----END PGP SIGNATURE-----Attachment: pgpuTDf39U3GW.pgp
Description: PGP signature
--- End Message ---