[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1003064: marked as done (xshisen: cannot show the personal score)

Your message dated Thu, 04 Apr 2024 17:20:57 +0000
with message-id <E1rsQll-00AkJ3-6t@fasolo.debian.org>
and subject line Bug#1003064: fixed in xshisen 1:1.51-8
has caused the Debian Bug report #1003064,
regarding xshisen: cannot show the personal score
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1003064: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003064
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xshisen
Version: 1:1.51-7
Severity: normal
Tags: patch

Dear Maintainer,

xshisen (amd64) crashes when trying to show the personal score.


How to repeat
-------------

(1) If you have no ~/.xshisen.scores file, play the game once.
(2) Select Menu: Game -> Personal Score
    or
    hit Ctrl-t.


Analysis
--------

It crashes in Score::PersonalStat(int) by segmentation fault.

>From the build log
>score.C: In member function ‘int Score::PersonalStat(int)’:
>score.C:622:1: warning: control reaches end of non-void function [-Wreturn-type]
>  622 | }
>      | ^


According to the GCC manual, this causes undefined behavior.
So it may crash.

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
> -Wreturn-type
(snip)
> Unlike in C, in C++, flowing off the end of a non-void function other than
> main results in undefined behavior even when the value of the function is
> not used.


How to fix
----------

Inserting "return 0;" at the end of this function fixes this problem.

----- Begin
--- xshisen-1.51.orig/score.C
+++ xshisen-1.51/score.C
@@ -619,6 +619,7 @@ Score::PersonalStat(int kind_of_game)
     bufp += strlen(bufp);
     *bufp = '\0';
     Popup(buf);
+    return 0;
 }

 int
----- End


Regards,
Nobuhiro Ban



-- System Information:
Debian Release: bookworm/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'stable-security'), (500,
'stable-debug'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.15.0-2-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages xshisen depends on:
ii  libc6       2.33-1
ii  libgcc-s1   11.2.0-13
ii  libstdc++6  11.2.0-13
ii  libx11-6    2:1.7.2-2+b1
ii  libxm4      2.3.8-3
ii  libxpm4     1:3.5.12-1
ii  libxt6      1:1.2.0-1

xshisen recommends no packages.

xshisen suggests no packages.

-- debconf-show failed

--- End Message ---
--- Begin Message --- 
Source: xshisen
Source-Version: 1:1.51-8
Done: Andreas Beckmann <anbe@debian.org>

We believe that the bug you reported is fixed in the latest version of
xshisen, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1003064@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <anbe@debian.org> (supplier of updated xshisen package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 04 Apr 2024 19:01:55 +0200
Source: xshisen
Architecture: source
Version: 1:1.51-8
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Beckmann <anbe@debian.org>
Closes: 1003064 1066426
Changes:
 xshisen (1:1.51-8) unstable; urgency=medium
 .
   * QA upload.
   * Fix building with -Werror=implicit-function-declaration.
     (Closes: #1066426)
   * Fix crash while showing the personal score, thanks to Nobuhiro Ban.
     (Closes: #1003064)
   * Declare Rules-Requires-Root: no.
Checksums-Sha1:
 c7fed955fc643d6177e60dac557144e1b63e9927 1824 xshisen_1.51-8.dsc
 baae92548822b3d57d6d2949e646ea1e29f09114 12168 xshisen_1.51-8.debian.tar.xz
 f6735ab07d551ed3eae78032fb7c373d78a0f251 7409 xshisen_1.51-8_source.buildinfo
Checksums-Sha256:
 1ad786de02c2ee743d7c601564d00590448ead18ea333ad12451bdb5d7182816 1824 xshisen_1.51-8.dsc
 32ca6c7843fd2e37256d53c972fecdd02ec571629cc7823223dc24fe3a65ae34 12168 xshisen_1.51-8.debian.tar.xz
 815f8a93a4c6df0448201cabc500c961f073a54794c99d48c454e60d141082fd 7409 xshisen_1.51-8_source.buildinfo
Files:
 ebe7663340d4bc13cc86706e279a4299 1824 games optional xshisen_1.51-8.dsc
 c8244ea2bf5572d424e46183cb2b50e6 12168 games optional xshisen_1.51-8.debian.tar.xz
 29a10c317a27a150ce9e57294cc503fb 7409 games optional xshisen_1.51-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmYO3UgQHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCKISEACb8ujiI60O6Uoc9aXN/AVfQPg56e+SnMRj
Nbgu+CwnVGk7NnuKZlP+iK+/kempneIh1ODIUgHkWZBplbr51uH8xBCuHQ1kPQUV
QZBjnRbd4dpJYVDxOd/JmJaeE6Wczn0kjq/adHQWA+oCmG7tNCxzYSp4t4d5iIL5
HJhZ++IJ6FESWW8IUkp8Dex2lMfqQkLdLghvO9C7P0QrNsvKL4xg+2AIBFvv62UV
AzW1PwOkFJXR3a4L9NeipfAnJQGzO5hjYmPVezl9cG08SFJof8BP5cwwiR0W/u1V
B3KyT2uGWJ60isJm3K40KCDmndsS5CwtI8Pf6FLAgcimiP9q4NyWy7eenC8UW/tj
YrE2iju8IPbN6oORdHRK4mJaUqZvQ/JIf5tJwuHHpl/25wtCwygGrSl7kyDG3FUh
PD6aXB5qhe+6TpFob2LTjP5OwCiilxgJShlU49tjrXBPDg3ZGDNnSESYS54LSMdE
wpvordvx9CQXb7gE4/zAWEd3xYNG9diigNwnR8EsWST+IzCfSnZDB3b1sEfQNNM1
rfdORCsUg++3z1a1s/q03K/rcFTISVZ0weqtFjiRMLS1WYFEPVKSzNfUpEQP2LJS
QhwpJYMDMuaYan9PH9ULShdH4dJy8qkr1wni3YdCLjB2do3n5w77XEIf+Pk2nsHo
qx1C7I0aEQ==
=r4PE
-----END PGP SIGNATURE-----

Attachment: pgpWXbfV8GvoJ.pgp
Description: PGP signature


--- End Message ---
Reply to: