Your message dated Tue, 10 Sep 2024 19:34:17 +0000 with message-id <E1so6cz-003FMz-06@fasolo.debian.org> and subject line Bug#1074992: fixed in gftp 2.9.1~beta-3 has caused the Debian Bug report #1074992, regarding gftp: ftbfs with GCC-14 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 1074992: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1074992 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: maintonly@bugs.debian.org
- Subject: gftp: ftbfs with GCC-14
- From: Matthias Klose <doko@debian.org>
- Date: Wed, 03 Jul 2024 12:27:36 +0000
- Message-id: <E1sOz5E-0041D9-N6@paradis.debian.org>
Package: src:gftp Version: 2.9.1~beta-2 Severity: important Tags: sid trixie User: debian-gcc@lists.debian.org Usertags: ftbfs-gcc-14 [This bug is targeted to the upcoming trixie release] Please keep this issue open in the bug tracker for the package it was filed for. If a fix in another package is required, please file a bug for the other package (or clone), and add a block in this package. Please keep the issue open until the package can be built in a follow-up test rebuild. The package fails to build in a test rebuild on at least amd64 with gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The severity of this report will be raised before the trixie release. The full build log can be found at: http://qa-logs.debian.net/2024/07/01/gftp_2.9.1~beta-2_unstable_gccexp.log The last lines of the build log are at the end of this report. To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly, or install the gcc, g++, gfortran, ... packages from experimental. apt-get -t=experimental install g++ Common build failures are new warnings resulting in build failures with -Werror turned on, or new/dropped symbols in Debian symbols files. For other C/C++ related build failures see the porting guide at http://gcc.gnu.org/gcc-14/porting_to.html [...] /usr/bin/msgfmt -o sr.mo sr.po /usr/bin/msgfmt -o sv.mo sv.po /usr/bin/msgfmt -o ta.mo ta.po /usr/bin/msgfmt -o te.mo te.po /usr/bin/msgfmt -o th.mo th.po /usr/bin/msgfmt -o tr.mo tr.po /usr/bin/msgfmt -o uk.mo uk.po /usr/bin/msgfmt -o zh_CN.mo zh_CN.po /usr/bin/msgfmt -o zh_HK.mo zh_HK.po /usr/bin/msgfmt -o zh_TW.mo zh_TW.po make[3]: Leaving directory '/<<PKGBUILDDIR>>/po' Making all in lib make[3]: Entering directory '/<<PKGBUILDDIR>>/lib' gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o cache.o cache.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o charset-conv.o charset-conv.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o config_file.o config_file.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o fsplib.o fsplib.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o ftp-dir-listing.o ftp-dir-listing.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o misc.o misc.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocols.o protocols.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocol_bookmark.o protocol_bookmark.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocol_fsp.o protocol_fsp.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocol_ftp.o protocol_ftp.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocol_ftps.o protocol_ftps.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocol_localfs.o protocol_localfs.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocol_http.o protocol_http.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o protocol_https.o protocol_https.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o pty.o pty.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o sshv2.o sshv2.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o sslcommon.o sslcommon.c gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o socket-connect.o socket-connect.c protocol_http.c: In function ‘http_chunked_read’: protocol_http.c:772:38: warning: comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare] 772 | if (httpdat->content_length == httpdat->read_bytes) | ^~ protocol_http.c:778:47: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘off_t’ {aka ‘long int’} [-Wsign-compare] 778 | if (read_size + httpdat->read_bytes > httpdat->content_length) | ^ protocol_http.c:782:36: warning: comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] 782 | httpdat->chunk_size < read_size) | ^ protocol_http.c:895:31: warning: comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] 895 | if (httpdat->chunk_size < current_size) | ^ gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -D_REENTRANT -DSHARE_DIR=\"/usr/share/gftp\" -DLOCALE_DIR=\"/usr/share/locale\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o sockutils.o sockutils.c pty.c: In function ‘gftp_exec’: pty.c:66:3: warning: ‘__builtin_strncpy’ specified bound 64 equals destination size [-Wstringop-truncation] 66 | strncpy (pts_name, new_pts_name, len); | ^ socket-connect.c: In function ‘gftp_accept_connection’: socket-connect.c:399:31: error: passing argument 3 of ‘accept’ from incompatible pointer type [-Wincompatible-pointer-types] 399 | newfd = accept (*fd, saddr, &request->remote_addr_len); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | | | size_t * {aka long unsigned int *} In file included from gftp.h:53, from socket-connect.c:24: /usr/include/x86_64-linux-gnu/sys/socket.h:307:42: note: expected ‘socklen_t * restrict’ {aka ‘unsigned int * restrict’} but argument is of type ‘size_t *’ {aka ‘long unsigned int *’} 307 | socklen_t *__restrict __addr_len); | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ make[3]: *** [Makefile:442: socket-connect.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory '/<<PKGBUILDDIR>>/lib' make[2]: *** [Makefile:418: all-recursive] Error 1 make[2]: Leaving directory '/<<PKGBUILDDIR>>' make[1]: *** [Makefile:357: all] Error 2 make[1]: Leaving directory '/<<PKGBUILDDIR>>' dh_auto_build: error: make -j8 returned exit code 2 make: *** [debian/rules:6: binary] Error 25 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--- End Message ---
--- Begin Message ---
- To: 1074992-close@bugs.debian.org
- Subject: Bug#1074992: fixed in gftp 2.9.1~beta-3
- From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
- Date: Tue, 10 Sep 2024 19:34:17 +0000
- Message-id: <E1so6cz-003FMz-06@fasolo.debian.org>
- Reply-to: Andreas Beckmann <anbe@debian.org>
Source: gftp Source-Version: 2.9.1~beta-3 Done: Andreas Beckmann <anbe@debian.org> We believe that the bug you reported is fixed in the latest version of gftp, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1074992@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Andreas Beckmann <anbe@debian.org> (supplier of updated gftp package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 10 Sep 2024 21:00:48 +0200 Source: gftp Architecture: source Version: 2.9.1~beta-3 Distribution: unstable Urgency: medium Maintainer: Debian QA Group <packages@qa.debian.org> Changed-By: Andreas Beckmann <anbe@debian.org> Closes: 1074992 Changes: gftp (2.9.1~beta-3) unstable; urgency=medium . * QA upload. * Fix FTBFS with GCC 14. (Closes: #1074992) * Update watch file. Checksums-Sha1: 1bb4bf087735ecb77022b33acd10aa1f285bd640 2053 gftp_2.9.1~beta-3.dsc 8ea73d51edd5dc13f63cbd12814dbef82509d67f 11264 gftp_2.9.1~beta-3.debian.tar.xz b70ca024a2d4377a65ad349cfbf7e0c322cbaac3 12094 gftp_2.9.1~beta-3_source.buildinfo Checksums-Sha256: 640284cdc7a68ae984642d09c63dcea7b8fbf45edfcb51818e1f26df1ae9407a 2053 gftp_2.9.1~beta-3.dsc 75f5ed1cce20dd09912cfafd34f7a9ac11472baa22a0a3be07832b251813a9b9 11264 gftp_2.9.1~beta-3.debian.tar.xz 410112b07bc96d46a15286d54379c09d0ffb1e93fd00b9fb0925c693e580fd09 12094 gftp_2.9.1~beta-3_source.buildinfo Files: 9981268aab2a676493aab3ea84e19a51 2053 net optional gftp_2.9.1~beta-3.dsc 781c90656aea933178c638bbcd72a5f8 11264 net optional gftp_2.9.1~beta-3.debian.tar.xz b8352d556393d449b4c2d221681c69b5 12094 net optional gftp_2.9.1~beta-3_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmbgmcIQHGFuYmVAZGVi aWFuLm9yZwAKCRBfsz+TWentCBBvD/42Ms5ATfYuYeDmMAot0Y934x0fAVpRV8VH oI57uOjF1qnVC/zMcxi6mF8eDL6MsrnBFdG9IzUDlvEwr5u+W/qiYmkz/+HP+9Pf EVgmvURp+wgyevuTvFxmVkkawkPFxlevtT91aHqvqePprv5XV9aiZH6L3JnOBXoX /lXjWxRooBOaBUV9FdESkf9BRWN62QRMSPeEjNQTQlXfJS+TeJ/Zu1TWX4dw5Rwu TX1FS23PNZjs6Hu3ljvZlboOH9yU+xBx23mMsjMAenF2R5sWi6BYC1draNSaozge 8GKL66vJUivC08pflRJGYl6Rp2CRMKu1Tyk2emGWHkuiRkHzFJQspplPeWX+5tEK i/Eqc45MRsu3SnqG5G3a+89CxmvdB24oinSYseQPNMdRhehhe/trkubXDEY74v6X nY3DTj8m2i3TI8nOlIUdaEr6cIJsZpN2v6bSR/1+oFErdRfCJyAJjvk7rLLqVyNS C02uFTgJLqmDGxfvkKFZplqg3qnWCbCJPYx9wiNp5cr0JJqFB46nlGx4Cqetpq4l 3lfxfThDWLfiWG/ZrIjh4VuKsyW6HLXvXu3u6xANLRVtY7hYE1vSJqRj81IayzIh GkYy4Ql31ibVlTe+ombL1usejxBJyEFebbVUw+J8vgm+XPomnV8X3Qh4SQIBj39c WRXdL+f2Tg== =xxbn -----END PGP SIGNATURE-----Attachment: pgplgV8laPhAh.pgp
Description: PGP signature
--- End Message ---