[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1078371: marked as done (nslint: Aborts on s390x while checking for doubly booked addresses)

Your message dated Thu, 15 Aug 2024 15:05:52 +0000
with message-id <E1sec2y-001kWu-MA@fasolo.debian.org>
and subject line Bug#1078371: fixed in nslint 3.2-5
has caused the Debian Bug report #1078371,
regarding nslint: Aborts on s390x while checking for doubly booked addresses
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1078371: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078371
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: nslint
Version: 3.2-1
Severity: important

With the introduction of a autopkgtest check of nslint, it became clear
that it aborts on s390x.  This is what it look like under valgrind:

% NSLINT="valgrind `pwd`/nslint" ./debian/tests/validate-bind-zones 
==2996950== Memcheck, a memory error detector
==2996950== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==2996950== Using Valgrind-3.20.0 and LibVEX; rerun with -h for copyright info
==2996950== Command: /home/pere/nslint/nslint -c named.conf
==2996950== 
cmpaddr: unknown address family 0.
==2996950== 
==2996950== Process terminating with default action of signal 6 (SIGABRT)
==2996950==    at 0x48F4FFE: __pthread_kill_implementation (pthread_kill.c:44)
==2996950==    by 0x48A1117: raise (raise.c:26)
==2996950==    by 0x488225F: abort (abort.c:79)
==2996950==    by 0x109AFF: cmpaddr (nslint.c:624)
==2996950==    by 0x48A5A75: msort_with_tmp.part.0 (qsort.c:239)
==2996950==    by 0x48A5E43: msort_with_tmp (qsort.c:201)
==2996950==    by 0x48A5E43: qsort_r (qsort.c:393)
==2996950==    by 0x48A614D: qsort (qsort.c:405)
==2996950==    by 0x10C011: nslint (nslint.c:1744)
==2996950==    by 0x109789: main (nslint.c:356)
==2996950== 
==2996950== HEAP SUMMARY:
==2996950==     in use at exit: 1,176 bytes in 2 blocks
==2996950==   total heap usage: 8 allocs, 6 frees, 10,614 bytes allocated
==2996950== 
==2996950== LEAK SUMMARY:
==2996950==    definitely lost: 0 bytes in 0 blocks
==2996950==    indirectly lost: 0 bytes in 0 blocks
==2996950==      possibly lost: 0 bytes in 0 blocks
==2996950==    still reachable: 1,176 bytes in 2 blocks
==2996950==         suppressed: 0 bytes in 0 blocks
==2996950== Rerun with --leak-check=full to see details of leaked memory
==2996950== 
==2996950== For lists of detected and suppressed errors, rerun with: -s
==2996950== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Aborted
failure: error in supposed correct zone detected
==2996951== Memcheck, a memory error detector
==2996951== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==2996951== Using Valgrind-3.20.0 and LibVEX; rerun with -h for copyright info
==2996951== Command: /home/pere/nslint/nslint -c named.conf
==2996951== 
nslint: Missing "a": tjener.intern. -> 10.0.0.2
nslint: Missing "ptr": tjener.intern. -> 10.0.2.2
cmpaddr: unknown address family 0.
==2996951== 
==2996951== Process terminating with default action of signal 6 (SIGABRT)
==2996951==    at 0x48F4FFE: __pthread_kill_implementation (pthread_kill.c:44)
==2996951==    by 0x48A1117: raise (raise.c:26)
==2996951==    by 0x488225F: abort (abort.c:79)
==2996951==    by 0x109AFF: cmpaddr (nslint.c:624)
==2996951==    by 0x48A5A75: msort_with_tmp.part.0 (qsort.c:239)
==2996951==    by 0x48A5809: msort_with_tmp (qsort.c:201)
==2996951==    by 0x48A5809: msort_with_tmp.part.0 (qsort.c:210)
==2996951==    by 0x48A5E43: msort_with_tmp (qsort.c:201)
==2996951==    by 0x48A5E43: qsort_r (qsort.c:393)
==2996951==    by 0x48A614D: qsort (qsort.c:405)
==2996951==    by 0x10C011: nslint (nslint.c:1744)
==2996951==    by 0x109789: main (nslint.c:356)
==2996951== 
==2996951== HEAP SUMMARY:
==2996951==     in use at exit: 1,184 bytes in 2 blocks
==2996951==   total heap usage: 8 allocs, 6 frees, 10,622 bytes allocated
==2996951== 
==2996951== LEAK SUMMARY:
==2996951==    definitely lost: 0 bytes in 0 blocks
==2996951==    indirectly lost: 0 bytes in 0 blocks
==2996951==      possibly lost: 0 bytes in 0 blocks
==2996951==    still reachable: 1,184 bytes in 2 blocks
==2996951==         suppressed: 0 bytes in 0 blocks
==2996951== Rerun with --leak-check=full to see details of leaked memory
==2996951== 
==2996951== For lists of detected and suppressed errors, rerun with: -s
==2996951== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Aborted
success: error in zone detected.

This is the failing code:

  /* Check for doubly booked addresses */
  n = ipp - itemlist;
  qsort(itemlist, n, sizeof(itemlist[0]), cmpaddr);

I have tried to debug it, without any success.  I suspect it has always
failed, and just never been tested on s390x before.  I tested ensuring
the items array was zeroed out and to use the correct type for the
network family value, but this did not affect the result.

Index: nslint/nslint.c
===================================================================
--- nslint.orig/nslint.c
+++ nslint/nslint.c
@@ -68,7 +68,7 @@ static const char rcsid[] =
 
 /* Address (network order) */
 struct addr {
-       u_int family;
+       sa_family_t family;
        union {
                struct in_addr _a_addr4;
                struct in6_addr _a_addr6;
@@ -79,7 +79,7 @@ struct addr {
 
 /* Network */
 struct network {
-       u_int family;
+       sa_family_t family;
        union {
                struct in_addr _n_addr4;
                struct in6_addr _n_addr6;
@@ -276,6 +276,7 @@ main(int argc, char **argv)
 {
        char *cp;
        int op, donamedboot, donamedconf;
+       memset(items, 0, ITEMSIZE * sizeof(items[0]));
 
        if ((cp = strrchr(argv[0], '/')) != NULL)
                prog = cp + 1;

I have commited a change in the code to run the self test during build,
which will break the build on s390x.  I believe the best short term
solution is to drop the binary packages om this architecture until a fix
can be found.

-- 
Happy hacking
Petter Reinholdtsen

--- End Message ---
--- Begin Message --- 
Source: nslint
Source-Version: 3.2-5
Done: Petter Reinholdtsen <pere@debian.org>

We believe that the bug you reported is fixed in the latest version of
nslint, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1078371@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated nslint package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 15 Aug 2024 16:29:30 +0200
Source: nslint
Architecture: source
Version: 3.2-5
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Closes: 1078371
Changes:
 nslint (3.2-5) unstable; urgency=medium
 .
   * QA upload.
 .
   * Added 90-larger-buffers.patch to extend buffers avoiding
     possible buffer overrun.
   * Extend autopkgtest to trigger warning of doubly booked address.
   * Corrected address sorting for locating duplications. (Closes: #1078371)
Checksums-Sha1:
 0dc484b6f4a351b6497b32025bccf41de275446a 1769 nslint_3.2-5.dsc
 1dc21f4f5674decbecc447e61ec29e72ec615afc 8216 nslint_3.2-5.debian.tar.xz
 51ce00c3a5541cb9d0dc6d224ef00b202a9a1129 6358 nslint_3.2-5_source.buildinfo
Checksums-Sha256:
 dd6866b30d39805255afd9f0e91abefec52f74ab5d8f566e592c054d0726b27e 1769 nslint_3.2-5.dsc
 9de8a177525652bf591e133d7ca5c3684e1b45f6ff8a3993bb2cb088019fc436 8216 nslint_3.2-5.debian.tar.xz
 c2bc9417f75e941d15fef0a0f28047756a77ff034bec0a94e7574dfb43d2bed1 6358 nslint_3.2-5_source.buildinfo
Files:
 5a3adf79dbe35a28736e3117250288d8 1769 net optional nslint_3.2-5.dsc
 8e1254ca7015b3264177446d746b85c3 8216 net optional nslint_3.2-5.debian.tar.xz
 c3cfdd84df70a2e2737ef4993b10a216 6358 net optional nslint_3.2-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEERqLf4owIeylOb9kkgSgKoIe6+w4FAma+EPkACgkQgSgKoIe6
+w4HXg/+Kw8zDLt90SL8PQew+LvoaHZnS6XIYdpZ7KKK+91R+sAz5DE4s1+8vw6Y
+pyztM5lJyx4T9hCxktCAXWcohX1GSqp/Yh/wsRW9VmqFmJnYWfix6OPncoBBB+I
GMGbDk7w1FoesbodyCget4uHzDtkXN+7JUfu9yds4ZF9N/LnJckvt2rR0mf/QviY
NqrxJxHdtT8XWhoTbbH1+mGHrc6E4ta7YpxkzAr5h9icEeQRK9Vse0xi/SPuxSRS
YZDGrw7UhxTaZ8++mvgnjmad8BChTYAr4HY5g853w+r3DEsUmdiur5KkFKJR34sv
yfMygUcVZCtNhKOXp8VBSnqSZfOL9QjizTgJeS50tVwomGrXD/egsrw5S7oVy6gr
OPDaGedZtSWbERKeTQ6tO+J4Hk0TJWNe82iEgX/dsXZxTPv6+8icT3pxDu3xFvou
Ql+10EsClFsyJQgIXrv4rE4Bp02FEhfhVnxWlVpsFbmv81+190XTwPyq4EIhZw9B
OL2ocDlpnx1IkOWNELKXEhfJEfWYdhuj+fiTLTxaJQvv9Y2CCD6KrGrW5RhA4Kav
QTOCZ/yWigQdB82+smb26lO+/4qAlTBWexn+TVCzY+JQqdLOqcoCLmPsrGw3SzTm
d2I5gXhHGt3Z/CfsOPF+xtdjzOA0qgFYiL1B0bvwk5ukQfIlG84=
=4D2l
-----END PGP SIGNATURE-----

Attachment: pgpiWZxHnZoZg.pgp
Description: PGP signature


--- End Message ---
Reply to: