[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#861372: marked as done (wireless-tools: Please update Makefile for compatibility with -Wl,--as-needed)

Your message dated Wed, 24 Jul 2024 11:43:18 +0100
with message-id <ZqDaxmCjXcr3Gkb9@riva.ucam.org>
and subject line Re: Bug#861372: wireless-tools: Please update Makefile for compatibility with -Wl,--as-needed
has caused the Debian Bug report #861372,
regarding wireless-tools: Please update Makefile for compatibility with -Wl,--as-needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
861372: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861372
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: wireless-tools
Version: 30~pre9-12
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch

Hi Guus,

In Ubuntu, we have applied the attached patch to wireless-tools in order for
the upstream build to be compatible with the Ubuntu toolchain which uses
-Wl,--as-needed by default - as described at
<https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--as-needed>.

While this flag is not enabled by default in Debian, it is useful both to
downstreams such as Ubuntu where it is enabled, and to developers
experimenting with other toolchains for building (e.g. ld.gold, or clang).

Please consider including this patch in the Debian package as well.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

diff -Nru wireless-tools-30~pre9/debian/patches/compiler-link-order.patch wireless-tools-30~pre9/debian/patches/compiler-link-order.patch
--- wireless-tools-30~pre9/debian/patches/compiler-link-order.patch	1969-12-31 16:00:00.000000000 -0800
+++ wireless-tools-30~pre9/debian/patches/compiler-link-order.patch	2017-04-27 20:58:38.000000000 -0700
@@ -0,0 +1,13 @@
+Index: wireless-tools-30~pre9-12ubuntu1/Makefile
+===================================================================
+--- wireless-tools-30~pre9-12ubuntu1.orig/Makefile
++++ wireless-tools-30~pre9-12ubuntu1/Makefile
+@@ -150,7 +150,7 @@
+ 
+ # Compilation of the dynamic library
+ $(DYNAMIC): $(OBJS:.o=.so)
+-	$(CC) -shared -o $@ -Wl,-soname,$@ $(STRIPFLAGS) $(LIBS) $(LDFLAGS) -lc $^
++	$(CC) -shared -o $@ -Wl,-soname,$@ $(STRIPFLAGS) $^ $(LIBS) $(LDFLAGS) -lc
+ 
+ # Compilation of the static library
+ $(STATIC): $(OBJS:.o=.so)
diff -Nru wireless-tools-30~pre9/debian/patches/series wireless-tools-30~pre9/debian/patches/series
--- wireless-tools-30~pre9/debian/patches/series	2016-03-24 13:14:05.000000000 -0700
+++ wireless-tools-30~pre9/debian/patches/series	2017-04-27 20:58:38.000000000 -0700
@@ -5,3 +5,4 @@
 add-import-type-to-udev-rules
 fix-typos
 improve-make-install
+compiler-link-order.patch

--- End Message ---
--- Begin Message --- 
Source: wireless-tools
Source-Version: 30~pre9-13.1

On Thu, Apr 27, 2017 at 09:15:14PM -0700, Steve Langasek wrote:
> In Ubuntu, we have applied the attached patch to wireless-tools in order for
> the upstream build to be compatible with the Ubuntu toolchain which uses
> -Wl,--as-needed by default - as described at
> <https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--as-needed>.
> 
> While this flag is not enabled by default in Debian, it is useful both to
> downstreams such as Ubuntu where it is enabled, and to developers
> experimenting with other toolchains for building (e.g. ld.gold, or clang).
> 
> Please consider including this patch in the Debian package as well.

It wasn't quite the same patch, but something similar was applied in
Debian some time back, and it looks like the corresponding Ubuntu patch
has been dropped in response:

wireless-tools (30~pre9-13.1) unstable; urgency=medium

  * Non-maintainer upload.
  * Fix ftbfs. (Closes: #925857)
    - Thanks Reiner Herrmann.

 -- Sudip Mukherjee <sudipm.mukherjee@gmail.com>  Fri, 13 Mar 2020 20:33:27 +0000

Thanks,

-- 
Colin Watson (he/him)                              [cjwatson@debian.org]

--- End Message ---
Reply to: