[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1067511: marked as done (libgpod: FTBFS with experimental libplist)

Your message dated Wed, 10 Jul 2024 01:03:57 +0000
with message-id <E1sRLkT-00CSO4-L7@fasolo.debian.org>
and subject line Bug#1067511: fixed in libgpod 0.8.3-20
has caused the Debian Bug report #1067511,
regarding libgpod: FTBFS with experimental libplist
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1067511: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067511
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libgpod
Version: 0.8.3-19.1
Severity: normal
Tags: patch

Dear Maintainer,
In Ubuntu, the attached patch was applied to achieve the following:

  * Add two patches from arch linux
    to fix FTBFS with newer libplist


Thanks for considering the patch.

*** /tmp/tmp5qufybct/libgpod_0.8.3-19.1ubuntu2.debdiff
diff -Nru libgpod-0.8.3/debian/patches/fix-new-libplist.patch libgpod-0.8.3/debian/patches/fix-new-libplist.patch
--- libgpod-0.8.3/debian/patches/fix-new-libplist.patch	1970-01-01 01:00:00.000000000 +0100
+++ libgpod-0.8.3/debian/patches/fix-new-libplist.patch	2024-03-22 14:54:42.000000000 +0100
@@ -0,0 +1,34 @@
+Description: Arch linux cherry-picked patch
+Origin: https://gitlab.archlinux.org/archlinux/packaging/packages/libgpod/-/commit/37664b35631261bf707e88132d5920757bcf0958
+Last-Update: 2024-03-22
+
+--- libgpod-0.8.3.orig/tools/ipod-lockdown.c
++++ libgpod-0.8.3/tools/ipod-lockdown.c
+@@ -100,7 +100,7 @@ read_sysinfo_extended_by_uuid (const cha
+ 	plist_get_string_val(ptr, &str);
+ 	if (str != NULL) {
+ 	    ptr = plist_new_string(str);
+-	    plist_dict_insert_item(value, "SerialNumber", ptr);
++	    plist_dict_set_item(value, "SerialNumber", ptr);
+ 	    free(str);
+ 	}
+
+@@ -112,15 +112,15 @@ read_sysinfo_extended_by_uuid (const cha
+ 	plist_get_string_val(ptr, &str);
+ 	if (str != NULL) {
+ 	    ptr = plist_new_string(str);
+-	    plist_dict_insert_item(value, "VisibleBuildID", ptr);
++	    plist_dict_set_item(value, "VisibleBuildID", ptr);
+ 	    free(str);
+ 	}
+
+ 	ptr = plist_new_string(uuid);
+-	plist_dict_insert_item(value, "FireWireGUID", ptr);
++	plist_dict_set_item(value, "FireWireGUID", ptr);
+
+ 	ptr = plist_new_string(uuid);
+-	plist_dict_insert_item(value, "UniqueDeviceID", ptr);
++	plist_dict_set_item(value, "UniqueDeviceID", ptr);
+
+ 	plist_to_xml(value, &xml, &xml_length);
+
diff -Nru libgpod-0.8.3/debian/patches/newer-plist.patch libgpod-0.8.3/debian/patches/newer-plist.patch
--- libgpod-0.8.3/debian/patches/newer-plist.patch	1970-01-01 01:00:00.000000000 +0100
+++ libgpod-0.8.3/debian/patches/newer-plist.patch	2024-03-22 14:54:42.000000000 +0100
@@ -0,0 +1,14 @@
+Description: Patch for newer libplist pkgconfig file
+Origin: https://gitlab.archlinux.org/archlinux/packaging/packages/libgpod/-/commit/c8b8b172f84270323a227a1df565af1713c0bafb
+
+--- libgpod-0.8.3.orig/configure.ac
++++ libgpod-0.8.3/configure.ac
+@@ -42,7 +42,7 @@ AC_CHECK_FUNCS([localtime_r])
+ AC_CHECK_MEMBERS([struct tm.tm_gmtoff],,,[#include <time.h>])
+ dnl sqlite3 is needed for newer ipod models (nano5g), and libplist is needed
+ dnl by libgpod sqlite code
+-PKG_CHECK_MODULES(LIBGPOD, glib-2.0 >= 2.16.0 gobject-2.0 sqlite3 libplist >= 1.0 gmodule-2.0)
++PKG_CHECK_MODULES(LIBGPOD, glib-2.0 >= 2.16.0 gobject-2.0 sqlite3 libplist-2.0 >= 1.0 gmodule-2.0)
+
+ dnl ***************************************************
+ dnl The following functions are only available starting
diff -Nru libgpod-0.8.3/debian/patches/series libgpod-0.8.3/debian/patches/series
--- libgpod-0.8.3/debian/patches/series	2023-12-09 14:05:31.000000000 +0100
+++ libgpod-0.8.3/debian/patches/series	2024-03-22 14:54:42.000000000 +0100
@@ -3,3 +3,5 @@
 Upstream-change-to-speed-up-itdb_resolve_path-calls.patch
 Fix-System-GLib.DateTime-ambiguity.patch
 Fix-wrong-char-for-comments-in-gpod.i.patch
+newer-plist.patch
+fix-new-libplist.patch

--- End Message ---
--- Begin Message --- 
Source: libgpod
Source-Version: 0.8.3-20
Done: Boyuan Yang <byang@debian.org>

We believe that the bug you reported is fixed in the latest version of
libgpod, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1067511@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated libgpod package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 09 Jul 2024 09:42:06 -0400
Source: libgpod
Architecture: source
Version: 0.8.3-20
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 1067511
Changes:
 libgpod (0.8.3-20) unstable; urgency=medium
 .
   * QA upload.
   * debian/copyright: Fix typos.
   * debian/source/lintian-overrides: Add override for false positive.
   * debian/patches/{0006,0007}: Incorporate patches from Ubuntu to make
     libgpod compatible with both the old libplist and the new libplist-2.0.
     (Closes: #1067511)
Checksums-Sha1:
 8358251c9ba45dff0082e2af6c14ef0e8405c19c 2299 libgpod_0.8.3-20.dsc
 5b5f692fef880d714dad71aa21e1737258fa878c 801903 libgpod_0.8.3.orig.tar.bz2
 5796b9336a9c095882df68309e87d2ad1e5c4696 18084 libgpod_0.8.3-20.debian.tar.xz
 8dadb282737acc03e93c0b79885085a72dab6c1e 11316 libgpod_0.8.3-20_amd64.buildinfo
Checksums-Sha256:
 9839358b0ec4904ca951ebc1781eceed07156ee5a5f7ca6eed59c758e2091eb7 2299 libgpod_0.8.3-20.dsc
 638a7959d04e95f1e62abad02bd33702e4e8dfef98485ac7d9d50395c37e955d 801903 libgpod_0.8.3.orig.tar.bz2
 96881b4d18596ca50efeb5001cd1f267c3a783ddf4639df45c7446ff0ccaac84 18084 libgpod_0.8.3-20.debian.tar.xz
 4a3a363113453fef52255274ea8d4e80f8dfc5bdf8d9bf925706dfd140768919 11316 libgpod_0.8.3-20_amd64.buildinfo
Files:
 482d6fa2add9bf9431b31ad01224ed4d 2299 libs optional libgpod_0.8.3-20.dsc
 f8a0b7a34e768e33a708e8dd172bd6f8 801903 libs optional libgpod_0.8.3.orig.tar.bz2
 08d6c97c741763d225e1c3dd14500e63 18084 libs optional libgpod_0.8.3-20.debian.tar.xz
 f756d36fbf3f3793249a4d40c1105b95 11316 libs optional libgpod_0.8.3-20_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmaNQDUACgkQwpPntGGC
Ws76AA//VVX4x3IuGV4OKFER5+ZfA6ne/YDPAfjNYiH/KRbtdMpCFGk9xzlVbNsh
C1qKegdHN3Y6UpVczctdgoWwG+HGlEU1ScgEwq4LedAwE18+c2OXQ5gDjc0Qde0q
EuWO4OEYF7GcAXJRMEz3BYmsLC8M9O52FU50TGhroH0oSwu7HhgHuynF7n3DAt4K
zZ1jBce7SbWj/u76lYmKrgezLPnRo2TSusVSDM9zk5E3NQqsfvUnwe9TnQEq4CNn
hsqj3dSfeXz/8044z9zlGXaGIMnaL+6bsNaJ5gOzD8mfRUISXyS2Z9218W/JWHSO
nPC5Z6lh78l3gDErPauL+pbpfh7XmqBKE++F2vUM1s0UieV3/iYLbPHhNq+LEins
/OseBzN5rbVZwx8KBrECcEiZwkJyhECSkLI4GytgPsv2j7K8SrU95IeU5uMyx1w0
Qb6P5Y0uvt4uVZWizkE5XW0/rejlvKa1F8hWL/kZU4gpYBlJwV+gwBcokAbG9FXS
8oiz2T3EPV0tMxMtxhVIGotxrAsAzEIZ9KPSiDJbBDgZ59g9GcryjJaSus72A138
otflbZ0TbUBaA7TyVrXeo8E0FmSdcZKCtrf8ly9wcd7GxpBAYg0TjCUT/8JdsXV8
Z1WqZ831dgltI6SrBuKKc5Ei3wGxgEJQd7HzsBXFCbym2o9Lw7Y=
=Nrk0
-----END PGP SIGNATURE-----

Attachment: pgp9dchFisJLj.pgp
Description: PGP signature


--- End Message ---
Reply to: