[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#958353: marked as done (sleepd: fails to correctly read acpi subsystem version)

Your message dated Fri, 21 Jun 2024 12:44:00 +0000
with message-id <[🔎] E1sKdcW-00FyGs-31@fasolo.debian.org>
and subject line Bug#1073968: Removed package(s) from unstable
has caused the Debian Bug report #958353,
regarding sleepd: fails to correctly read acpi subsystem version
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
958353: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958353
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sleepd
Version: 2.10
Severity: normal
Tags: patch

Dear Maintainer,

When running with a newer kernel (4.19.0-8-amd64 from buster, though
this also occurs with 5.4.0-0.bpo.4-amd64 from backports), and without
upower installed, sleepd fails to start, complaining

	ACPI subsystem 2018081 too is old, consider upgrading to 20011018.

It appears that with these kernels, /sys/module/acpi/parameters/acpica_version
no longer ends with a newline character.  This file actually contains
"20180810".  Note that the final '0' character is discarded.

It seems that acpi.c:get_acpi_file() is erroneously truncating the
last byte when reading acpi files.  This was never exposed earlier, as
the truncated byte was a newline, not part of the version number.

The following patch seems to fix the problem.


--- acpi.c.dist	2018-09-16 03:13:08.000000000 -0600
+++ acpi.c	2020-04-18 08:13:44.946652962 -0600
@@ -67,7 +67,8 @@
 	fd = open(file, O_RDONLY);
 	if (fd == -1) return NULL;
 	end = read(fd, buf, sizeof(buf));
-	buf[end-1] = '\0';
+	buf[end] = '\0';
 	close(fd);
 	return buf;
 }




-- System Information:
Debian Release: 10.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-0.bpo.4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C), LANGUAGE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages sleepd depends on:
ii  libc6            2.28-10
ii  libglib2.0-0     2.58.3-2+deb10u2
ii  libupower-glib3  0.99.10-1
ii  lsb-base         10.2019051400

Versions of packages sleepd recommends:
ii  pm-utils  1.4.1-18
pn  upower    <none>

sleepd suggests no packages.

-- Configuration Files:
/etc/default/sleepd changed:
PARAMS="-b 2 -s '/etc/acpi/sleep_suspend.sh sleep'"


-- no debconf information

--- End Message ---
--- Begin Message --- 
Version: 2.11+rm

Dear submitter,

as the package sleepd has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1073968

The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

--- End Message ---
Reply to: