[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1014426: marked as done (cldump: reproducible-builds: embedded build paths in /usr/bin/cldump)

Your message dated Sun, 02 Jun 2024 07:19:02 +0000
with message-id <E1sDfUc-001bPH-Cc@fasolo.debian.org>
and subject line Bug#1014426: fixed in cldump 0.11~dfsg-8
has caused the Debian Bug report #1014426,
regarding cldump: reproducible-builds: embedded build paths in /usr/bin/cldump
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1014426: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014426
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: cldump
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/cldump:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/cldump.html

  /build/1st/cldump-0.11~dfsg/src/cldump.c:180
  vs.
  /build/2/cldump-0.11~dfsg/2nd/src/cldump.c:180

The attached patch fixes this by explicitly passing CFLAGS to
dh_auto_build in debian/rules, which includes flags to avoid embedding
the build path.


With this patch applied, cldump should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant

From e65c0a4b1a6bb623feddd15e7ec0fda53dbd7422 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 5 Jul 2022 19:46:11 +0000
Subject: [PATCH] debian/rules: Pass CFLAGS via dh_auto_build override.

src/Makefile sets CFLAGS explicitly, ignoring CFLAGS from the
environment. This means various default flags are otherwise ignored,
e.g. -ffile-prefix-map which is used to avoid embedding build paths
for reproducible builds.
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 5b70f17..f12e8a3 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,3 +6,6 @@
 
 %:
 	dh $@ --sourcedirectory=src --buildsystem=makefile
+
+override_dh_auto_build:
+	dh_auto_build --sourcedirectory=src --buildsystem=makefile -- CFLAGS="$(CFLAGS)"
-- 
2.36.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: cldump
Source-Version: 0.11~dfsg-8
Done: Petter Reinholdtsen <pere@debian.org>

We believe that the bug you reported is fixed in the latest version of
cldump, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1014426@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated cldump package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 02 Jun 2024 08:53:55 +0200
Source: cldump
Architecture: source
Version: 0.11~dfsg-8
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Closes: 1014426
Changes:
 cldump (0.11~dfsg-8) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Vagrant Cascadian ]
   * debian/rules: Pass CFLAGS via dh_auto_build override. (Closes: #1014426)
 .
   [ Petter Reinholdtsen ]
   * Refreshed 01-hardening.patch with metadata and more future proof approach.
Checksums-Sha1:
 32653dd2a81bcc2fdb90499e640d372f4dbaf54c 1809 cldump_0.11~dfsg-8.dsc
 3ed533cffa0383f965b7d2b05e51669e50b1ba63 3888 cldump_0.11~dfsg-8.debian.tar.xz
 c40cf0d2b0423ad350db5a0d8d97d4e761680d95 6369 cldump_0.11~dfsg-8_source.buildinfo
Checksums-Sha256:
 8eb04cf50c2f7d91b4dcea73ceb6076f96af5892699c68ad6f745f4b063c6e82 1809 cldump_0.11~dfsg-8.dsc
 8fd8233e098fc59e9ac4ac29c8e5d34824c2327f50bb0a5e534cb03f9c24569a 3888 cldump_0.11~dfsg-8.debian.tar.xz
 80c7dc103438f19686d0a3a7edd1cd1bf1ab496e27a4dbc8a624d496a4a4fa6d 6369 cldump_0.11~dfsg-8_source.buildinfo
Files:
 189219dcec4a3c84cbd62a63eb7422b9 1809 misc optional cldump_0.11~dfsg-8.dsc
 c7abeb62c5edd4877db6823769e9e332 3888 misc optional cldump_0.11~dfsg-8.debian.tar.xz
 435be3beaf23accb6ae47a2cbc077f0b 6369 misc optional cldump_0.11~dfsg-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEERqLf4owIeylOb9kkgSgKoIe6+w4FAmZcGD8ACgkQgSgKoIe6
+w66mg/9EP0CKvVjVtUnadLwWWPXqiww6XuDHDIgpYMDyucIENuX4+x6znJgNg4I
hHwgPkTESYUcC2zjPsknN7iaun6GWStcvTQpoJ6KyJWmROZqI7kNXcCXxHcweFt4
hHjiwXgjvQrDZ+DFRM99wIsfpMMxA/cVkrZtGaPOk8yQV7WrX/Jg01o8ugI7PtYc
9AL3aSskDCxX/NFpaZx4rHgJmjNJxWfYwL2FBn+a5ydvKUAlftwFgNguzrJKkeBO
xlLZdNY3ezOLpQl+dhflxZJKoPmKsF3jy1A6ZDDuf9/ymjxPa+LnDA22zNwMMpiQ
DRYaKUlBLzs9o4RyEghdd+bmcQd42YAmJV21StgQ+rMknT9lgg2quc0dxzO9RWdU
8TgI8DLvzufiSCGXbdrhY1ZPEiiolpvjElmvXgy8m7usnFMTgby2S/RQQAGsJYBb
4FD3fHE1/0R+O77JvAzpnFBVnMcnTMfOiT1JWtU4sIlMI+Qd4lR4PnFp7/e6cTNi
9i9zENH5MRbSLuD4A7RuFW+5G7Vc1cz78QoVQq5KmrIy4GbGQWEJP/Nw6fUIH65H
CH59x9XK7Im+Lia4YYvlMPd0AYRKPsWE9k8vX2X/lWy+RT/N0l3sqDxn6Cc401MS
LE3AH5P1/sE+L9rqpg93CX/zRlkBH0iH1X0Iyu6sgFvTxP3gpR4=
=EKpw
-----END PGP SIGNATURE-----

Attachment: pgp77jAkVMskD.pgp
Description: PGP signature


--- End Message ---
Reply to: