[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1021470: marked as done (xsok: reproducible-builds: build path embedded in /usr/games/xsok)

Your message dated Fri, 03 May 2024 16:39:42 +0000
with message-id <E1s2vwk-007jRb-7h@fasolo.debian.org>
and subject line Bug#1021470: fixed in xsok 1.02-21
has caused the Debian Bug report #1021470,
regarding xsok: reproducible-builds: build path embedded in /usr/games/xsok
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1021470: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021470
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: xsok
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/games/xsok:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xsok.html

  /build/1st/xsok-1.02/src/Xaw-main.c:273
  vs.
  /build/2/xsok-1.02/2nd/src/Xaw-main.c:273

The attached patch to debian/rules fixes this by passing to make the
default CFLAGS using the upstream CCOPTIONS variable.

According to my local tests, with this patch applied, xsok should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining xsok!

live well,
  vagrant

From 61246f44398cd2537268920502a906aa99f8233c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 9 Oct 2022 01:21:33 +0000
Subject: [PATCH] debian/rules: Pass default CFLAGS via CCOPTIONS variable.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 216e53d..fc9561e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,7 +15,7 @@ build-indep: build
 build: build-stamp
 build-stamp:
 	dh_testdir
-	$(MAKE) $(OPTIMIZE) \
+	$(MAKE) CCOPTIONS="$(shell dpkg-buildflags --get CFLAGS)" $(OPTIMIZE) \
 	  LOCAL_LIBRARIES='-lXpm -lXaw -lXt -lX11' \
 	  XSOKLIBDIR=/usr/share/games/xsok \
 	  XSOKSAVEDIR=/var/games/xsok
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: xsok
Source-Version: 1.02-21
Done: Petter Reinholdtsen <pere@debian.org>

We believe that the bug you reported is fixed in the latest version of
xsok, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1021470@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated xsok package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 03 May 2024 18:17:42 +0200
Source: xsok
Architecture: source
Version: 1.02-21
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Closes: 1021470
Changes:
 xsok (1.02-21) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Vagrant Cascadian ]
   * debian/rules: Pass default CFLAGS via CCOPTIONS variable. (Closes: #1021470)
 .
   [ Petter Reinholdtsen ]
   * Include CPPFLAGS and LDFLAGS during build for hardening.
 .
   [ Vagrant Cascadian ]
   * debian/rules: Convert to dh.
Checksums-Sha1:
 9b2462c31c38d503d953f6ba2fab34a5a06dccc5 1846 xsok_1.02-21.dsc
 515ace922e2b5bf0481d95d568d376779c242531 19284 xsok_1.02-21.debian.tar.xz
 c93c4d62defc100c90745fdc96db6e3f744a5f42 7251 xsok_1.02-21_source.buildinfo
Checksums-Sha256:
 572106b44e7cef45886d148fa59b9890e972fefea91651defecfe63d2c29fa22 1846 xsok_1.02-21.dsc
 7a8025beb49d4916e67b6c0ac87902dd6b185154d0ea0134ac287bfa2175afb7 19284 xsok_1.02-21.debian.tar.xz
 1b5b40dda439ffc7fdabc8681596dc81dd794d4f97f9b36a28b9e512709de6f3 7251 xsok_1.02-21_source.buildinfo
Files:
 868b284d3ddacf64a5017e7199385d94 1846 games optional xsok_1.02-21.dsc
 e2c1951abc304ce2f81fb976a75e858e 19284 games optional xsok_1.02-21.debian.tar.xz
 ca3ebe4bcbda9d56e9ffe7d0f5c727bf 7251 games optional xsok_1.02-21_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEERqLf4owIeylOb9kkgSgKoIe6+w4FAmY1DnAACgkQgSgKoIe6
+w5r/w/+IyPl5OZBwfZYuf9ngb5PXqiTDVyC/PJllGIvRMhDQmMWZpvZVKM1boTh
VHMIyE1vaTRXgM4wC79UVi3Xs0YF4b48Hxl9fsBReLuE1h6+OlPXBsn5oWyQp2/u
A4Zrm52YNN1zlG2aY2zPiseLSckAHmMljIyATbBNuCYJeUkh8RuOz4N9BtrO8RQ/
F8B/H8ufUHjNz0lQJ/QPx8hemVraeDUfwftUts5i9WbOEiiBOg+I1/84H+7c3Zmb
T+7yGiz0QYvwgDRXaX4jvVuRgd073rSFAwRWjJeXx96r6yUkHWEg/420BMBwWBmm
m3ittIHn7aU6omifDh4y0q5hTd4V6IUQuxEVWTYf932CJ08eSPDVcemuhSO1ks9u
eFPIIfxaD7FXOR0lxPoMtWqY64BgAX77ECLBeFxCJfyjKMNDlZIU+W1wCbyvmvZR
luPQ2wFDfBPD95I3uMG9pQaeqMURJv5GyrrXOTxt9mPaONvo5f3DgrTtJHHDGoud
V0ET6mA387O4ei6x3ef3e19HktZP1CcRm58Ectrq5WK6WE7pKGT64F5wJGVWeYFM
L5XG0nLuy0p/BcGpZ9GFBBJzPULJ3O5GXJ1ExeM1DdyPsISKJy7xFmqEc/kF+lzw
KcCyO4ZPEVPc0xX5qkxkQxr+9SEZIDHF1EaDFVAejMbmouPzYwI=
=Nv28
-----END PGP SIGNATURE-----

Attachment: pgpwNR3xJkDrg.pgp
Description: PGP signature


--- End Message ---
Reply to: