[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1066462: marked as done (dot-forward: FTBFS: control.c:65:41: error: implicit declaration of function ‘close’ [-Werror=implicit-function-declaration])

Your message dated Wed, 17 Apr 2024 09:49:19 +0000
with message-id <E1rx1up-00Did6-EB@fasolo.debian.org>
and subject line Bug#1066462: fixed in dot-forward 1:0.71-7
has caused the Debian Bug report #1066462,
regarding dot-forward: FTBFS: control.c:65:41: error: implicit declaration of function ‘close’ [-Werror=implicit-function-declaration]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1066462: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066462
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: dot-forward
Version: 1:0.71-6
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> ( cat warn-auto.sh; \
> echo CC=\'`head -1 conf-cc`\'; \
> echo LD=\'`head -1 conf-ld`\' \
> ) > auto-ccld.sh
> nroff -man dot-forward.1 > dot-forward.0
> cat auto-ccld.sh make-load.sh > make-load
> cat auto-ccld.sh find-systype.sh > find-systype
> cat auto-ccld.sh make-compile.sh > make-compile
> cat auto-ccld.sh make-makelib.sh > make-makelib
> chmod 755 make-load
> chmod 755 find-systype
> chmod 755 make-compile
> chmod 755 make-makelib
> ./find-systype > systype
> ( cat warn-auto.sh; ./make-load "`cat systype`" ) > load
> ( cat warn-auto.sh; ./make-compile "`cat systype`" ) > \
> compile
> ( cat warn-auto.sh; ./make-makelib "`cat systype`" ) > \
> makelib
> chmod 755 load
> chmod 755 makelib
> chmod 755 compile
> ./compile dot-forward.c
> ./compile control.c
> ( ( ./compile tryvfork.c && ./load tryvfork ) >/dev/null \
> 2>&1 \
> && cat fork.h2 || cat fork.h1 ) > fork.h
> ./compile auto-str.c
> ./compile substdio.c
> ./compile substdi.c
> ./compile substdo.c
> ./compile subfderr.c
> control.c: In function ‘control_readline’:
> control.c:65:41: error: implicit declaration of function ‘close’ [-Werror=implicit-function-declaration]
>    65 |  if (getln(&ss,sa,&match,'\n') == -1) { close(fd); return -1; }
>       |                                         ^~~~~
> dot-forward.c: In function ‘run’:
> dot-forward.c:78:7: error: implicit declaration of function ‘pipe’ [-Werror=implicit-function-declaration]
>    78 |   if (pipe(pi) == -1)
>       |       ^~~~
> dot-forward.c:81:19: error: implicit declaration of function ‘fork’ [-Werror=implicit-function-declaration]
>    81 |   switch (child = fork()) {
>       |                   ^~~~
> dot-forward.c:85:7: error: implicit declaration of function ‘close’ [-Werror=implicit-function-declaration]
>    85 |       close(pi[1]);
>       |       ^~~~~
> dot-forward.c:86:11: error: implicit declaration of function ‘fd_move’ [-Werror=implicit-function-declaration]
>    86 |       if (fd_move(0,pi[0]) == -1)
>       |           ^~~~~~~
> dot-forward.c:89:7: error: implicit declaration of function ‘sig_pipedefault’ [-Werror=implicit-function-declaration]
>    89 |       sig_pipedefault();
>       |       ^~~~~~~~~~~~~~~
> dot-forward.c:90:7: error: implicit declaration of function ‘execv’ [-Werror=implicit-function-declaration]
>    90 |       execv(*args,args);
>       |       ^~~~~
> auto-str.c:8:6: warning: conflicting types for built-in function ‘puts’; expected ‘int(const char *)’ [-Wbuiltin-declaration-mismatch]
>     8 | void puts(s)
>       |      ^~~~
> auto-str.c:4:1: note: ‘puts’ is declared in header ‘<stdio.h>’
>     3 | #include "exit.h"
>   +++ |+#include <stdio.h>
>     4 | 
> dot-forward.c: In function ‘readcontrols’:
> dot-forward.c:141:7: error: implicit declaration of function ‘chdir’ [-Werror=implicit-function-declaration]
>   141 |   if (chdir(auto_qmail) == -1)
>       |       ^~~~~
> dot-forward.c:160:7: error: implicit declaration of function ‘fchdir’ [-Werror=implicit-function-declaration]
>   160 |   if (fchdir(fddir) == -1)
>       |       ^~~~~~
> dot-forward.c: In function ‘gotaddr’:
> dot-forward.c:189:12: error: implicit declaration of function ‘case_diffb’ [-Werror=implicit-function-declaration]
>   189 |       if (!case_diffb(address.s,address.len,user)) {
>       |            ^~~~~~~~~~
> dot-forward.c: In function ‘main’:
> dot-forward.c:389:3: error: implicit declaration of function ‘sig_pipeignore’ [-Werror=implicit-function-declaration]
>   389 |   sig_pipeignore();
>       |   ^~~~~~~~~~~~~~
> rm -f tryvfork.o tryvfork
> ./compile substdio_copy.c
> ./compile error.c
> ./compile error_str.c
> ./compile str_len.c
> ./compile str_diffn.c
> ./compile byte_chr.c
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:75: control.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/dot-forward_0.71-6_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

--- End Message ---
--- Begin Message --- 
Source: dot-forward
Source-Version: 1:0.71-7
Done: Andreas Beckmann <anbe@debian.org>

We believe that the bug you reported is fixed in the latest version of
dot-forward, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1066462@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <anbe@debian.org> (supplier of updated dot-forward package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 17 Apr 2024 11:16:54 +0200
Source: dot-forward
Architecture: source
Version: 1:0.71-7
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Beckmann <anbe@debian.org>
Closes: 1066462
Changes:
 dot-forward (1:0.71-7) unstable; urgency=medium
 .
   * QA upload.
   * Fix building with -Werror=implicit-function-declaration.
     (Closes: #1066462)
Checksums-Sha1:
 b0d81a424fb34ae818d063e630e6bbc9f41354e1 1897 dot-forward_0.71-7.dsc
 ad390924c8eba24cd236a204d15bcc17bdb98d90 5096 dot-forward_0.71-7.debian.tar.xz
 8c4156e6739b4de2127ffb5972c537a57f8e9b70 5641 dot-forward_0.71-7_source.buildinfo
Checksums-Sha256:
 5f8ef5feec0ebf15ca4f25da631d86b688ce63b7ab913bb7735a1b8bd0674f08 1897 dot-forward_0.71-7.dsc
 3b4582b4ddcf2e34fc72e55ed58fc85ae71d1c0472734cf80391eb97d95edd7a 5096 dot-forward_0.71-7.debian.tar.xz
 3e2ff9f2a5c62692f247737055dc8db7f133c2a8c917b2a605bac5b6ef16e552 5641 dot-forward_0.71-7_source.buildinfo
Files:
 5a596f03b73f2d1eaa175b4b4b5d76c3 1897 mail optional dot-forward_0.71-7.dsc
 db4d36c343af9604f3747586a0f8b25a 5096 mail optional dot-forward_0.71-7.debian.tar.xz
 fd04b3b8f45e0dcdef38c547bafdbb56 5641 mail optional dot-forward_0.71-7_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmYflQgQHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCFz9EACLBzcQtzGZamtOB3DYkwHE2ui/sEUy1KZU
bMGIBGqPdkPyVet26O9FGUZsROf170Otm64Ls9hxKajR+jzbxfrIOkUSpz0zIe6z
PLk/Jgf7OTNbVc2oXZIKJq4QdR6d+nYNy9m1qFFLgKw9116oZgC8tisAfZrqlNbh
sJCE5pivysyaJyWlGHkq0/zv3KFq+HP9agUSs8OLSrt8dpaOzZDOqgPrSPTONuSH
nVSBQsjEPWkZcdgas6OAs43kcuxMqy+XSjstG6GXLp+0EocsO2L78lWj55PZjJKo
kH06e6qu984NrO6TDC0HNFNAqNYheBkpoKgUmIDNFjYEqj8zWCQZ54273F5/7JEE
VKOkogV/WiHznbD5rhNDImrl+p1kdj/dC03T5g2OrqwMzB2VcR82eENvdeef0E+V
nkWHoNZEyGc5VRmtH59Q1H0+It0g716rXkpeSDKGPI2CxmQYdgOFmw9iYt0+yXb3
InhFDTfQey5s1hooaxk5N7DzRLlfH/YRzyEk7IiczeUsZ3bYT9uPSYawLjSSZ+j2
brX40j0S54+7HMooqJUfo0FQ571I99YQODwEZ1VE75p0qUm11qGYSULDL/aYFTJJ
qzqQ4X65g8bsu2Z7w0+X1QJn6N9hr8btMnrUPFTSJWtrTb0C+QrANTbGX/qy1f21
YNA18EZcAQ==
=2151
-----END PGP SIGNATURE-----

Attachment: pgpfw41F0mexg.pgp
Description: PGP signature


--- End Message ---
Reply to: