[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1021466: marked as done (pacman: reproducible-builds: build path embedded in /usr/games/pacman)

Your message dated Mon, 15 Apr 2024 16:06:01 +0000
with message-id <E1rwOqH-004xgK-8V@fasolo.debian.org>
and subject line Bug#1021466: fixed in pacman 10-20
has caused the Debian Bug report #1021466,
regarding pacman: reproducible-builds: build path embedded in /usr/games/pacman
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1021466: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021466
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: pacman
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/games/pacman:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/pacman.html

  /build/1st/pacman-10/pac.cc:85
  vs.
  /build/2/pacman-10/2nd/pac.cc:85

The attached patch fixes this adjusting the generated Makefile from
debian/rules to include -ffile-prefix-map in the CXXFLAGS_DEFINES
variable.

Alternately, it might be worth using "dpkg-buildflags --get CXXFLAGS"
instead of hard-coding -ffile-prefix-map, and will benefit from other
useful flags as well.

According to my local tests, with this patch applied, pacman should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining pacman!

live well,
  vagrant

From c2c6a41d218ae21765360832814e1d61d887f529 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 9 Oct 2022 00:20:22 +0000
Subject: [PATCH 1/2] debian/rules: Add -ffile-prefix-map to CXXEXTRA_DEFINES
 in generated Makefile to avoid embedding build paths.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index 406e691..5092f98 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,6 +10,8 @@ build-indep: build-stamp
 build-stamp:
 	dh_testdir
 	xmkmf -a
+	# Avoid embedding build path
+	sed -i -e "s,CXXEXTRA_DEFINES =,CXXEXTRA_DEFINES = -ffile-prefix-map=$(CURDIR)=.,g" Makefile
 	$(MAKE)
 	touch build-stamp
 
-- 
2.37.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: pacman
Source-Version: 10-20
Done: Petter Reinholdtsen <pere@debian.org>

We believe that the bug you reported is fixed in the latest version of
pacman, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1021466@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated pacman package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 15 Apr 2024 17:51:04 +0200
Source: pacman
Architecture: source
Version: 10-20
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Closes: 1021466
Changes:
 pacman (10-20) unstable; urgency=medium
 .
   * QA upload.
 .
   * Added d/gbp.conf to enforce the use of pristine-tar.
   * Updated vcs in d/control to Salsa.
   * Updated Standards-Version from 4.6.0 to 4.7.0.
   * Switched to simpler dh build rules and enabled hardening.
   * Replaced obsolete build dependency libncurses5-dev with libncurses-dev.
   * Add xmkmf override to make build reproducible. (Closes: 1021466)
Checksums-Sha1:
 bf1a261b16b3cea593bf9cf0eb8914d357725aae 1795 pacman_10-20.dsc
 51769f1d6e8babe3d0caaf87aabfbe11b81f314b 9704 pacman_10-20.debian.tar.xz
 26b33de3cb83e3635c8f9f02a2fd3972dc85ea66 6917 pacman_10-20_source.buildinfo
Checksums-Sha256:
 939bdbc8ddcd1c67f8fef50b4642a0678a3b0b5d83171e66860cfab747d9aa7f 1795 pacman_10-20.dsc
 8aa9df29d1f7ab185e9be5314d956c0ad32305ede73ddf2b62bc00456bcd6522 9704 pacman_10-20.debian.tar.xz
 25ec510f5c4fea6ca8d7a71d4a29e3f1ad1f76c3c3166a4ba65c13fb3787b0e9 6917 pacman_10-20_source.buildinfo
Files:
 7d74eb2c4d8955acc549f7193b449c60 1795 games optional pacman_10-20.dsc
 ea65d498a18c1ef2740004f5cbe4c4bd 9704 games optional pacman_10-20.debian.tar.xz
 586c5eef3066cfb69279f1a52936d3dd 6917 games optional pacman_10-20_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEERqLf4owIeylOb9kkgSgKoIe6+w4FAmYdTUAACgkQgSgKoIe6
+w4xghAAqPv90sX5G8MiMKg2Ml4q0NmjBdOx/R2uoO100iJ+f6RPEt8QET1a+lNs
uMJWUQ+JY7TXE10bqa9DS1VCzL3bpnKX1LEBgQhnwYceNJwYdIA3zgCO+B9ItEZq
kfGb7J27x1Wjp2p+sC7UcwWJe/iI607kBkWLlEe7uXjlfgatAOQ4Wb7u1/wvrOrp
X3UBJqlBEXca8XMKRvHfKace2ARsMCcDbrHpf1Mdn5L8sCz7gF8/Z/QB0UBuhfHQ
aYBxCnPM6Wlxl9RiTxJOxr8k5SLEIJ8FK2etgAW9DrQl9JzXBDhcq3Ob8LiPYyKV
0uKo7Q7vjEClrtk1Xg3ZAOQqo0kHliM3X1ww+wSmDrju1oklSWGTT9CD7drkaQiU
j0gINJMziK+phtxmZSwKHSTbm2ax2pYtpdKwH5hjGqUfu9DY0ecjEPUYHfhrg0DE
IIIwPlqs/6A4t31ZzjEIEU9UnLdCwWMFmJETM14t7kP8ddS4DIgbVQXtDl3YR+mY
13VvUNEdov/ImoRDO3UP1eTJeAIZukHuJO9oHhHljKcak0yx4Xkrx9oLdReuwbfd
qZVBmrpnNIj6vj+T6DkGMETwlLosrDn+6BwfzOpCy+OJbNgEPjIrox3eSVRkNNZH
kqtD4SIgX5Z7YKo20YvPapdzJR6ZiNUi/T8b3Vp2fMf59zoQ4iA=
=C25o
-----END PGP SIGNATURE-----

Attachment: pgpJVHuLN84Ch.pgp
Description: PGP signature


--- End Message ---
Reply to: