[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1066511: marked as done (photopc: FTBFS: fnames.c:118:21: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration])



Your message dated Fri, 05 Apr 2024 02:36:37 +0000
with message-id <E1rsZRV-00CtKi-1l@fasolo.debian.org>
and subject line Bug#1066511: fixed in photopc 3.07-3
has caused the Debian Bug report #1066511,
regarding photopc: FTBFS: fnames.c:118:21: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1066511: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066511
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: photopc
Version: 3.07-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -c -o eph_iob.o eph_iob.c
> filetime.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: filetime.c,v 1.7 1999/12/11 14:10:15 crosser Exp $";
>       |              ^~~~~
> fnames.c: In function ‘makename’:
> fnames.c:118:21: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]
>   118 |             (filenm[strlen(filenm)-1] == '\\') ||
>       |                     ^~~~~~
> fnames.c:69:1: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
>    68 | #include "ctimez.h"
>   +++ |+#include <string.h>
>    69 | 
> fnames.c:118:21: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   118 |             (filenm[strlen(filenm)-1] == '\\') ||
>       |                     ^~~~~~
> fnames.c:118:21: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
> fnames.c:128:21: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   128 |                 if (strlen(nameformat) == 1) {
>       |                     ^~~~~~
> fnames.c:128:21: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
> fnames.c:282:22: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   282 |         for (p=fname+strlen(filenm);*p;p++) if (*p == '/') {
>       |                      ^~~~~~
> fnames.c:282:22: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
> fnames.c: At top level:
> fnames.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: fnames.c,v 1.7 2001/01/11 06:49:57 crosser Exp $";
>       |              ^~~~~
> exifscan.c: In function ‘exifscan’:
> exifscan.c:64:50: warning: pointer targets in passing argument 1 of ‘strcasecmp’ differ in signedness [-Wpointer-sign]
>    64 |                 if ((*p == 0xe1) && (strcasecmp(p+3,"Exif")==0)) {
>       |                                                 ~^~
>       |                                                  |
>       |                                                  unsigned char *
> In file included from /usr/include/string.h:462,
>                  from exifscan.c:48:
> /usr/include/strings.h:116:36: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
>   116 | extern int strcasecmp (const char *__s1, const char *__s2)
>       |                        ~~~~~~~~~~~~^~~~
> exifscan.c: In function ‘exifstr’:
> exifscan.c:225:41: warning: pointer targets in returning ‘char *’ from a function with return type ‘unsigned char *’ differ in signedness [-Wpointer-sign]
>   225 |                 if (buf == NULL) return "<no memory>";
>       |                                         ^~~~~~~~~~~~~
> exifscan.c:226:25: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign]
>   226 |                 sprintf(buf,"\"%s\"",data+offset);
>       |                         ^~~
>       |                         |
>       |                         unsigned char *
> In file included from /usr/include/features.h:490,
>                  from /usr/include/x86_64-linux-gnu/sys/types.h:25,
>                  from exifscan.c:44:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:28:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
>    28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
>       | ^~~~~
> exifscan.c:236:41: warning: pointer targets in returning ‘char *’ from a function with return type ‘unsigned char *’ differ in signedness [-Wpointer-sign]
>   236 |                 if (buf == NULL) return "<no memory>";
>       |                                         ^~~~~~~~~~~~~
> exifscan.c:240:40: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign]
>   240 |                 if (count > 1) sprintf(buf,"(");
>       |                                        ^~~
>       |                                        |
>       |                                        unsigned char *
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:28:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
>    28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
>       | ^~~~~
> exifscan.c:243:52: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
>   243 |                                 sprintf(buf+strlen(buf),"%s%d/%d",
>       |                                                    ^~~
>       |                                                    |
>       |                                                    unsigned char *
> /usr/include/string.h:407:35: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
>   407 | extern size_t strlen (const char *__s)
>       |                       ~~~~~~~~~~~~^~~
> eph_iob.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: eph_iob.c,v 2.7 1999/12/11 14:10:15 crosser Exp $";
>       |              ^~~~~
> exifscan.c:243:44: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign]
>   243 |                                 sprintf(buf+strlen(buf),"%s%d/%d",
>       |                                         ~~~^~~~~~~~~~~~
>       |                                            |
>       |                                            unsigned char *
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:28:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
>    28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
>       | ^~~~~
> exifscan.c:248:52: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
>   248 |                                 sprintf(buf+strlen(buf),"%s%d",
>       |                                                    ^~~
>       |                                                    |
>       |                                                    unsigned char *
> /usr/include/string.h:407:35: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
>   407 | extern size_t strlen (const char *__s)
>       |                       ~~~~~~~~~~~~^~~
> exifscan.c:248:44: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign]
>   248 |                                 sprintf(buf+strlen(buf),"%s%d",
>       |                                         ~~~^~~~~~~~~~~~
>       |                                            |
>       |                                            unsigned char *
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:28:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
>    28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
>       | ^~~~~
> exifscan.c:253:51: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
>   253 |                 if (count > 1) sprintf(buf+strlen(buf),")");
>       |                                                   ^~~
>       |                                                   |
>       |                                                   unsigned char *
> /usr/include/string.h:407:35: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
>   407 | extern size_t strlen (const char *__s)
>       |                       ~~~~~~~~~~~~^~~
> exifscan.c:253:43: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign]
>   253 |                 if (count > 1) sprintf(buf+strlen(buf),")");
>       |                                        ~~~^~~~~~~~~~~~
>       |                                           |
>       |                                           unsigned char *
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:28:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
>    28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
>       | ^~~~~
> exifscan.c: At top level:
> exifscan.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: exifscan.c,v 1.5 2000/05/09 13:20:54 crosser Exp $";
>       |              ^~~~~
> a12scan.c: In function ‘a12search’:
> a12scan.c:114:29: warning: pointer targets in passing argument 1 of ‘strncmp’ differ in signedness [-Wpointer-sign]
>   114 |                 if (strncmp(p,key,strlen(key)) == 0) break;
>       |                             ^
>       |                             |
>       |                             unsigned char *
> In file included from a12scan.c:70:
> /usr/include/string.h:159:33: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
>   159 | extern int strncmp (const char *__s1, const char *__s2, size_t __n)
>       |                     ~~~~~~~~~~~~^~~~
> a12scan.c: At top level:
> a12scan.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: a12scan.c,v 1.13 1999/08/01 21:36:54 crosser Exp $";
>       |              ^~~~~
> ctimez.c: In function ‘ctimetz’:
> ctimez.c:96:17: error: implicit declaration of function ‘strcpy’ [-Werror=implicit-function-declaration]
>    96 |                 strcpy(tmbuf,"N/A");
>       |                 ^~~~~~
> ctimez.c:63:1: note: include ‘<string.h>’ or provide a declaration of ‘strcpy’
>    62 | #include "ctimez.h"
>   +++ |+#include <string.h>
>    63 | 
> ctimez.c:96:17: warning: incompatible implicit declaration of built-in function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
>    96 |                 strcpy(tmbuf,"N/A");
>       |                 ^~~~~~
> ctimez.c:96:17: note: include ‘<string.h>’ or provide a declaration of ‘strcpy’
> ctimez.c: At top level:
> ctimez.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: ctimez.c,v 1.7 1999/11/09 18:55:03 crosser Exp $";
>       |              ^~~~~
> eph_read.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: eph_read.c,v 2.11 2000/07/14 06:35:39 crosser Exp $";
>       |              ^~~~~
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -c -o eph_err.o eph_err.c
> photopc.c: In function ‘llistfiles’:
> photopc.c:1619:21: warning: pointer targets in assignment from ‘char *’ to ‘unsigned char *’ differ in signedness [-Wpointer-sign]
>  1619 |                 ress=buffer;
>       |                     ^
> photopc.c:1622:18: warning: pointer targets in assignment from ‘unsigned char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
>  1622 |                 p=a12search("Resolution",ress,ressize);
>       |                  ^
> photopc.c:1629:18: warning: pointer targets in assignment from ‘unsigned char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
>  1629 |                 p=a12search("Flash",ress,ressize);
>       |                  ^
> photopc.c:1636:18: warning: pointer targets in assignment from ‘unsigned char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
>  1636 |                 p=a12search("Shutter",ress,ressize);
>       |                  ^
> photopc.c:1643:18: warning: pointer targets in assignment from ‘unsigned char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
>  1643 |                 p=a12search("TimeDate",ress,ressize);
>       |                  ^
> photopc.c: In function ‘retrfile’:
> photopc.c:1873:20: warning: pointer targets in assignment from ‘char *’ to ‘unsigned char *’ differ in signedness [-Wpointer-sign]
>  1873 |                 res=buffer;
>       |                    ^
> photopc.c:1876:18: warning: pointer targets in assignment from ‘unsigned char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
>  1876 |                 p=a12search("TimeDate",res,ressize);
>       |                  ^
> photopc.c:1916:25: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
>  1916 |                         if (fname) free(fname); fname=NULL;
>       |                         ^~
> photopc.c:1916:49: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
>  1916 |                         if (fname) free(fname); fname=NULL;
>       |                                                 ^~~~~
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -c -o eph_cmd.o eph_cmd.c
> cc1: some warnings being treated as errors
> eph_err.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: eph_err.c,v 2.6 1999/08/01 21:36:54 crosser Exp $";
>       |              ^~~~~
> photopc.c: In function ‘main’:
> photopc.c:2443:23: warning: ignoring return value of ‘seteuid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  2443 |                 (void)seteuid(getuid());
>       |                       ^~~~~~~~~~~~~~~~~
> photopc.c: At top level:
> photopc.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
>     2 | static char *rcsid="$Id: photopc.c,v 2.87 2003/03/14 15:25:36 crosser Exp $";
>       |              ^~~~~
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -c -o eph_io.o eph_io.c
> make[2]: *** [Makefile:599: ctimez.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/photopc_3.07-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

--- End Message ---
--- Begin Message ---
Source: photopc
Source-Version: 3.07-3
Done: Andreas Beckmann <anbe@debian.org>

We believe that the bug you reported is fixed in the latest version of
photopc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1066511@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <anbe@debian.org> (supplier of updated photopc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 05 Apr 2024 03:45:07 +0200
Source: photopc
Architecture: source
Version: 3.07-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Beckmann <anbe@debian.org>
Closes: 1066511
Changes:
 photopc (3.07-3) unstable; urgency=medium
 .
   * QA upload.
   * Fix building with -Werror=implicit-function-declaration.
     (Closes: #1066511)
   * Declare Rules-Requires-Root: no.
Checksums-Sha1:
 5af31ecb1f466bd5f487800621aad02bc92af5b0 1739 photopc_3.07-3.dsc
 829e6b37986049d0ebc6d89407a32af3432879d5 5484 photopc_3.07-3.debian.tar.xz
 4ad3b6b9c1a35fdda891c3776823c8e485a87fa4 5638 photopc_3.07-3_source.buildinfo
Checksums-Sha256:
 c4af3f1d80d5387a1155cce223c0eaa5373d1f7f75db25024c4d4dfe97585eac 1739 photopc_3.07-3.dsc
 b8cbe736895c0ac58874eb676bc0bc8db42a03d62c6334632741b12a94a1213a 5484 photopc_3.07-3.debian.tar.xz
 24e5804edad84a2dcf25d2cfaf782c10c1db59c0c10bbfc8fdcc225a82b0d427 5638 photopc_3.07-3_source.buildinfo
Files:
 cbe70497ec30c53635e2c0a815de3a93 1739 graphics optional photopc_3.07-3.dsc
 99111eed34c582f1f5a03a0b3648469d 5484 graphics optional photopc_3.07-3.debian.tar.xz
 2d94fac7661f63407f2523e073f500b7 5638 graphics optional photopc_3.07-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmYPWAkQHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCBkxEACw20VWdY6OtGzsTJZJotQZutW9Uj5qNQOi
ElF1HLvnxeC/Wvd8XvKxEi10fQE3SsAik4av8gRAdjvsqdpAHeF5pK/0dzL4UJ/X
u3RXmhjkv2/AAwg9ZyyAh4L+FlWpIO5Xnko1HlorV2Pm21hk9DsvhhI/y3wmtCTS
Mgc0WJnQdsooQyz92VoPopKvx+GE/SHM92oQuxPTsITzteB6/fA5UXpwXAEWBcKo
1W4HjtGkDZlKATBu3wSYdwGbpDVD8EQcONG5YOo+4h4FDPPUFuzFRO5GM002yEiO
2tkpOTdxLpEDc8xqmg/6k0OAWXwdYAhkrpZ0o1PBFpr8SKD5zIz97jDVdEg8ir5J
BWTMsn7oSNi4GsPn2cELvxdd0fE96L+Eecz1+oJVPOD51rGo6UYkvX8SCDpmwDfT
zVI0MsLAEAyQ66KTBjxsskCHlGM1w85g9YHKY24edx+iZb8qJkshSuZ/gs5pkPgA
0r9/6JaipT6Iqxgi2pkefF7x+nkPSYfD/wSssDmb5Q2Ec8+Rce1xLxg5tp3MS3wr
zoHOtaM1M75cL2srgChTubRnLT7dkrHNXZgThqA6ONwqDH3V9wrAszJ/c+GHmLiY
Wg/9B90BYywfHFuJOiG+oikdc+rpyD/81baI9IyFYLB0ko/I73dygaxE4XDVGy5y
bFKPu2GCgg==
=Uzti
-----END PGP SIGNATURE-----

Attachment: pgpL8Ci01q7YS.pgp
Description: PGP signature


--- End Message ---

Reply to: