Bug#1066651: spectools: FTBFS: wispy_hw_gen1.c:296:15: error: implicit declaration of function ‘wispy24x_adler_checksum’; did you mean ‘wispy1_adler_checksum’? [-Werror=implicit-function-declaration]
Source: spectools
Version: 201601r1-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> gcc -Wdate-time -D_FORTIFY_SOURCE=2 -D_DEBUG -I./ -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c spectool_net_server.c -o spectool_net_server.o
> wispy_hw_dbx.c: In function ‘wispydbx_usb_setposition’:
> wispy_hw_dbx.c:1289:27: warning: assignment to ‘uint8_t *’ {aka ‘unsigned char *’} from incompatible pointer type ‘wispydbx_rfsettings_v2 *’ {aka ‘struct _wispydbx_rfsettings_v2 *’} [-Wincompatible-pointer-types]
> 1289 | use_rfset = &rfset2;
> | ^
> wispy_hw_dbx.c:1312:27: warning: assignment to ‘uint8_t *’ {aka ‘unsigned char *’} from incompatible pointer type ‘wispydbx_rfsettings *’ {aka ‘struct _wispydbx_rfsettings *’} [-Wincompatible-pointer-types]
> 1312 | use_rfset = &rfset;
> | ^
> spectool_net_client.c: In function ‘spectool_netcli_block_sweep’:
> spectool_net_client.c:367:62: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 6 has type ‘long unsigned int’ [-Wformat=]
> 367 | snprintf(errstr, SPECTOOL_ERROR_MAX, "Got sweep frame too small to hold "
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> spectool_net_client.c:368:99: note: format string is defined here
> 368 | "indicated number of samples, bailing - %u samples %u < %u",
> | ~^
> | |
> | unsigned int
> | %lu
> wispy_hw_gen1.c: In function ‘wispy1_usb_init_path’:
> wispy_hw_gen1.c:296:15: error: implicit declaration of function ‘wispy24x_adler_checksum’; did you mean ‘wispy1_adler_checksum’? [-Werror=implicit-function-declaration]
> 296 | cid = wispy24x_adler_checksum(combopath, 128);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> | wispy1_adler_checksum
> ubertooth_hw_u1.c: In function ‘ubertooth_u1_device_scan’:
> ubertooth_hw_u1.c:266:41: error: implicit declaration of function ‘wispy24x_adler_checksum’ [-Werror=implicit-function-declaration]
> 266 | wispy24x_adler_checksum(combopath, 128);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> spectool_net_client.c:426:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 426 | write(((spectool_net_dev_aux *) (sni->phydev->auxptr))->spipe[1], "0", 1);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> wispy_hw_gen1.c: In function ‘wispy1_usb_open’:
> wispy_hw_gen1.c:557:21: error: implicit declaration of function ‘wispy24x_usb_detach_hack’; did you mean ‘wispy_usb_detach_hack’? [-Werror=implicit-function-declaration]
> 557 | if (wispy24x_usb_detach_hack(auxptr->devhdl, 0, phydev->errstr) < 0) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> | wispy_usb_detach_hack
> spectool_net_client.c: In function ‘spectool_netcli_enabledev’:
> spectool_net_client.c:517:9: warning: ignoring return value of ‘pipe’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 517 | pipe(aux->spipe);
> | ^~~~~~~~~~~~~~~~
> spectool_net_client.c: In function ‘spectool_net_poll’:
> spectool_net_client.c:634:9: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 634 | read(((spectool_net_dev_aux *) phydev->auxptr)->spipe[0], junk, 8);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> spectool_raw.c: In function ‘main’:
> spectool_raw.c:320:29: error: implicit declaration of function ‘spectool_netcli_writepoll’; did you mean ‘spectool_netcli_poll’? [-Werror=implicit-function-declaration]
> 320 | if (spectool_netcli_writepoll(&sr, errstr) < 0) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> | spectool_netcli_poll
> spectool_raw.c:376:48: warning: too many arguments for format [-Wformat-extra-args]
> 376 | printf("Configured device %u (%s)\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ubertooth_hw_u1.c:259:61: warning: ‘%s’ directive output may be truncated writing up to 4096 bytes into a region of size 64 [-Wformat-truncation=]
> 259 | snprintf(auxpair->bus, 64, "%s", bus->dirname);
> | ^~
> In file included from /usr/include/stdio.h:906,
> from ubertooth_hw_u1.c:16:
> In function ‘snprintf’,
> inlined from ‘ubertooth_u1_device_scan’ at ubertooth_hw_u1.c:259:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin_snprintf’ output between 1 and 4097 bytes into a destination of size 64
> 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 55 | __glibc_objsize (__s), __fmt,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 56 | __va_arg_pack ());
> | ~~~~~~~~~~~~~~~~~
> ubertooth_hw_u1.c: In function ‘ubertooth_u1_device_scan’:
> ubertooth_hw_u1.c:260:61: warning: ‘%s’ directive output may be truncated writing up to 4096 bytes into a region of size 64 [-Wformat-truncation=]
> 260 | snprintf(auxpair->dev, 64, "%s", dev->filename);
> | ^~
> In function ‘snprintf’,
> inlined from ‘ubertooth_u1_device_scan’ at ubertooth_hw_u1.c:260:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin_snprintf’ output between 1 and 4097 bytes into a destination of size 64
> 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 55 | __glibc_objsize (__s), __fmt,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 56 | __va_arg_pack ());
> | ~~~~~~~~~~~~~~~~~
> wispy_hw_24x.c: In function ‘wispy24x_usb_device_scan’:
> wispy_hw_24x.c:274:61: warning: ‘%s’ directive output may be truncated writing up to 4096 bytes into a region of size 64 [-Wformat-truncation=]
> 274 | snprintf(auxpair->bus, 64, "%s", bus->dirname);
> | ^~
> In file included from /usr/include/stdio.h:906,
> from wispy_hw_24x.c:17:
> In function ‘snprintf’,
> inlined from ‘wispy24x_usb_device_scan’ at wispy_hw_24x.c:274:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin_snprintf’ output between 1 and 4097 bytes into a destination of size 64
> 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 55 | __glibc_objsize (__s), __fmt,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 56 | __va_arg_pack ());
> | ~~~~~~~~~~~~~~~~~
> wispy_hw_24x.c: In function ‘wispy24x_usb_device_scan’:
> wispy_hw_24x.c:275:61: warning: ‘%s’ directive output may be truncated writing up to 4096 bytes into a region of size 64 [-Wformat-truncation=]
> 275 | snprintf(auxpair->dev, 64, "%s", dev->filename);
> | ^~
> In function ‘snprintf’,
> inlined from ‘wispy24x_usb_device_scan’ at wispy_hw_24x.c:275:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin_snprintf’ output between 1 and 4097 bytes into a destination of size 64
> 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 55 | __glibc_objsize (__s), __fmt,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 56 | __va_arg_pack ());
> | ~~~~~~~~~~~~~~~~~
> gcc -Wdate-time -D_FORTIFY_SOURCE=2 -D_DEBUG -I./ -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c spectool_curses.c -o spectool_curses.o
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:97: ubertooth_hw_u1.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/spectools_201601r1-3_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Reply to: