Bug#1066271: libdigidoc: FTBFS: DigiDocVerify.c:939:11: error: implicit declaration of function ‘ddocGetDNPartFromString’ [-Werror=implicit-function-declaration]
Source: libdigidoc
Version: 3.10.5-4.1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/libdigidoc && /usr/bin/cc -DBUILD_DATE=\"28.02.2024\" -DBUILD_VER=0 -DMAJOR_VER=3 -DMINOR_VER=10 -DRELEASE_VER=5 -DVER_SUFFIX=\"\" -Ddigidoc_EXPORTS -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/usr/include/libxml2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fvisibility=hidden -MD -MT libdigidoc/CMakeFiles/digidoc.dir/DigiDocOCSP.c.o -MF CMakeFiles/digidoc.dir/DigiDocOCSP.c.o.d -o CMakeFiles/digidoc.dir/DigiDocOCSP.c.o -c /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocVerify.c:939:11: error: implicit declaration of function ‘ddocGetDNPartFromString’ [-Werror=implicit-function-declaration]
> 939 | err = ddocGetDNPartFromString(sDN, sId, &mbuf2);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocVerify.c: In function ‘verifyNotaryInfoCERT2’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocVerify.c:1568:35: warning: passing argument 1 of ‘ossl_check_X509_type’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> 1568 | sk_X509_push(ver_certs, notCert);
> | ^~~~~~~
> In file included from /usr/include/openssl/types.h:33,
> from /usr/include/openssl/x509.h:26:
> /usr/include/openssl/x509.h:78:1: note: expected ‘X509 *’ {aka ‘struct x509_st *’} but argument is of type ‘const X509 *’ {aka ‘const struct x509_st *’}
> 78 | SKM_DEFINE_STACK_OF_INTERNAL(X509, X509, X509)
> | ^
> In file included from /usr/include/string.h:535,
> from /usr/include/openssl/ec.h:23,
> from /usr/include/openssl/x509.h:33,
> from /<<PKGBUILDDIR>>/libdigidoc/DigiDocLib.h:36,
> from /<<PKGBUILDDIR>>/libdigidoc/DigiDocConvert.h:25,
> from /<<PKGBUILDDIR>>/libdigidoc/DigiDocConvert.c:24:
> In function ‘strncat’,
> inlined from ‘breakToLinesOf64’ at /<<PKGBUILDDIR>>/libdigidoc/DigiDocConvert.c:887:7:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:138:10: warning: ‘__builtin_strncat’ specified bound [9223372036854775811, 18446744073709551615] exceeds maximum object size 9223372036854775807 [-Wstringop-overread]
> 138 | return __builtin___strncat_chk (__dest, __src, __len,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 139 | __glibc_objsize (__dest));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c: In function ‘WriteOCSPResponse’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:249:18: warning: passing argument 1 of ‘ASN1_i2d_bio’ from incompatible pointer type [-Wincompatible-pointer-types]
> 249 | ASN1_i2d_bio((int (*)(void*, unsigned char**))i2d_OCSP_RESPONSE, bout, (unsigned char*)resp);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | int (*)(void *, unsigned char **)
> In file included from /usr/include/openssl/objects.h:21,
> from /usr/include/openssl/evp.h:43,
> from /usr/include/openssl/x509.h:29,
> from /<<PKGBUILDDIR>>/libdigidoc/DigiDocLib.h:36,
> from /<<PKGBUILDDIR>>/libdigidoc/DigiDocConfig.h:29,
> from /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:23:
> /usr/include/openssl/asn1.h:967:31: note: expected ‘int (*)(const void *, unsigned char **)’ but argument is of type ‘int (*)(void *, unsigned char **)’
> 967 | int ASN1_i2d_bio(i2d_of_void *i2d, BIO *out, const void *x);
> | ~~~~~~~~~~~~~^~~
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c: In function ‘WriteOCSPRequest’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:297:18: warning: passing argument 1 of ‘ASN1_i2d_bio’ from incompatible pointer type [-Wincompatible-pointer-types]
> 297 | ASN1_i2d_bio((int (*)(void*, unsigned char**))i2d_OCSP_RESPONSE, bout, (unsigned char*)req);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | int (*)(void *, unsigned char **)
> /usr/include/openssl/asn1.h:967:31: note: expected ‘int (*)(const void *, unsigned char **)’ but argument is of type ‘int (*)(void *, unsigned char **)’
> 967 | int ASN1_i2d_bio(i2d_of_void *i2d, BIO *out, const void *x);
> | ~~~~~~~~~~~~~^~~
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c: In function ‘get_authority_key_from_cert’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:838:3: warning: ‘ASN1_STRING_data’ is deprecated: Since OpenSSL 1.1.0 [-Wdeprecated-declarations]
> 838 | ret = decodeHex((unsigned char*)hex_to_string(ASN1_STRING_data(val->keyid), ASN1_STRING_length(val->keyid)));
> | ^~~
> /usr/include/openssl/asn1.h:683:40: note: declared here
> 683 | OSSL_DEPRECATEDIN_1_1_0 unsigned char *ASN1_STRING_data(ASN1_STRING *x);
> | ^~~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c: In function ‘OCSP_sendreq_bio_withParams’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:965:26: warning: passing argument 1 of ‘ASN1_i2d_bio’ from incompatible pointer type [-Wincompatible-pointer-types]
> 965 | retcode = ASN1_i2d_bio((int (*)(void*, unsigned char**))i2d_OCSP_REQUEST, b, (unsigned char*)req);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | int (*)(void *, unsigned char **)
> /usr/include/openssl/asn1.h:967:31: note: expected ‘int (*)(const void *, unsigned char **)’ but argument is of type ‘int (*)(void *, unsigned char **)’
> 967 | int ASN1_i2d_bio(i2d_of_void *i2d, BIO *out, const void *x);
> | ~~~~~~~~~~~~~^~~
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c: In function ‘verifyOCSPResponse’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:1605:31: warning: passing argument 1 of ‘ossl_check_X509_type’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> 1605 | sk_X509_push(ver_certs, notCert);
> | ^~~~~~~
> In file included from /usr/include/openssl/types.h:33,
> from /usr/include/openssl/x509.h:26:
> /usr/include/openssl/x509.h:78:1: note: expected ‘X509 *’ {aka ‘struct x509_st *’} but argument is of type ‘const X509 *’ {aka ‘const struct x509_st *’}
> 78 | SKM_DEFINE_STACK_OF_INTERNAL(X509, X509, X509)
> | ^
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c: In function ‘checkNonceAndCertbyOCSP’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:1668:32: warning: passing argument 1 of ‘get_authority_key’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> 1668 | if((ikey = get_authority_key(X509_get0_extensions(cert))) != NULL) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:766:60: note: expected ‘struct stack_st_X509_EXTENSION *’ but argument is of type ‘const struct stack_st_X509_EXTENSION *’
> 766 | unsigned char *get_authority_key(STACK_OF(X509_EXTENSION) *exts)
> | ^
> [ 80%] Building C object libdigidoc/CMakeFiles/digidoc.dir/DigiDocDfExtract.c.o
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/libdigidoc && /usr/bin/cc -DBUILD_DATE=\"28.02.2024\" -DBUILD_VER=0 -DMAJOR_VER=3 -DMINOR_VER=10 -DRELEASE_VER=5 -DVER_SUFFIX=\"\" -Ddigidoc_EXPORTS -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/usr/include/libxml2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fvisibility=hidden -MD -MT libdigidoc/CMakeFiles/digidoc.dir/DigiDocDfExtract.c.o -MF CMakeFiles/digidoc.dir/DigiDocDfExtract.c.o.d -o CMakeFiles/digidoc.dir/DigiDocDfExtract.c.o -c /<<PKGBUILDDIR>>/libdigidoc/DigiDocDfExtract.c
> [ 84%] Building C object libdigidoc/CMakeFiles/digidoc.dir/DigiDocHTTP.c.o
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/libdigidoc && /usr/bin/cc -DBUILD_DATE=\"28.02.2024\" -DBUILD_VER=0 -DMAJOR_VER=3 -DMINOR_VER=10 -DRELEASE_VER=5 -DVER_SUFFIX=\"\" -Ddigidoc_EXPORTS -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/usr/include/libxml2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fvisibility=hidden -MD -MT libdigidoc/CMakeFiles/digidoc.dir/DigiDocHTTP.c.o -MF CMakeFiles/digidoc.dir/DigiDocHTTP.c.o.d -o CMakeFiles/digidoc.dir/DigiDocHTTP.c.o -c /<<PKGBUILDDIR>>/libdigidoc/DigiDocHTTP.c
> [ 88%] Building C object libdigidoc/CMakeFiles/digidoc.dir/DigiDocService.c.o
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/libdigidoc && /usr/bin/cc -DBUILD_DATE=\"28.02.2024\" -DBUILD_VER=0 -DMAJOR_VER=3 -DMINOR_VER=10 -DRELEASE_VER=5 -DVER_SUFFIX=\"\" -Ddigidoc_EXPORTS -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/usr/include/libxml2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fvisibility=hidden -MD -MT libdigidoc/CMakeFiles/digidoc.dir/DigiDocService.c.o -MF CMakeFiles/digidoc.dir/DigiDocService.c.o.d -o CMakeFiles/digidoc.dir/DigiDocService.c.o -c /<<PKGBUILDDIR>>/libdigidoc/DigiDocService.c
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocService.c: In function ‘ddsGetStatusWithFile’:
> /<<PKGBUILDDIR>>/libdigidoc/DigiDocService.c:327:19: error: implicit declaration of function ‘ddocAddSignatureFromMemory’ [-Werror=implicit-function-declaration]
> 327 | err = ddocAddSignatureFromMemory(pSigDoc, szFileName, (const void*)p1, strlen(p1));
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [libdigidoc/CMakeFiles/digidoc.dir/build.make:359: libdigidoc/CMakeFiles/digidoc.dir/DigiDocService.c.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/libdigidoc_3.10.5-4.1_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Reply to: