[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1051010: marked as done (lwm: please set XDG_CURRENT_DESKTOP and use it to configure xdg-desktop-portal)

Your message dated Sat, 17 Feb 2024 23:41:58 +0000
with message-id <E1rbUJi-004cEg-7X@fasolo.debian.org>
and subject line Bug#1051010: fixed in lwm 1.2.4-2
has caused the Debian Bug report #1051010,
regarding lwm: please set XDG_CURRENT_DESKTOP and use it to configure xdg-desktop-portal
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1051010: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051010
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lwm
Version: 1.2.4-1
Severity: normal
User: xdg-desktop-portal@packages.debian.org
Usertags: portals.conf

As well as being available as a window manager to integrate into some
larger environment, Lwm behaves like a very small desktop environment
in its own right, by providing a /usr/share/xsessions/lwm.desktop
which can be selected on entry to a display manager such as lightdm.
If it's going to register as a desktop environment, then it should behave
like a desktop environment in other ways, such as choosing an
XDG_CURRENT_DESKTOP identifier.

xdg-desktop-portal 1.17.x introduces a new way to select which portals will
be used for which desktop environments, modelled on mimeapps.list:

- each desktop environment should provide a file like
  /usr/share/xdg-desktop-portal/lwm-portals.conf

- the filename is ${DESKTOP}-portals.conf where ${DESKTOP} is the desktop
  environment's entry in $XDG_CURRENT_DESKTOP (the same as the DesktopNames
  from /usr/share/{x,wayland-}sessions/*.desktop), folded to lower case

- sysadmins and users can override this via files named portals.conf or
  ${DESKTOP}-portals.conf in various locations like /etc/xdg-desktop-portal
  and ~/.config/xdg-desktop-portal

But as far as I can tell, Lwm doesn't set XDG_CURRENT_DESKTOP, so for
the purposes of this mechanism, it's not programmatically distinguishable
from any other desktop environment or window manager.

XDG_CURRENT_DESKTOP is also used in pre-existing freedesktop.org standards
like the OnlyShowIn/NotShowIn fields for .desktop files, and the ability to
provide a desktop-environment-specific mimeapps.list. Setting
XDG_CURRENT_DESKTOP would allow Lwm to participate in those
specifications.

To reproduce
============

* Start from a basic non-GUI virtual machine (I used autopkgtest-build-qemu)
* Ensure that a user account exists
* apt install lightdm xorg lwm
* reboot
* Log in as the user account, selecting "Lwm" from the menu of
  possible X11 sessions
* Open an xterm and run:
  systemctl --user show-environment

(It's the systemd activation environment that matters here, more than
`env`, because xdg-desktop-portal will typically be run as a systemd
user service.)

Expected result
===============

XDG_CURRENT_DESKTOP should be set to a colon-separated sequence of
desktop environment names, most specific first. Lwm seems to be its
own thing rather than being based on another desktop environment, so

    XDG_CURRENT_DESKTOP=Lwm

would seem appropriate.

This would allow the Lwm session to have its own
desktop-environment-specific mimeapps.list or portals.conf(5), for
example /usr/share/xdg-desktop-portal/lwm-portals.conf.

Actual result
=============

XDG_CURRENT_DESKTOP is unset.

This means that xdg-desktop-portal configuration can only be done via a
non-desktop-specific portals.conf, but that's not really something that a
non-opinionated distribution like Debian can usefully ship in a centralized
way, so each user of Lwm who wants a working xdg-desktop-portal will
have to configure it themselves.

At the moment, this is mitigated by xdg-desktop-portal (>= 1.17) having
been patched to fall back to xdg-desktop-portal-gtk as a last-resort
desktop-environment-specific backend, but hard-coding that implementation
isn't really something we should be doing centrally (and the idea was
rejected upstream), so I intend to remove that patch before trixie
is released.

Suggested fix
=============

Add a sequence of semicolon-separated desktop environment names to
/usr/share/xsessions/lwm.desktop, most likely just "Lwm":

DesktopNames=Lwm;

(For example, icewm and windowmaker use "ICEWM" and "WindowMaker" in
their equivalent xsessions file.)

And then create a /usr/share/xdg-desktop-portal/lwm-portals.conf
with whatever portal backends are desired for an Lwm session,
for example perhaps this:

[preferred]
default=gtk;

Please see portals.conf(5) or its source code
https://github.com/flatpak/xdg-desktop-portal/blob/main/doc/portals-conf.rst
for full details.

Thanks,
    smcv

-- 
This is part of a mass bug filing:
https://lists.debian.org/debian-devel/2023/08/msg00311.html

--- End Message ---
--- Begin Message --- 
Source: lwm
Source-Version: 1.2.4-2
Done: Nicholas Bamber <np.bamber@gmail.com>

We believe that the bug you reported is fixed in the latest version of
lwm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1051010@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicholas Bamber <np.bamber@gmail.com> (supplier of updated lwm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 13 Feb 2024 09:42:48 +0000
Source: lwm
Architecture: source
Version: 1.2.4-2
Distribution: unstable
Urgency: medium
Maintainer: Nicholas Bamber <np.bamber@gmail.com>
Changed-By: Nicholas Bamber <np.bamber@gmail.com>
Closes: 920091 1031650 1051010
Changes:
 lwm (1.2.4-2) unstable; urgency=medium
 .
   * New maintainer (Closes: #920091)
   * Rewrote description to be more informative
   * Fixed typo. (Closes: #1031650)
   * Added minimal support for xdg-desktop-portal (Closes: #1051010)
     + Added additional fields to session desktop file
       so that the Display Manager will pass XDG_CURRENT_DESKTOP=lwm
       to systemd
     + Added portals config file allowing xdg-desktop-portal
       to use whatever backends are available
   * Removed dependencies that don't exist in Debian
     + Removed fbdesk as it no longer exists
     + Replaced alternatives to x-term-emulator
   * Bumped standards version to 4.6.2
     + Set alternative priority to 40
   * Reviewed patches
     + Updated metadata of patches
     + Consolidated default terminal patches
   * Resolved other lintian warnings
     + Updated copyright information
     + Changed http to https in all URLs
     + Upstream bug submission URL
     + Removed trailing white space
     + Provided 2 overrides for dead upstream
     + Added Rules-Requires-Root field to debian/control
   * Added debian specific .gitignore
   * Removed obsolete build system
     + Instead of calling xmkmf, copy upstream backup Makefile
     + Ignore upstream backup Makefile for install
     + Copy lwm.man to lwm.1
     + Add files for dh_install, dh_installman, dh_clean
     + Removed dependency on xutils-dev
     + Patch upstream backup Makefile to be debhelper compliant
       and replicate the old system defines
       but without the warnings
Checksums-Sha1:
 9a0673626a35234f4e17a7916d8870883988ef69 1827 lwm_1.2.4-2.dsc
 819309e7383e29f38e2a4edadf197c310d3b6c46 47519 lwm_1.2.4.orig.tar.gz
 f9a63ad7d01301dd32e166686865767a41419e6c 8720 lwm_1.2.4-2.debian.tar.xz
 acb1afe410b80d6e6ab7f27d2738669daf28dfae 6977 lwm_1.2.4-2_amd64.buildinfo
Checksums-Sha256:
 75965ed814a31b68e49314bb0d7d84f13e2e9ae40621afaee74bf749db04ef69 1827 lwm_1.2.4-2.dsc
 7ec05d5572c90340335a586e7a227b561512f21b7710ea5d30f401374ec88dad 47519 lwm_1.2.4.orig.tar.gz
 df2d3a464564652b0cb59676c8bab3c64bf95f085bda9f0ade750c919f8f7ca2 8720 lwm_1.2.4-2.debian.tar.xz
 79aa6ec91113505e9ca91d45da06a7c027e7e9bfa41ba33ba71d7e6b29ecf65a 6977 lwm_1.2.4-2_amd64.buildinfo
Files:
 28c1675f21f3b9b216fdb08d43f3b150 1827 x11 optional lwm_1.2.4-2.dsc
 69fc645ded46b6801092183e01be8518 47519 x11 optional lwm_1.2.4.orig.tar.gz
 6abc3162194326d804e65e81c8647290 8720 x11 optional lwm_1.2.4-2.debian.tar.xz
 cb61748063d9d7c8323283c653024f8f 6977 x11 optional lwm_1.2.4-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmXRJCYACgkQwpPntGGC
Ws7RaQ//X89T8vv0MH44OkFqmVpLESbfgSHAgZzBdmfPF4AkYBNfTmbMOq7YT+VI
iRyRpCrqBAX7dqz2swpS2iEgFaAQpH0ZKFQRjrdqybECoQABouIRpW/hldesfYB4
KbXZyZvYepTitRJWrPRSxdD1I9olFaLo2Yte5Xm/DCvaXMGFZjV+gXxrjf3Smu+K
xdvLhJfyrYLlVoeE8cQtilBq1R6kd1qNgAIMr4c+jGyEzMb8Oj0wkLSRVp2n8mW5
H2+HxozfTnAw+NxzGo3WQKt8+X+rTH6lfl4Lo0oDltt2xP56N+uNR+cb7heE2by1
kHGNMDM3AcdRvXkZdXUyxeIKYIlm8ry4Io2f+aVAVfvPJUwloQwYG+KNevxM4//r
4esNRD3Sz9uBacC/DrqRU9dtOf0jMOOwGxLEI/I+UbZMYmQSVGk0MR3g56tv77GH
+pFQEnQskkfL1gQlZTk+oZZ+gOlcQSQWfLhgc2bFVfVSj3FTsJuEWB+6t0S3gRzC
LoymdK8Um70FjDJkhqRMcxX8BX8Cp3F7ILdk5FCQ9fezpoLYoLGG9FAaX8muVWUu
S7B9cpM4/kXWZ1Gap9uYLmSyWzbKfmylekdQ/XhTdN6EFHQBkQN/u/I6OyexWPwt
kDBiW3PQXz51TfDzIbSAbsnfJ9lyiwk+f50apt20VVOrxGSPvbE=
=5YRy
-----END PGP SIGNATURE-----

Attachment: pgpN7L5odyBvY.pgp
Description: PGP signature


--- End Message ---
Reply to: